From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F1D6443351; Fri, 17 Nov 2023 11:20:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 886D040648; Fri, 17 Nov 2023 11:20:35 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2046.outbound.protection.outlook.com [40.107.244.46]) by mails.dpdk.org (Postfix) with ESMTP id 4616940273 for ; Fri, 17 Nov 2023 11:20:34 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lN5Tcgh/b+Ff2h/Cqqc4Zu3CRLLNePqtYB5H5n0BQncCkFGM8y940VPmffv31g3SrlXflf4mYL9muJ25xp5NoSqaKcc0pzYZPmxaKAAfMeKz0EXMCQXYG0/xYIL85QTpMbC6fGNWV6EWlXWCabaDTH92QeMAk2Tn0JGzax3jbN6tN8l6SPpqJcNNKINFMMb2RyVOV86CgAdTrInskc3YOH9P5Pou5VhLBhQePFbQloccLhcNeWxU8J1QKFpvfsNsirUlrX6JKSI/jxZ1i0ZFRIWjSsaoGXE7CEEmhlSvGqo5czACeDARNBHw0BzGTCa9z6KQ/v/7Ghc2XU5ylEL1Hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZBXO8YASv3UnScNFPhacz08PrWjKBC1ltTWVQRkVIQE=; b=ObTGafnAOjTwo+o0ID1h5Ovzpmz31/6kV9DZokuukOEZ+KWNrGc9spBH8RNsG6/K26ooaNERgfmZyWhLAb1LkuxirozM3dRUZsJj2SDDqDh2c0JTeXy9uW3rP90nOuLVTyUylJh1LjUGsdRNdbSdgVKAkWgcarBZ0qClMf/eDftuBH8VfpJhBfPc1mFiW/2zOwSaZ41Ms0TTYdNtxcblwR9cbmoEPaDcGj+iaZqAsSRhVhqjywNUca87rfgLbcKEMJmrnlxbCJT54mSM0mybjvKsw3Hm45dq5E+kmQIWRMPjpy41RO+QPNhB8ARkR4IGnpuRfpHfcezoDjtY1HMX9g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZBXO8YASv3UnScNFPhacz08PrWjKBC1ltTWVQRkVIQE=; b=4P3tQ0XWcM7nCutiJWNyxAZRTFSiPVKW+jh5RluFfYBOcq1XT1dtqY+z5568VrJnqgaaffKb8EjM+Vtwfh6h+ajodIiAtChUXiTSnjLYI2LIJHbur1efTNQ1a2LSRLwz5yy1OXC/sP4JZsWl6bdmSpuBT/LETtXZNhs3/tC44xQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4325.namprd12.prod.outlook.com (2603:10b6:610:a9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 10:20:31 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 10:20:31 +0000 Message-ID: <28756c44-9a6c-4871-ac95-1d8d7041a35a@amd.com> Date: Fri, 17 Nov 2023 10:19:55 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] app/testpmd: fix set Tx offload command Content-Language: en-US To: "lihuisong (C)" , fengchengwen , Aman Singh , Yuying Zhang , Dengdui Huang Cc: dev@dpdk.org, Song Jiale , Zhimin Huang , "Xu, HailinX" References: <20231116172155.951084-1-ferruh.yigit@amd.com> <9016ca9e-8f26-d086-dec5-c02cf358fd93@huawei.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <9016ca9e-8f26-d086-dec5-c02cf358fd93@huawei.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0032.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:14::19) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4325:EE_ X-MS-Office365-Filtering-Correlation-Id: f0327cc2-a089-448d-f282-08dbe756d3ab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6vaDwThiQ65Nm3SBaOeCXObZ+SXxjUbEMRREYTuacTpR4DA86nMnuThQAuzuLMoiE3/Cs2gAdOtDGBJU+f/BP6a4h3VQ4wSwipzdYYtbMzA5oio2X3pZmvr0mD94ibF11fzw/zIB7iRRhgX72F3xG8ZDL5R9P6Tvs9KRUbBKb6KzE1aORNar5pYA4Lc3pCa/2D+p3DK27OtcIEThe9fn0g4lqpGiwzEkeEv7xm9LBY5v7Yzz0i1VsVkQBB9WxaNfvjW9dPbZkZalas6XtuQDVYRYWQldghpfJFa4bTeit7bkkvANwhg537iNu8Htm2JPeL8UwEtnNWPs2urpmDr3+43g61/CWTZOKR6kc9miS8ssOde1QjSlOrBo8Xeq3vQGOvAyPvsdJChBPbgseUV2qjoYpI7zUR9N4BFOaPP6Yj/hgREt1HJvMX+qoXeLboe8d5fhRL/34/ivyvYG+rmAAjvPhbAwTLZl+MCasGd1hHRWLwx2+nTwHEvaiP/t+HDNBE9FTJQYo2wx6zKVTFv+PtZGe19fBpug04OZm6/yksjYTSoHCuORBHGgcfCnGsoIECvmezjS9qSzu1RXWAAMFBLJh4/bDjYPj/aHCaKAPaweQJrqAEvCZivcv5zd05QLri8d2m9ilQzkAf7KhjM7GQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(39860400002)(346002)(366004)(376002)(136003)(396003)(230922051799003)(1800799009)(451199024)(64100799003)(186009)(26005)(38100700002)(31696002)(36756003)(86362001)(110136005)(8936002)(54906003)(66556008)(66946007)(66476007)(316002)(8676002)(4326008)(44832011)(41300700001)(5660300002)(2906002)(4744005)(31686004)(6512007)(53546011)(6506007)(2616005)(478600001)(6486002)(6666004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?KzFiZzQ1VTczakFpRVJ3bGFGNDlsOUVaVGVST1NxTFlWZzZLNnFMSWZBK3dR?= =?utf-8?B?TEVYNWhJd2VaVWx4Vk9rWWp4QzNjYUpVMkVUY0VOanloY1U5QXNwNENWQ3Jh?= =?utf-8?B?ZGFtYm9qYmQ5bXBoQkszMGkra1N5YlhVWXhmd21QeFBUNTZpYkFwWEVadVdR?= =?utf-8?B?MUlrcFFwWTRMUjdiYm1rSHMxbE1tN0JMbzBQQVBUUzdjd0pRUW9MajQxMlBi?= =?utf-8?B?YVVQVlkyZEI0NUJXbStmOStHNVNEalF5TUNWMjVDU2Qxc3ZiWGlGV3lSOGg3?= =?utf-8?B?UXJOYUJuTDNXRUU5V21zZGJXdmdRRjVqQlYvZW4rY2RzaFdqYWVTUEMvR3Bz?= =?utf-8?B?d1ZGNDA1UExyZmc2djdIVlhGdWVmR21SODNRY0dHYms5c3lodzB3TzV3bGlZ?= =?utf-8?B?TElZbVlCbkJWRGxEUXJSWUVXZUhCMXNCK3JzQW9GQVFsd2ZoaXRQcU1kWmg2?= =?utf-8?B?TjhMOURVZ3dDNktabWJZbzNISUltRlFyT0Z4Rm1qUDd4Wk5aeDZqaGZsWklx?= =?utf-8?B?THdWcUhmd3BCKzhlMk5xME4yeGRjSUpiOFF5RnE1RG0yZUhpSzdsSTc0RllL?= =?utf-8?B?RWo4UCsxWFAza3NJREJPWkRCZXgrdVZkY0p4VkZyUGVsbXZNVi9KSlVVTGRQ?= =?utf-8?B?OW9scFRyNHo5MHBKSEUxRGZjYzdvQlRoOEFURTkvSXVWZW9QZ1JQZEJDb0xV?= =?utf-8?B?cjJCM1JTWUhVL1JoVm9oRWNHWVlqOVpFWCtZUkZBS3JRKzZRc3pjbVAxQ29V?= =?utf-8?B?d3FjUGhiNmJpR0daRlBQaExWWlN0b0V1eXo5SnZQZDZ4OUtQN2puSHFlS3Vs?= =?utf-8?B?Wk94NjNpY05jQ3N1Q2lBaXRLbk9WSC85VEV2dXBlTGQwTnFneTUzeWd0dlBD?= =?utf-8?B?UTZGNkgyei9kcTIrcy9BQXRucTN4M0s2b01UQ0pHY0s2VWs2NnZHdE8yc1Bj?= =?utf-8?B?OWU3SFJOMzNsYUZ1ZWgwb1BtZmJaRzhoVFQyekY0cGN2K0pqOFhVOEY5QjMw?= =?utf-8?B?b1lROStDbmJpZUhEM2VVODR0Z3NOTmswOEREWlREWGRsdlVJSlgvM2NsWmhS?= =?utf-8?B?MGttSjViV1VWU2MrNm5vQU10NjZHNlZhd1lrS0Zkd3g0OXliZFJlVXJTOVdk?= =?utf-8?B?QTZjL3ZUU0JJWFlWa1NYbGV0MU5tSHc1UHpYejB0cXdJNmkwM2ptUjI2Q053?= =?utf-8?B?L01ibHB6V0Ryei85OXprQS9oWXJhdEFvSm5rOXQvZWZTekY2YUduVENjMFVk?= =?utf-8?B?NlRjM0xJd3BobjRYUlR0RUJ2Qk9PTzRLa21Na2RyL00yS2k2ellYMmU4QnQx?= =?utf-8?B?QnEycjZCTjlLMWRmL2tVU200K05CZmxOaDROTHFoRUcrUVc0b2xLTDRzQU9F?= =?utf-8?B?SDRHVy9LeVpWZzJBSFAvc3JLSDBzenkzNlBxaWprU2hvS2JVdjNhVGFjQjR3?= =?utf-8?B?YmFYREhjTS8rWEQvRjVNM0hERitSeDdCQnFaOExySkR0azJzUHhFZ3ZsL1Zm?= =?utf-8?B?SDJLeGl1cmxWdFhxUjd6dmJNeXlOVExibTYwaHdxbi9vZ1pXQm8vSElQUGJF?= =?utf-8?B?L2x6Y1M2QllTN3BHUm1ONWtwWVFaN1hNMjl2ZUR1OTZaUmRlUVNmU1VGM0x6?= =?utf-8?B?Q1VBY2t4UWV3ZnA2Y3plVzNwNFh2YmN1L2lUZ1JoYWdwdExxK3hHSWxLZ0Er?= =?utf-8?B?UXJPSkJhbWtOOFZPeVV2WW5EQmRqRmVoNzVvM3Y2LzhTZEYzY1h1aWgvNW5M?= =?utf-8?B?Skwrc0VQK1pxV1M0NVVybUIrUWVVNmFYbUJBUjNhYmJuMmFYMTZVYnY4Rjkw?= =?utf-8?B?RFc0ZW1mZVp3SVJQc290aUJBYWcvN0RRY0hXQ2cyQWVJYWx6UFZPeG90Z1Fr?= =?utf-8?B?NURGMjdMNnhUdTEzdVRyTzJBMzFveHhEZTRWT3BleGJDK0VTK2M1R3B6cStm?= =?utf-8?B?bXZ0VTVKMkJHY21xazBqVmRFMU16amNyZURINVBBU04yallzY3JYTHFUbG1L?= =?utf-8?B?azQwbzRZeGMwWXJ4OWRmR2RrQk1oT1dwVVpLSDhlbTd4Z1M2V0lTMkhXbVpk?= =?utf-8?B?NzIwN0xwbFBkMTdzelNOUjdJR29uR00zTlhkVDJ0UFFxVjE0VmpmUzNRYkVV?= =?utf-8?Q?+E1A=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0327cc2-a089-448d-f282-08dbe756d3ab X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 10:20:31.0128 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: IJEAWG6wga3Olh9136sgxBp6mewy5zPIlxnMXyzfqx0xWclGofnLu/HbJVtPiYTT X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4325 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2023 1:31 AM, lihuisong (C) wrote: >> On 2023/11/17 1:21, Ferruh Yigit wrote: >>> In command to set Tx offload: >>> "port config tx_offload on|off", >>> >>> there is a defect in "on|off" comparison, so command does opposite of >>> what is intended. Fixed comparison. >>> >>> Fixes: 6280fe565b44 ("app/testpmd: allow offload config for all ports") >>> >>> Signed-off-by: Ferruh Yigit >> >> Reviewed-by: Chengwen Feng >> > > Acked-by: Huisong Li > Bugzilla ID: 1326 Applied to dpdk-next-net/main, thanks.