From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 756EFA0524; Tue, 25 Feb 2020 10:47:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 50A481BC24; Tue, 25 Feb 2020 10:47:41 +0100 (CET) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id 4BC62B62 for ; Tue, 25 Feb 2020 10:47:40 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id CAB3C440; Tue, 25 Feb 2020 04:47:38 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 25 Feb 2020 04:47:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=9pkVUzU5HqVEkz1hwHpONzdV3HKesmN9tr73EC5kKkA=; b=Rv4JExb6Ip3j b2BuxtSKCIYRnjrTHznrOMv6z+8HUs96nSl1TPy0A9osgy0Za1UA2Si4/htabgWI Ixz9jFHTYt5jsYwTBvlwoRPRS7UDwEkIHhdorWsW1Uh7QnjfFqlKWsAfX8zu28fc jJgVwEBdQkDEDj0o031x5z8zkgChofs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=9pkVUzU5HqVEkz1hwHpONzdV3HKesmN9tr73EC5kK kA=; b=xwQtVKMK0OuVs+EbEFjvUsW/q1bH9R3IO8U99usPOQY0evG0DmOu567+4 BKSmu8bHfnDS79+nY7A2Oe1XH0/KQOHHQQU3AoTcvcgYVnAZhyyj39Fs7BZovN+J nO+xa0eAOrdcaGKFVOGYqS8oq16YQyWYRN4dhU39WdrUjwAclU7/Hz8y580Joxua QmyFFrXUfNmyBalnMnpIuwd6PtA4DbysoCY+3kjWJdeQ2Bno7uJzRhKLi5MnvQtI yWxDYs6wOsxGiY1VPVg9z2bGk6UKdUfW2gaKPcgwDD3DKlC/4g0qukxzIXWCL095 3gAysloJANhkJs5/FZwGXY+2xDBnQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrledvgddtjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgepudenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CE1CC328005E; Tue, 25 Feb 2020 04:47:37 -0500 (EST) From: Thomas Monjalon To: Matan Azrad Cc: dev@dpdk.org, Viacheslav Ovsiienko , Maxime Coquelin Date: Tue, 25 Feb 2020 10:47:36 +0100 Message-ID: <2878574.U3zVgo479M@xps> In-Reply-To: <1582563307-24184-1-git-send-email-matan@mellanox.com> References: <1582563307-24184-1-git-send-email-matan@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 1/2] vdpa/mlx5: fix guest notification timing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 24/02/2020 17:55, Matan Azrad: > When the HW finishes to consume the guest Rx descriptors, it creates a > CQE in the CQ. > > The mlx5 driver arms the CQ to get notifications when a specific CQE > index is created - the index to be armed is the next CQE index which > should be polled by the driver. > > The mlx5 driver configured the kernel driver to send notification to the > guest callfd in the same time it arrives to the mlx5 driver. > > It means that the guest was notified only for each first CQE in a poll > cycle, so if the driver polled CQEs of all the virtio queue available > descriptors, the guest was not notified again for the rest because > there was no any new cycle for polling. > > Hence, the Rx queues might be stuck when the guest didn't work with > poll mode. > > Move the guest notification to be after the driver consumes all the > SW own CQEs. > By this way, guest will be notified only after all the SW CQEs are > polled. > > Also init the CQ to be with HW owner in the start. > > Fixes: 8395927cdfaf ("vdpa/mlx5: prepare HW queues") > > Signed-off-by: Matan Azrad Applied, thanks Note: there is no regression risk because it is fixing a new driver.