From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 63D4D1B394 for ; Fri, 5 Apr 2019 01:24:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B40E323FF3; Thu, 4 Apr 2019 19:24:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 19:24:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vwwTS83taQ6CqB6CZFsKkdMszi60Qez78SdyUeE5bsU=; b=hTtd20KY4TT3 3hvGxscdGHp7EtQF2WG4YlkO9hL+Gv+JvMmFOKuNRIq/2Hph2ErYWhyt665a25NF a0qMjBqcUA+UdE/+s9f2WmgbOO7mCE+xVkeiG8drGT34CKykbsJWMP2xMzfKneml XYMXiTRXfiLONTimF24MZ9VaS6l6P5w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vwwTS83taQ6CqB6CZFsKkdMszi60Qez78SdyUeE5b sU=; b=jc8nKwmpMR2LEPNU9TPzYldsi1++jsd2mHiCJLTYtEE7u4QUVPitKbGni /AZ82wJLT5f2MV9VZFFPcEOifwNjTtd8zvBU8LF4aVkNVF70BYrKKGDdIDN7Ck6C ufKcWQJ+Ts51CR+I5uzUjiQ3a9GajLCkQspuj2EBzBxlhj0Zo+ZJuiKVmXYTeTx2 KdCOlcNxazs0oobHR7PJEC4QVr4Xfs0hKKTsY/gud2M18ZOz+boVOEDOXo5sRCbM DuIO4yqGDWAwd1fUdI9GlGkT7LWhdcfLXY5VsojGV5rKCOvxguLHvd3geXSOHqxe ri7xwOU9lFu9VJ/4ngf1ozf/FVpnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdeigdduleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CE4BF10319; Thu, 4 Apr 2019 19:24:53 -0400 (EDT) From: Thomas Monjalon To: Phil Yang Cc: dev@dpdk.org, david.hunt@intel.com, reshma.pattan@intel.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com Date: Fri, 05 Apr 2019 01:24:52 +0200 Message-ID: <28787746.rR50tbZ9jN@xps> In-Reply-To: <1554274796-23258-2-git-send-email-phil.yang@arm.com> References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1554274796-23258-1-git-send-email-phil.yang@arm.com> <1554274796-23258-2-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Apr 2019 23:24:57 -0000 Hi, 03/04/2019 08:59, Phil Yang: > The current implementation using the '__sync' built-ins to synchronize > statistics within worker threads. The '__sync' built-ins functions are > full barriers which will affect the performance, so add a per worker > packets statistics to remove the synchronisation between worker threads. > > Since the maximum core number can get to 256, so disable the per core > stats print in default and add the --insight-worker option to enable it. [...] > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu There is an error with clang: examples/packet_ordering/main.c:82:57: error: suggest braces around initialization of subobject static struct wkr_stats_per wkr_stats[RTE_MAX_LCORE] = {0}; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3E039A0679 for ; Fri, 5 Apr 2019 01:25:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C47071B398; Fri, 5 Apr 2019 01:24:58 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 63D4D1B394 for ; Fri, 5 Apr 2019 01:24:57 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id B40E323FF3; Thu, 4 Apr 2019 19:24:55 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 19:24:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=vwwTS83taQ6CqB6CZFsKkdMszi60Qez78SdyUeE5bsU=; b=hTtd20KY4TT3 3hvGxscdGHp7EtQF2WG4YlkO9hL+Gv+JvMmFOKuNRIq/2Hph2ErYWhyt665a25NF a0qMjBqcUA+UdE/+s9f2WmgbOO7mCE+xVkeiG8drGT34CKykbsJWMP2xMzfKneml XYMXiTRXfiLONTimF24MZ9VaS6l6P5w= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=vwwTS83taQ6CqB6CZFsKkdMszi60Qez78SdyUeE5b sU=; b=jc8nKwmpMR2LEPNU9TPzYldsi1++jsd2mHiCJLTYtEE7u4QUVPitKbGni /AZ82wJLT5f2MV9VZFFPcEOifwNjTtd8zvBU8LF4aVkNVF70BYrKKGDdIDN7Ck6C ufKcWQJ+Ts51CR+I5uzUjiQ3a9GajLCkQspuj2EBzBxlhj0Zo+ZJuiKVmXYTeTx2 KdCOlcNxazs0oobHR7PJEC4QVr4Xfs0hKKTsY/gud2M18ZOz+boVOEDOXo5sRCbM DuIO4yqGDWAwd1fUdI9GlGkT7LWhdcfLXY5VsojGV5rKCOvxguLHvd3geXSOHqxe ri7xwOU9lFu9VJ/4ngf1ozf/FVpnA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdeigdduleculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvden ucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrg hlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhep mhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsth gvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CE4BF10319; Thu, 4 Apr 2019 19:24:53 -0400 (EDT) From: Thomas Monjalon To: Phil Yang Cc: dev@dpdk.org, david.hunt@intel.com, reshma.pattan@intel.com, gavin.hu@arm.com, honnappa.nagarahalli@arm.com, nd@arm.com Date: Fri, 05 Apr 2019 01:24:52 +0200 Message-ID: <28787746.rR50tbZ9jN@xps> In-Reply-To: <1554274796-23258-2-git-send-email-phil.yang@arm.com> References: <1546508946-12552-1-git-send-email-phil.yang@arm.com> <1554274796-23258-1-git-send-email-phil.yang@arm.com> <1554274796-23258-2-git-send-email-phil.yang@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] packet_ordering: add statistics for each worker thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190404232452.sW7tgTwiOKcg11x9GKgMl4HDe6IttKo3qmaeMNE5AKQ@z> Hi, 03/04/2019 08:59, Phil Yang: > The current implementation using the '__sync' built-ins to synchronize > statistics within worker threads. The '__sync' built-ins functions are > full barriers which will affect the performance, so add a per worker > packets statistics to remove the synchronisation between worker threads. > > Since the maximum core number can get to 256, so disable the per core > stats print in default and add the --insight-worker option to enable it. [...] > Suggested-by: Honnappa Nagarahalli > Signed-off-by: Phil Yang > Reviewed-by: Gavin Hu There is an error with clang: examples/packet_ordering/main.c:82:57: error: suggest braces around initialization of subobject static struct wkr_stats_per wkr_stats[RTE_MAX_LCORE] = {0};