Re: [dpdk-dev] [PATCH] vhost: remove copy threshold for async vhost

[Maxime Coquelin <maxime.coquelin@redhat.com>]

Hi Jiayu,

Thanks for working on it!

On 8/20/21 2:44 PM, Jiayu Hu wrote:
> Copy threshold is introduced in async vhost data path to select
> the appropriate copy engine to do copies for higher efficiency.
> However, it may cause packets out-of-order, and it also causes
> data path performance unpredictable.
> 
> Therefore, this patch removes copy threshold support in async vhost
> data path.
> 
> Signed-off-by: Jiayu Hu <jiayu.hu@intel.com>
> Signed-off-by: Cheng Jiang <cheng1.jiang@intel.com>
> ---
>  doc/guides/prog_guide/vhost_lib.rst |   7 -
>  examples/vhost/main.c               |  22 +-
>  lib/vhost/rte_vhost_async.h         |  22 +-
>  lib/vhost/vhost.c                   |   6 +-
>  lib/vhost/vhost.h                   |   1 -
>  lib/vhost/virtio_net.c              | 439 +++++++++---------------------------
>  6 files changed, 116 insertions(+), 381 deletions(-)
> 

It looks good to me, and simplifies the code a lot.

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime