From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id 2C102A499 for ; Mon, 2 Apr 2018 18:51:21 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C167C20B9D; Mon, 2 Apr 2018 12:51:20 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 02 Apr 2018 12:51:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=/SyV1+mhSwknChUDJFkyZB7yoa PGZFiP8mn9xXDcVzs=; b=dpOKRbJof8vblDbpdbg99Ke7yr0cdxTabZEfqYPAQF Ua2e0mRLVw/jEFl51XRKQm2Gf+B4u2keMS1R4FHHPFMHT5bgvSuYm5JfUymJe6rG 5UokRKvL49Fun5GZNozDpXPvzE8qzYfyEf51iMIHayZ2fSjA6JNpSEJ4mm2kz/Iz Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/SyV1+ mhSwknChUDJFkyZB7yoaPGZFiP8mn9xXDcVzs=; b=YMevN2v+KXMjvyMx4LDmxz C2eMJP9ypgTpC2xyd9xsHIMRTUZy6TpTSxNmUj2FIQU0kKHdVstSAWo88ke6B3bf EFUhfCuwVlwO02gQSUeYGjARvRaQNzF4ZS2ND5oTahHCeyWh75Rlin05VrMXVL0s Wo3KYrqPw1ARVrgs9ZVJf9aL3vTyXsKJgHJOIwgnebB9h8piXZ3ZsSNAIHhF1Wp5 4DfeT5Tl0z85jO1OPSgkxAeJjOFV070ir5hr+SczHr8PVV48SZUyT1iRA9CZNF90 mQ0t9Efxb5jR6Yt7yNsO3xOCRC4QhL/DoQm/pQu/bcnelfLVlE+6Wijoj0kM4V2w == X-ME-Sender: Received: from xps.localnet (182.19.136.77.rev.sfr.net [77.136.19.182]) by mail.messagingengine.com (Postfix) with ESMTPA id 0367DE50BC; Mon, 2 Apr 2018 12:51:18 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, Ferruh Yigit , Solal Pirelli , solal.pirelli@gmail.com Date: Mon, 02 Apr 2018 18:50:12 +0200 Message-ID: <2880455.xF8ZZNx2Pu@xps> In-Reply-To: <20180402120619.30404-1-nhorman@tuxdriver.com> References: <20180402120619.30404-1-nhorman@tuxdriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] linuxapp eal: set fd to -1 for MAP_ANONYMOUS cases X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 16:51:21 -0000 02/04/2018 14:06, Neil Horman: > https://dpdk.org/tracker/show_bug.cgi?id=18 I really appreciate reading such bug request. Maybe we should add a Suggested-by line Suggested-by: Solal Pirelli before the SoB line (chronological order). > Indicated that several mmap call sites in the linuxapp eal code used an > fd that was not -1 in their calls while using MAP_ANONYMOUS. While > probably not a huge deal, the man page does say the fd should be -1 for > portability, as some implementations don't ignore fd as they should for > MAP_ANONYMOUS, and seting -1 here allows us to eliminate some code. > > Signed-off-by: Neil Horman > CC: Thomas Monjalon > CC: Ferruh Yigit