From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A3C0A0567; Sun, 26 Jun 2022 23:16:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3FBF41141; Sun, 26 Jun 2022 23:16:19 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mails.dpdk.org (Postfix) with ESMTP id 1DFD240E50 for ; Sun, 26 Jun 2022 23:16:18 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 4D69D5C00E9; Sun, 26 Jun 2022 17:16:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sun, 26 Jun 2022 17:16:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656278177; x= 1656364577; bh=2d0PjqcI4R6vC6fRQwMwCCIjdRLSDYJu+BxJd6CCXyY=; b=B y17SKRInvVZ5s7nmY+o4mlbVW08f3YwBlTB9OkuErZh5y01IDR5e4A0dbak6f+wE /Yhe7Eu2+uIzDxT1HG9K6s6CW9BzJzmqr7pPBUjLDaWN06AaepVckOehfIOaMQe6 Bjeb1pXu8KZKkZi6mI/KUJj+vvvMnnr1onQ/EL/+0eM5+wQstgDLrpeFrUfNPeQD ddi1tygB32gazvJg8582KnuEg63/f7m9Vcx4+hMaRAMlpYd9EAPz12uF6wr4ELDn 9/XY7dEXHvRa8nmZCC/ER3ZYOq5SjBL9WLKunfxEwr3R++fm+XqLf7TEPUOZEgbD hpjcS8jSubu9WlPeY5VSA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656278177; x= 1656364577; bh=2d0PjqcI4R6vC6fRQwMwCCIjdRLSDYJu+BxJd6CCXyY=; b=e iknrt4za2N5330VPeddInAf8+xi0aHr/+WuZ540zsjNDEUR/UhyQmP9BS5KPiaHw IhO7jMC1NLQQIM3i5Qd+cwSXxOV2nsx4HBTbtjFbppXKDQd+PgWFi4nHa+XPjkXl 2D4u00jYpKukOclMZFLfEf5y2DchGu2UmS6/1aQ4bEmNNvEKZ8Q/gAWc32gDPIIx R+u9MFXcACZov1bYK9Qu8dXfJWqy5UN55j96OSBps15g+gje2jEiUdwRqwFTzuAg jLQSUA8NhHLt9xEAIR30y+7jlMn3/o4E4etxldsus8vqCLj0nIpc8mokeTSk+oOW NmOFuzRs5Y9kLIIlHIo8g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgudeitdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhho mhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqne cuggftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddt ieekgfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 17:16:16 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: Usman Tanveer , Huisong Li , Chengwen Feng , Bruce Richardson , Gargi Sau , Qiming Yang , andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com Subject: Re: [PATCH] ethtool: remove a redundant call to rte_eth_dev_stop() Date: Sun, 26 Jun 2022 23:16:14 +0200 Message-ID: <28911775.czjnFlTdjD@thomas> In-Reply-To: <20220527064244.10224-1-usman.tanveer@emumba.com> References: <20220527064244.10224-1-usman.tanveer@emumba.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 27/05/2022 08:42, Usman Tanveer: > There is a call to rte_eth_dev_stop() in rte_ethtool_net_open() > due to which user gets misleading message upon first open/start call. > It says that the > device is already stopped, which should not be the case. This patch > removes rte_eth_dev_stop() from rte_ethtool_net_open(). Why was it there? Any opinion? Is it safe to remove? > int > rte_ethtool_net_open(uint16_t port_id) > { > - int ret; > - > - ret = rte_eth_dev_stop(port_id); > - if (ret != 0) > - return ret; > - > return rte_eth_dev_start(port_id); > }