From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id F39737D57 for ; Wed, 23 Aug 2017 23:48:07 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4FCF320CE5; Wed, 23 Aug 2017 17:48:07 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 23 Aug 2017 17:48:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=Dsp+3PBtazeI0sB V/1jAkyxMaDLxGr4xstbp0G6gsIM=; b=HFl2nRdHVTItYWN3mCMrHogVVObPaDc DEFNJaYVsq6lxmJoR5TUJomUysW8s82LgwV5YBUG69ysKXm9ViSoo1GcIrKZjprH CRcThXeS61aVMERqUDTPWqr/Qk4g9AA59MA0PQyu3dPUpsQ7Oz/3KkeiSpxKiCTL LL9y3VSiCqt0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=Dsp+3PBtazeI0sBV/1jAkyxMaDLxGr4xstbp0G6gsIM=; b=nywBh3g1 7+u/w3hZuBYV+/77PJ+yw52dW13pqUhQp0iKCoynboRXFXxpDlyf8b9rikVBtBlx KZFQ99bWOCYEEPTLXSe34Bu8gVBCZRyStNJfB20CIkErMEQ+2FDgV5WLhDpZEDag C5S3WsMYOKeoYU09RqidmCLts4ZuarGxlZvH1pHhQPIba4WHRj583cAQurAJXilK jrGndx0hO/jV3woX4qN+7utI+ytUzG5fUUJtJH5fRSoMwFc9OHS7FTZzkhV5YiTp 3ITI7ceYY5F+ywa2ehO6kX+5G3bp/2b5w67k+YuhYLC9Ppdc6qgr9zAioztWEADj kC6yMJoE38Lxiw== X-ME-Sender: X-Sasl-enc: +5mTup+RKFvWUjMZt5AAgKyfs8Grh94psgLrJaDRdSiq 1503524887 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0599424871; Wed, 23 Aug 2017 17:48:07 -0400 (EDT) From: Thomas Monjalon To: Shahaf Shuler Cc: dev@dpdk.org Date: Wed, 23 Aug 2017 23:48:06 +0200 Message-ID: <2894761.WIdkp7yuM2@xps> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [RFC PATCH 2/4] ethdev: introduce Rx queue offloads API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Aug 2017 21:48:08 -0000 07/08/2017 12:54, Shahaf Shuler: > Introduce a new API to configure Rx offloads. > > The new API will re-use existing DEV_RX_OFFLOAD_* flags > to enable the different offloads. This will ease the process > of adding a new Rx offloads, as no ABI breakage is involved. > In addition, the offload configuration can be done per queue, > instead of per port. > > The Rx queue offload API can be used only with devices which advertize > the RTE_ETH_DEV_RXQ_OFFLOAD capability. > > The old Rx offloads API is kept for the meanwhile, in order to enable a > smooth transition for PMDs and application to the new API. > > Signed-off-by: Shahaf Shuler [...] > --- a/lib/librte_ether/rte_ethdev.h > +++ b/lib/librte_ether/rte_ethdev.h > @@ -357,7 +357,14 @@ struct rte_eth_rxmode { > jumbo_frame : 1, /**< Jumbo Frame Receipt enable. */ > hw_strip_crc : 1, /**< Enable CRC stripping by hardware. */ > enable_scatter : 1, /**< Enable scatter packets rx handler */ > - enable_lro : 1; /**< Enable LRO */ > + enable_lro : 1, /**< Enable LRO */ > + ignore : 1; > + /** > + * When set the rxmode offloads should be ignored, > + * instead the Rx offloads will be set on rte_eth_rxq_conf. > + * This bit is temporary till rxmode Rx offloads API will > + * be deprecated. > + */ Who is responsible to set the "ignore" flag? Should it be documented in queue config functions? > +/** Device supports the rte_eth_rxq_conf offloads API */ > +#define RTE_ETH_DEV_RXQ_OFFLOAD 0x0010 Otherwise, looks good