[dpdk-dev] [PATCH] examples/kni: Fix segmentation fault at program exit

[dpdk-dev] [PATCH] examples/kni: Fix segmentation fault at program exit

[Hyun Yoo]

In kni_free_kni(), p[i] should be p[port_id]

Signed-off-by: Hyun Yoo <easetheworld <at> gmail.com>
---
 examples/kni/main.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/examples/kni/main.c b/examples/kni/main.c
index 6f74d8e..6d434ad 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -830,9 +830,9 @@ kni_free_kni(uint8_t port_id)
 	if (port_id >= RTE_MAX_ETHPORTS || !p[port_id])
 		return -1;
 
-	for (i = 0; i < p[i]->nb_kni; i++) {
-		rte_kni_release(p[i]->kni[i]);
-		p[i]->kni[i] = NULL;
+	for (i = 0; i < p[port_id]->nb_kni; i++) {
+		rte_kni_release(p[port_id]->kni[i]);
+		p[port_id]->kni[i] = NULL;
 	}
 	rte_eth_dev_stop(port_id);
 
-- 
1.9.1

Re: [dpdk-dev] [PATCH] examples/kni: Fix segmentation fault at program exit

[Zhang, Helin]

> -----Original Message-----
> From: Hyun Yoo [mailto:easetheworld@gmail.com]
> Sent: Wednesday, August 5, 2015 2:58 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org
> Subject: [PATCH] examples/kni: Fix segmentation fault at program exit
> 
> In kni_free_kni(), p[i] should be p[port_id]
> 
> Signed-off-by: Hyun Yoo <easetheworld@gmail.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

Re: [dpdk-dev] [PATCH] examples/kni: Fix segmentation fault at program exit

[Thomas Monjalon]

> > In kni_free_kni(), p[i] should be p[port_id]
> > 
> > Signed-off-by: Hyun Yoo <easetheworld@gmail.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied, thanks