From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AD6FCA04E7; Tue, 3 Nov 2020 21:46:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0A6E0697C; Tue, 3 Nov 2020 21:46:11 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id E054F6947; Tue, 3 Nov 2020 21:46:08 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 7A8925C01A0; Tue, 3 Nov 2020 15:46:07 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 15:46:07 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= u1+PWR4pgteHXQ6SEo05wjdZlDkRzF+RWGD8AYS3Zo4=; b=njXBhQ7Q8sQcgcEX q7GZcKqGErMK+jKFO7ONU7uQ1BKwk5IPPv+EAZgvlTUPhgyRQX8Mmrjck+20UoY4 MECO1X6ckDSIDeYjbov2RGgN1FLcPypOXv3hg6WB4qJMc/P3yRS9og027uiAefTA diADQblJLsiZCU2vBrOL8yhGfO2ZhrMfQ2HoY10KqFawTLwPSzhwDJ0NU1TWZ4gt rQOVC/SYSgZCRce7/QMDZsmoYI4FD80LW/UMVPsJiCXStmKPdXl/IbHsZnicLS5D A/acE408/TFiOyjQTHRviDJWKhnVHlkkyBySxGZXVY9Pj8I/CSZUGA+I0cK2+VFA falWpQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=u1+PWR4pgteHXQ6SEo05wjdZlDkRzF+RWGD8AYS3Z o4=; b=Oc1M81plNlNM4a4Ft2txr249tJV/+Ah9ucoDwswE3TrXj1zinkpyPYCoi 47gwCvyB9Iq2TpBK9nB0IQnJYj/mi4rWwSXVQk7NNpGyE7/K/3Tq9pS+xTndoN5h +J25PobVTyVxmFHxj5VTjrzpcetaq5N9iXiFuWZtzIvtisS7tYQfzkcYOJl+DrUQ ghBHCGWqLBcd136DK3EJHWV1b8SFyVevnKDgQSx1cGCo7vxN7pRA2UHaanXm9P+9 v/EwBhzW128cfdmVR+L77EOlj2uRxXZoj13+9X6pihKkY7cJoDWicyYy3HYpCM4i Z7uyzTuQWxq0+uxAT3WMdsfYtig4Q== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgudegtdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 55967306467E; Tue, 3 Nov 2020 15:46:06 -0500 (EST) From: Thomas Monjalon To: David Hunt Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com Date: Tue, 03 Nov 2020 21:46:05 +0100 Message-ID: <2897228.yid56MYTPc@thomas> In-Reply-To: <20201027132413.23116-1-david.hunt@intel.com> References: <20201027125227.21946-1-david.hunt@intel.com> <20201027132413.23116-1-david.hunt@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] lib/power: remove set env deprecation notice X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2020 14:24, David Hunt: > Remove notice announcing an already-implemented change. > > In 19.05, rte_power_set_env was changed to return -1 in cases where > the envorinment was already set up, and for the same release, a > deprecation notice was added for the following commit: > 'commit 5a5f3178d4a8 ("power: return error when environment already set")' > This patch removes that notice. > > The API change was tested by calling rte_power_set_env twice. The first > call succeeded, and the second call failed, as expected. > > Signed-off-by: David Hunt > > --- > > v1 initial version (with typo in the title) > v2 fix typo but forgot --in-reply-to > v3 add -in-reply-to > v4 add in version info, and cc stable in case it needs to be backported > > Note: CC'ing stable in case the deprecation notice should also be removed > from 19.11. It looks to me like the patch making the change and the patch > adding the notice were both added in 19.11, so the notice is no longer > needed in that verion. I didn't add a Fixes line to this patch as I believe > the notice was correct, just adding both fix and notice in the same version > was not strictly the right thing to have done at the time. The Fixes: line must reference the commit which did the API change without removing the notice. Cc: stable@dpdk.org must be below the Fixes line.