From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <david.hunt@intel.com> Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 215CE4CA7 for <dev@dpdk.org>; Mon, 1 Apr 2019 17:49:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 08:49:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="157716798" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.210.26]) ([10.237.210.26]) by fmsmga004.fm.intel.com with ESMTP; 01 Apr 2019 08:49:21 -0700 To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org Cc: liang.j.ma@intel.com References: <20190329131520.10653-1-david.hunt@intel.com> <20190401153044.39273-1-david.hunt@intel.com> <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com> From: "Hunt, David" <david.hunt@intel.com> Message-ID: <28b75883-2dd5-bd9d-69bb-cbc7d263a182@intel.com> Date: Mon, 1 Apr 2019 16:49:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for high frequency cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Mon, 01 Apr 2019 15:49:23 -0000 Hi Anatoly, On 1/4/2019 4:43 PM, Burakov, Anatoly wrote: > On 01-Apr-19 4:30 PM, David Hunt wrote: >> This patch adds a new bit in the capabilities mask that's returned by >> rte_power_get_capabilities(), allowing application to query which cores >> have the higher frequencies, and can then pin the workloads accordingly. >> >> Returned Bits: >> 0 - Turbo Boost enabled >> 1 - Higher core base_frequency >> >> Signed-off-by: David Hunt <david.hunt@intel.com> >> --- > > <snip> > >> /* Add MSR read to detect turbo status */ >> if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) >> < 0) >> @@ -179,6 +207,14 @@ power_init_for_setting_freq(struct >> pstate_power_info *pi) >> pi->non_turbo_max_ratio = max_non_turbo; >> + /*Add the compare for base frequency */ > > The comment here looks meaningless, and needs to be reworded to > explain why this is done, not what is done. > > Otherwise, > > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com> > OK, Thanks for that. I'll push a v5 shortly, including your Reviewed-by tag. Rgds, Dave. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2ED47A0679 for <public@inbox.dpdk.org>; Mon, 1 Apr 2019 17:49:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 063444CAF; Mon, 1 Apr 2019 17:49:25 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 215CE4CA7 for <dev@dpdk.org>; Mon, 1 Apr 2019 17:49:22 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Apr 2019 08:49:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,297,1549958400"; d="scan'208";a="157716798" Received: from dhunt5-mobl2.ger.corp.intel.com (HELO [10.237.210.26]) ([10.237.210.26]) by fmsmga004.fm.intel.com with ESMTP; 01 Apr 2019 08:49:21 -0700 To: "Burakov, Anatoly" <anatoly.burakov@intel.com>, dev@dpdk.org Cc: liang.j.ma@intel.com References: <20190329131520.10653-1-david.hunt@intel.com> <20190401153044.39273-1-david.hunt@intel.com> <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com> From: "Hunt, David" <david.hunt@intel.com> Message-ID: <28b75883-2dd5-bd9d-69bb-cbc7d263a182@intel.com> Date: Mon, 1 Apr 2019 16:49:20 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <9b50355f-06ab-fb44-5aa6-1089fd7e64d6@intel.com> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v4 1/2] lib/power: add bit for high frequency cores X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190401154920.FgHpy8HDx-WX4kM8WyNQWQssu9u1EHAissEimIfYHlw@z> Hi Anatoly, On 1/4/2019 4:43 PM, Burakov, Anatoly wrote: > On 01-Apr-19 4:30 PM, David Hunt wrote: >> This patch adds a new bit in the capabilities mask that's returned by >> rte_power_get_capabilities(), allowing application to query which cores >> have the higher frequencies, and can then pin the workloads accordingly. >> >> Returned Bits: >> 0 - Turbo Boost enabled >> 1 - Higher core base_frequency >> >> Signed-off-by: David Hunt <david.hunt@intel.com> >> --- > > <snip> > >> /* Add MSR read to detect turbo status */ >> if (power_rdmsr(PLATFORM_INFO, &max_non_turbo, pi->lcore_id) >> < 0) >> @@ -179,6 +207,14 @@ power_init_for_setting_freq(struct >> pstate_power_info *pi) >> pi->non_turbo_max_ratio = max_non_turbo; >> + /*Add the compare for base frequency */ > > The comment here looks meaningless, and needs to be reworded to > explain why this is done, not what is done. > > Otherwise, > > Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com> > OK, Thanks for that. I'll push a v5 shortly, including your Reviewed-by tag. Rgds, Dave.