[dpdk-dev] [PATCH] usertools: enhance device bind script module detection

[dpdk-dev] [PATCH] usertools: enhance device bind script module detection

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Some kernel modules have '-' in their name when populated in
'/sys/bus/pci/drivers/' where as the kernel always populates
'/sys/modules/' with '_'.
Replace '-' in module name with '_' to avoid script complaining
that module not loaded.

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 usertools/dpdk-devbind.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 7b5cbc12c..b1d149876 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -153,6 +153,9 @@ def check_output(args, stderr=None):
 def module_is_loaded(module):
     global loaded_modules
 
+    if module == 'vfio_pci':
+        module = 'vfio-pci'
+
     if loaded_modules:
         return module in loaded_modules
 
@@ -520,7 +523,7 @@ def bind_all(dev_list, driver, force=False):
         pass
 
     # check if we're attempting to bind to a driver that isn't loaded
-    if not module_is_loaded(driver):
+    if not module_is_loaded(driver.replace('-','_')):
         sys.exit("Error: Driver '%s' is not loaded." % driver)
 
     try:
-- 
2.17.1

Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection

[Thomas Monjalon]

21/09/2019 20:16, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Some kernel modules have '-' in their name when populated in
> '/sys/bus/pci/drivers/' where as the kernel always populates
> '/sys/modules/' with '_'.
> Replace '-' in module name with '_' to avoid script complaining
> that module not loaded.

Sorry it does not look obvious to me.
Please, could you describe what is wrong and what is the real cause?

[dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection

[pbhagavatula]

From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Some kernel modules use '-' in their name when registering through
`pci_register_driver` and the same name  is populated in
'/sys/bus/pci/drivers/'.
But the kernel always populates modules names replacing '-' with '_'
in '/sys/module/'.

Example:
	# ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0
	Error: Driver 'octeontx2-nicpf' is not loaded.

	# ls /sys/bus/pci/drivers/octeontx2-nicpf
	bind  module  new_id  remove_id  uevent  unbind
	# ls /sys/module/octeontx2_nicpf/
	drivers  uevent  version

The patch addresses it by always replacing '-' with '_' when looking in
'/sys/module/'

Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 usertools/dpdk-devbind.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 7b5cbc12c..b1d149876 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -153,6 +153,9 @@ def check_output(args, stderr=None):
 def module_is_loaded(module):
     global loaded_modules
 
+    if module == 'vfio_pci':
+        module = 'vfio-pci'
+
     if loaded_modules:
         return module in loaded_modules
 
@@ -520,7 +523,7 @@ def bind_all(dev_list, driver, force=False):
         pass
 
     # check if we're attempting to bind to a driver that isn't loaded
-    if not module_is_loaded(driver):
+    if not module_is_loaded(driver.replace('-','_')):
         sys.exit("Error: Driver '%s' is not loaded." % driver)
 
     try:
-- 
2.17.1

Re: [dpdk-dev] [PATCH v2] usertools: enhance device bind script module detection

[Thomas Monjalon]

02/11/2019 15:23, pbhagavatula@marvell.com:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Some kernel modules use '-' in their name when registering through
> `pci_register_driver` and the same name  is populated in
> '/sys/bus/pci/drivers/'.
> But the kernel always populates modules names replacing '-' with '_'
> in '/sys/module/'.
> 
> Example:
> 	# ./usertools/dpdk-devbind.py -b octeontx2-nicpf 0002:03:00.0
> 	Error: Driver 'octeontx2-nicpf' is not loaded.
> 
> 	# ls /sys/bus/pci/drivers/octeontx2-nicpf
> 	bind  module  new_id  remove_id  uevent  unbind
> 	# ls /sys/module/octeontx2_nicpf/
> 	drivers  uevent  version
> 
> The patch addresses it by always replacing '-' with '_' when looking in
> '/sys/module/'
> 
> Signed-off-by: Phanendra Vukkisala <pvukkisala@marvell.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Applied, thanks for the clear explanation.

Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection

[Thomas Monjalon]

28/10/2019 18:09, Thomas Monjalon:
> 28/10/2019 15:50, Pavan Nikhilesh Bhagavatula:
> > >21/09/2019 20:16, pbhagavatula@marvell.com:
> > >> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > >>
> > >> Some kernel modules have '-' in their name when populated in
> > >> '/sys/bus/pci/drivers/' where as the kernel always populates
> > >> '/sys/modules/' with '_'.
> > >> Replace '-' in module name with '_' to avoid script complaining
> > >> that module not loaded.
> > >
> > >Sorry it does not look obvious to me.
> > >Please, could you describe what is wrong and what is the real cause?
> > >
> > 
> > dpdk-devbind.py can also be used to bind devices to kernel modules.
> > Some kernel modules are registered with '-' in their name and are populated 
> > with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/modules/ as '_'
> 
> Sorry, still not clear.
> What do you mean by "registered"?
> 
> > This confuses the current script making it unable to bind to such modules. The patch 
> > addresses it by always replacing '-' with '_' when looking in /sys/modules/
> 
> Yes this sentence is clear (except it is /sys/module/).
> Please send a v2 with a clear explanation.


Sorry, forgot to insist:
You must start the description with what is wrong.
You can describe the bug you are experiencing.

Thanks

Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection

[Thomas Monjalon]

28/10/2019 15:50, Pavan Nikhilesh Bhagavatula:
> >21/09/2019 20:16, pbhagavatula@marvell.com:
> >> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >>
> >> Some kernel modules have '-' in their name when populated in
> >> '/sys/bus/pci/drivers/' where as the kernel always populates
> >> '/sys/modules/' with '_'.
> >> Replace '-' in module name with '_' to avoid script complaining
> >> that module not loaded.
> >
> >Sorry it does not look obvious to me.
> >Please, could you describe what is wrong and what is the real cause?
> >
> 
> dpdk-devbind.py can also be used to bind devices to kernel modules.
> Some kernel modules are registered with '-' in their name and are populated 
> with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/modules/ as '_'

Sorry, still not clear.
What do you mean by "registered"?

> This confuses the current script making it unable to bind to such modules. The patch 
> addresses it by always replacing '-' with '_' when looking in /sys/modules/

Yes this sentence is clear (except it is /sys/module/).
Please send a v2 with a clear explanation.

Re: [dpdk-dev] [PATCH] usertools: enhance device bind script module detection

[Pavan Nikhilesh Bhagavatula]

>21/09/2019 20:16, pbhagavatula@marvell.com:
>> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>>
>> Some kernel modules have '-' in their name when populated in
>> '/sys/bus/pci/drivers/' where as the kernel always populates
>> '/sys/modules/' with '_'.
>> Replace '-' in module name with '_' to avoid script complaining
>> that module not loaded.
>
>Sorry it does not look obvious to me.
>Please, could you describe what is wrong and what is the real cause?
>

dpdk-devbind.py can also be used to bind devices to kernel modules.
Some kernel modules are registered with '-' in their name and are populated 
with '-' in '/sys/bus/pci/drivers/' but kernel populates the name in /sys/modules/ as '_'

This confuses the current script making it unable to bind to such modules. The patch 
addresses it by always replacing '-' with '_' when looking in /sys/modules/

Hope this clears things up.

Pavan.