From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7E69A0546; Thu, 16 Jul 2020 13:27:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D1423421; Thu, 16 Jul 2020 13:27:11 +0200 (CEST) Received: from wout5-smtp.messagingengine.com (unknown [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id E944C2C4F for ; Thu, 16 Jul 2020 13:27:09 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id A24C9A92; Thu, 16 Jul 2020 07:26:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 16 Jul 2020 07:27:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= agU1ijuo3AssS0rPA5e4k3K3RRJEBibKvz0HW88kmmg=; b=j82bejqZzKsZUlaT /CjkJDHa0kX437EzwFFThRwbWzg80X/1XOLaffMT8leSUEK0TtNUvLTll3Um2xNp piznDPUUlLa1fup/jjGxFyNvsydX4q4Ba1Qf3vnQ1nNYG/32diZEPSqvOjuEVSOo emM1hqYwtGV4rPRgpomb7bCWUZDq0wLCgW9kBVZ7XpbReESBaJekNMRKod6/cNF4 z/XIAx7i9J+sPsKeovUNKuHmDKMlbcRPirJ/Z60R5ZYISWzuTOp10wV3sYc7eEXI yhIVWovjmCI4DYmefLK3YY0sKMUZhic7cLqV9mVXKqvw7+fUyzSJzvDF4gQpOLO3 OdFTDQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=agU1ijuo3AssS0rPA5e4k3K3RRJEBibKvz0HW88km mg=; b=UwLu9CWdYF6e2/k7Fdf51G2z1gmi7Myu+g3DcmO963fP7NdDv3WwnFVZV KN9LTHZl500VZK7SEDn1CH6GMLlB2eCgchIlSQOtAiejPWq9qxsZXk+jlP+hUew5 aip0OHBpvLztuHDc1ANrURKcZ/Jo0ih8nsgutUxO4aJU2W0uBk244TipelZ8cpHo Jn5hRfMFxQ639hrol5q5iORgqu85sTmkPONlARldiu9Mjtyjmslmu93LETaySpwj Wun3Te8CUcN12t6Bn5Vwq1586J2gyLACsCApU/+RPpQFFvDQ94X8vjtbIMUQYK6l dJ8vuKI1mgX3GRkXJvhVJ09mtl+VQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfeeggdegtdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtudenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeefgeffiefhfeettdfhvdfgteekffffudekvedtvedtvdfgveeuudev gedvgeegtdenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 42FA3306005F; Thu, 16 Jul 2020 07:26:57 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Manish Chopra , Jerin Jacob Cc: dev@dpdk.org, Ferruh Yigit , Igor Russkikh , dpdk-dev Date: Thu, 16 Jul 2020 13:26:55 +0200 Message-ID: <2902125.JAyrVFZy8S@thomas> In-Reply-To: References: <20200713151319.17547-2-manishc@marvell.com> <20200716101753.722ld3p66bqrjss7@u256.net> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v2 1/7] lib/librte_pci: add rte_pci_regs.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/07/2020 12:27, Jerin Jacob: > On Thu, Jul 16, 2020 at 3:48 PM Ga=EBtan Rivet wrote: > > > > On 16/07/20 12:08 +0200, Ga=EBtan Rivet wrote: > > > Re-CCing dev@dpdk.org as it was removed from the reply. > > > > > > On 13/07/20 08:13 -0700, Manish Chopra wrote: > > > > This is merely copy of latest linux/pci_regs.h in > > > > order to avoid dependency of dpdk on user headers. > > > > > > > > > > I guess this dependency is an issue on non-linux systems, when you mu= st > > > use those defines in a generic implementation. Can you confirm this is > > > the motivation here? > > > > > > If so, I think it would be clearer to state "in order to avoid > > > dependency of DPDK on linux headers". > > > > > > > To add to it, if this is actually the motivation to add this header, I > > don't think it is sufficient. > > > > You can restrict the function definition to the linux part of the > > PCI bus driver instead, using stubs for other systems. > > > > > > Signed-off-by: Manish Chopra > > > > Signed-off-by: Igor Russkikh > > > > --- > > > > drivers/bus/pci/linux/pci_uio.c | 2 +- > > > > drivers/bus/pci/linux/pci_vfio.c | 2 +- > > > > drivers/net/bnx2x/bnx2x.h | 2 +- > > > > drivers/net/hns3/hns3_ethdev_vf.c | 2 +- > > > > drivers/vdpa/ifc/base/ifcvf_osdep.h | 2 +- > > > > lib/librte_pci/Makefile | 1 + > > > > lib/librte_pci/meson.build | 2 +- > > > > lib/librte_pci/rte_pci_regs.h | 1075 +++++++++++++++++++++++= ++++ > > > > 8 files changed, 1082 insertions(+), 6 deletions(-) > > > > create mode 100644 lib/librte_pci/rte_pci_regs.h > > > > > > > > > > [...] > > > > > > > diff --git a/lib/librte_pci/rte_pci_regs.h b/lib/librte_pci/rte_pci= _regs.h > > > > new file mode 100644 > > > > index 000000000..1d11f4de5 > > > > --- /dev/null > > > > +++ b/lib/librte_pci/rte_pci_regs.h > > > > @@ -0,0 +1,1075 @@ > > > > +/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ > > > > +/* > > > > > > This file is delivered alongside the PCI lib, targeting userspace. > > > This seems to be an exception to the license policy described in > > > license/README. Code shared between kernel and userspace is expected > > > to be dual-licensed BSD-3 and GPL-2.0. > > > > > > As it is a copy of Linux user includes, re-licensing it as BSD-3 as w= ell > > > is not possible. > > > > > > So I think it might require a techboard + governing board exception > > > approval. Ferruh or Thomas, what do you think? >=20 > I think, instead of importing GPL-2.0 file, We can add the constants > as need by the DPDK > as symbols start from RTE_PCI_*(It will fix up the namespace as well). If symbols can be found in /usr/include/, don't add anything.