From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gregory@weka.io>
Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48])
 by dpdk.org (Postfix) with ESMTP id AC3D999E4
 for <dev@dpdk.org>; Fri, 26 May 2017 08:17:35 +0200 (CEST)
Received: by mail-wm0-f48.google.com with SMTP id 7so116166841wmo.1
 for <dev@dpdk.org>; Thu, 25 May 2017 23:17:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=weka.io; s=google;
 h=from:to:cc:subject:date:message-id:organization:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=u+ZQps9CvznJaBsXihGkvhfLH7dby7oX170Ua10Demo=;
 b=4x2LGzBzHmz8OrybdgDnHDHmvKbmWqBSfQjmag/QOxBTwEKxXEOG6YwqAw0EsILaI5
 juTfCtD9Mkd5CtHs9hma9t+bfClnRtOVpSEzj4QnhozXT3sjMdyFKseaEe5KNEYHWiS6
 LEJqc8ZNTkIZT512uZDvihtbzNcC2HMsbCmno=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=u+ZQps9CvznJaBsXihGkvhfLH7dby7oX170Ua10Demo=;
 b=gy3M6HK0SaAJZooRdWf2rH50izsDep/CSjAXu+dEoYQFS3/0eKD4W0R5ncRZzmtNlM
 hYEtFL6zTpWizw3YWVwqcIWyL6Bmr4fqHwP2eUE2JjN1FBPrdrhpwMTyCMwPKy678DZX
 rvrFbIQDEvPuPCBpUoXfFq6k5V3W6jD5dAQFruwUCRb7G0HPOFR0vPCn4UYXCRdCRl0+
 dIvMsLt5GV2jX0sZlAjb7i8qY5FgPVGdcrrqU6wyKlp02Dl8fLJLzr4KeHwgbKpjouXB
 Iz16roi0i2zrrnDkF2RWX5bm9oUfyp8bh+7QD+JztlW0lMyI2QNdLeCUfilLOEUbf4Q1
 DFkA==
X-Gm-Message-State: AODbwcB0OoDU4i9d/a2T/2q5oi/pOzZDfCJbjH7+xyVoy8IlSddaS4fY
 9N64ZqWAqWnxGZQD
X-Received: by 10.28.154.198 with SMTP id c189mr11348569wme.117.1495779455432; 
 Thu, 25 May 2017 23:17:35 -0700 (PDT)
Received: from polaris.localnet (bzq-84-109-69-99.cablep.bezeqint.net.
 [84.109.69.99])
 by smtp.gmail.com with ESMTPSA id 1sm16032878wrw.32.2017.05.25.23.17.34
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Thu, 25 May 2017 23:17:34 -0700 (PDT)
From: Gregory Etelson <gregory@weka.io>
To: Shijith Thotton <shijith.thotton@caviumnetworks.com>
Cc: Stephen Hemminger <stephen@networkplumber.org>, dev@dpdk.org,
 Ferruh Yigit <ferruh.yigit@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>
Date: Fri, 26 May 2017 09:17:33 +0300
Message-ID: <2910302.37N35vC6kd@polaris>
Organization: Weka.IO
In-Reply-To: <20170526060509.GA5157@localhost.localdomain>
References: <106841857.Z7q1jSDIte@polaris> <2080347.1TTqQevoe3@polaris>
 <20170526060509.GA5157@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] i40e igb_uio: reset pci on process exit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 26 May 2017 06:17:36 -0000

Thank you.

Regards,
Gregory

On Friday, 26 May 2017 09:05:11 IDT Shijith Thotton wrote:
> On Fri, May 26, 2017 at 07:30:58AM +0300, Gregory Etelson wrote:
> 
> Hi Gregory,
> 
> The patch is useful for LiquidIO PMD as we can avoid VF FLR request to
> PF. One comment inline..
> 
> [..]
> > > >  
> > > > +static int
> > > > +igbuio_pci_release(struct uio_info *info, struct inode *inode)
> > > > +{
> > > > +       int ret;
> > > > +       struct rte_uio_pci_dev *udev = info->priv;
> > > > +       struct pci_dev *dev = udev->pdev;
> > > > +       ret = __pci_reset_function(dev);
> 
> s/__pci_reset_function/pci_reset_function
> 
> > > > +       dev_info(&dev->dev, "pci_reset_function %s \n",
> > > > +                 ret == 0 ? "succeded" : "failed");
> > > > +       return 0;
> > > > +}
> [..]
> 
> Thanks,
> Shijith
>