From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 7D4F3A04DC;
Mon, 26 Oct 2020 15:29:12 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id D6CD62B9D;
Mon, 26 Oct 2020 15:29:09 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by dpdk.org (Postfix) with ESMTP id CDACE1E2B
for <dev@dpdk.org>; Mon, 26 Oct 2020 15:29:07 +0100 (CET)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
by mailout.nyi.internal (Postfix) with ESMTP id 73BF35C0107;
Mon, 26 Oct 2020 10:29:04 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute2.internal (MEProxy); Mon, 26 Oct 2020 10:29:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=fm2; bh=
lnZCNa7MhiewLMs7EdU8o9aUMmHAgZIKmCBPtMuZGIQ=; b=pE83fR3kIZn0w8Lx
uEjVv5WzVBy4eDQeScVjrGJ3mAPiMa4/zaCEpnc/0qXDz9/Os/McGNTzS1MQSvzc
V2vpWHntdqAh6bSpQdSIHTl4dGOCxCcRx7JMki80q/TZAifz68XF4Er7UeBEeobg
VDcJchexyMPAl5xKZdkzz8pf8cln4P3pSR0JuATcAw897QEWQKLmb/fSuIx1vbbj
CNtSpSGFptJSgx39+RZaV2/MeH7yTQkoOkLmw42hpsx6qOgK94Jw8Wno6lecc/GB
NyJSQwA8+47ngtw62HzmcU4JvTcuI2pXX7klU6lqBLDYknyctpQsKDEORjKqUBar
XCv0Ww==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=lnZCNa7MhiewLMs7EdU8o9aUMmHAgZIKmCBPtMuZG
IQ=; b=mZsif4CuhLBOtYNB+CSdPJ0I52dxknRrNOO4S8PuZiGs9Wgm2GaPt4s2y
EAbpkkkbixKIgTWZ4P0dwQFC4gPbOTOjQ13d3YyuKeB/AjsSIOmFrNnlpT82DWID
I7kII3+okYRqMJrPiipaEJQ+UHhk4P/xdfT8F8wHeCa9uaR079P7Not5nPaTphzO
K2cb+V07rTMhFurEPI+xl8Xicz92wpjfZ56cr+56ypRUU4wehvnEX0BH47oDrAlv
SnuoO8GBvyf8SDKsZwVA3LECibZ/hAC0+032SdOxsTtflMMy4ynUcsvehcD5mHTb
7XXFuGQojaDhq8L9y/rE/knkYaIUA==
X-ME-Sender: <xms:L92WX0RnfeTFKVd9PP_xHk2DlJyNhYPe6SRbA93Kf7NFwD1W53qR2A>
<xme:L92WXxws0mbAjQnfmeS-xmVE14cFCGG7m_HkuQ9ymkO1vEh59Yf6RZXkzIdYWvDCF
Bm4EzOrgValsMN1Fg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeejgddvkecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
nhdrnhgvth
X-ME-Proxy: <xmx:L92WXx1IToQZduuqNrnDP7MlUpms5YzBffnl_k-kzQtHevWKxRCuUA>
<xmx:L92WX4Auvo-l9nmZqcFBX666wlY4wQ1dN8jZZcd01KU4py_vEANmQw>
<xmx:L92WX9iQBCyMH5PNcT-frlAoRzjNpn9JdnrE1biMvOCWnwwojKjSZg>
<xmx:MN2WX4Ul4_TYxN8VO89y958Tz0B3LtPeevyclkoMnHQA5GyRWPD2mg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 291B1306467D;
Mon, 26 Oct 2020 10:29:02 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: David Marchand <david.marchand@redhat.com>
Cc: dev <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Olivier Matz <olivier.matz@6wind.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Akhil Goyal <akhil.goyal@nxp.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>
Date: Mon, 26 Oct 2020 15:29:00 +0100
Message-ID: <2911701.ZJlzt3N5jF@thomas>
In-Reply-To: <CAJFAV8wJemBEOv74MDbxTH6qE2AnXtd3PhoziXjpt=WRRR1iZA@mail.gmail.com>
References: <20201026052105.1561859-1-thomas@monjalon.net>
<20201026052105.1561859-5-thomas@monjalon.net>
<CAJFAV8wJemBEOv74MDbxTH6qE2AnXtd3PhoziXjpt=WRRR1iZA@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 04/15] node: switch IPv4 metadata to dynamic
mbuf field
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
26/10/2020 11:40, David Marchand:
> On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > + node_mbuf_priv1_dynfield_offset = rte_mbuf_dynfield_register(
> > + &node_mbuf_priv1_dynfield_desc);
> > + if (node_mbuf_priv1_dynfield_offset < 0)
> > + return -1;
>
> How about return -rte_errno like what is done in setup_lpm()?
Yes, looks better
[...]
> > +static const struct rte_mbuf_dynfield node_mbuf_priv1_dynfield_desc = {
> > + .name = "rte_node_dynfield_priv1",
> > + .size = sizeof(uint64_t),
> > + .align = __alignof__(uint64_t),
>
> s/uint64_t/struct node_mbuf_priv1/g ?
Yes will do