From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 2B5502BB0 for ; Thu, 25 Oct 2018 08:45:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BA674220D7; Thu, 25 Oct 2018 02:45:17 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 25 Oct 2018 02:45:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=VAoIWu76LLEWeSZsh72UD58CMNyW4DUjiUKEFDNG5cA=; b=dXlo8HIGBIW9 5FZHLbR4KDuki3kWBbXjkPjalJB4PDwdVXv939T6DkDFnsNj/grVmsOej2dFLQdu sOczaD4V+BaZml4UKHh8eeoTwV/ajJQbOobVZ+zDbkgo+85TWZVIvALeRpIM0DUT UFHWgUxKvvtIdZU/XV8VGkbpP7AL4aE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=VAoIWu76LLEWeSZsh72UD58CMNyW4DUjiUKEFDNG5 cA=; b=om6Hcor5EoigrjaQHxI9Qo07R6b7pDlA/zWlYz5GyhRYeJaRGNPYeYu01 xqEWkH7lQWeQiLR/aDJ+LD18E7XGfE4oIzp5G+aq6SgQqPbttahvSk2FHeY84xcb cc04MQgSlGSeZaO1SVNXQKKL4rNPFgNCOSlRJeCsK2kGuIw5tj/94gEb3r1L1CtY SlqxsyCtCf3PdGI5NynVGvCk500EzVkza1hBKukOKTYTGT/biB41hLf5bQ9I6NyH sMlQUQlmVcr3Mbiin+u/haLtBLY6QrY+WjZqwi+pz3RpTrNyResJKZirOTpfkmIL vgxFX/rxfDpIVlxzagvRJ9m9jV/uw== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id CB732102EB; Thu, 25 Oct 2018 02:45:14 -0400 (EDT) From: Thomas Monjalon To: "Trahe, Fiona" Cc: "dev@dpdk.org" , Akhil Goyal , "Jozwiak, TomaszX" , "Kusztal, ArkadiuszX" Date: Thu, 25 Oct 2018 08:45:17 +0200 Message-ID: <2919877.NPW9lr0NG8@xps> In-Reply-To: <348A99DA5F5B7549AA880327E580B43589657639@IRSMSX101.ger.corp.intel.com> References: <1539645382-17112-1-git-send-email-fiona.trahe@intel.com> <3737696.dzgjCPvWHI@xps> <348A99DA5F5B7549AA880327E580B43589657639@IRSMSX101.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5] compress/qat: enable dynamic huffman encoding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Oct 2018 06:45:18 -0000 25/10/2018 02:40, Trahe, Fiona: > I'll send a v6. > On which OS/compiler did this fail to compile? It fails on i686 of course. I already sent some general notes in the past, explaining how %lx is most of the time wrong. %PRIu64 is the right specifier. https://www.mail-archive.com/dev@dpdk.org/msg90644.html > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > 24/10/2018 16:15, Akhil Goyal: > > > > > > On 10/18/2018 2:18 AM, Fiona Trahe wrote: > > > > Enable dynamic huffman encoding in the QAT comp PMD. > > > > > > > > Signed-off-by: Tomasz Jozwiak > > > > Signed-off-by: Fiona Trahe > > > > Acked-by: Arek Kusztal > > > > --- > > > Applied to dpdk-next-crypto > >=20 > > error: format =E2=80=98%lx=E2=80=99 expects argument of type =E2=80=98l= ong unsigned int=E2=80=99, but argument 7 has type =E2=80=98phys_addr_t=E2= =80=99 > > {aka =E2=80=98long long unsigned int=E2=80=99} [-Werror=3Dformat=3D] > > "%s(): " fmt "\n", __func__, ## args) > > ^~~~~~~~ > > drivers/compress/qat/qat_comp_pmd.c:194:2: note: in expansion of macro = =E2=80=98QAT_LOG=E2=80=99 > > QAT_LOG(DEBUG, "Memzone %s: addr =3D %p, phys =3D %lx, size required = %d," > >=20 > >=20 > > One more comment about the release notes, please try to integrate > > compressdev features between cryptodev and eventdev. > >=20 >=20 >=20