From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from tama500.ecl.ntt.co.jp (tama500.ecl.ntt.co.jp [129.60.39.148]) by dpdk.org (Postfix) with ESMTP id 2BDAE1B71E for ; Fri, 13 Apr 2018 06:27:22 +0200 (CEST) Received: from vc1.ecl.ntt.co.jp (vc1.ecl.ntt.co.jp [129.60.86.153]) by tama500.ecl.ntt.co.jp (8.13.8/8.13.8) with ESMTP id w3D4RFf0018404; Fri, 13 Apr 2018 13:27:15 +0900 Received: from vc1.ecl.ntt.co.jp (localhost [127.0.0.1]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id E8F33EA7ADD; Fri, 13 Apr 2018 13:27:14 +0900 (JST) Received: from jcms-pop21.ecl.ntt.co.jp (jcms-pop21.ecl.ntt.co.jp [129.60.87.134]) by vc1.ecl.ntt.co.jp (Postfix) with ESMTP id D1BACEA7470; Fri, 13 Apr 2018 13:27:14 +0900 (JST) Received: from [IPv6:::1] (watercress.nslab.ecl.ntt.co.jp [129.60.13.73]) by jcms-pop21.ecl.ntt.co.jp (Postfix) with ESMTPSA id 826DB400BD3; Fri, 13 Apr 2018 13:27:14 +0900 (JST) References: <1523023929-1257-1-git-send-email-vido@cesnet.cz> <1523023929-1257-2-git-send-email-vido@cesnet.cz> <26c45c25-7eb1-fd62-f0ef-0e1d929a80f8@intel.com> <7ea9c0b5-4d69-e473-95ef-eb43b5bebe59@cesnet.cz> <0ba99f11-b2b0-c86f-2308-cda28d401295@intel.com> <8ea96dcd-da70-084e-7b82-6bc4ca85bee1@cesnet.cz> From: Yasufumi Ogawa Message-ID: <2919a53b-cffd-da0f-dc22-835b3d3b967f@lab.ntt.co.jp> Date: Fri, 13 Apr 2018 13:25:52 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <8ea96dcd-da70-084e-7b82-6bc4ca85bee1@cesnet.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-CC-Mail-RelayStamp: 1 To: Matej Vido , Ferruh Yigit , dev@dpdk.org Cc: remes@netcope.com X-TM-AS-MML: disable X-Mailman-Approved-At: Sun, 15 Apr 2018 16:06:25 +0200 Subject: Re: [dpdk-dev] [PATCH 1/3] net/szedata2: do not affect Ethernet interfaces X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 04:27:23 -0000 On 2018/04/12 16:38, Matej Vido wrote: > On 11.04.2018 12:51, Ferruh Yigit wrote: >> On 4/11/2018 10:36 AM, Matej Vido wrote: >>> On 10.04.2018 17:28, Ferruh Yigit wrote: >>>> On 4/6/2018 3:12 PM, Matej Vido wrote: >>>>> NFB cards employ multiple Ethernet ports. >>>>> Until now, Ethernet port-related operations were performed on all >>>>> of them >>>>> (since the whole card was represented as a single port). >>>>> With new NFB-200G2QL card, this is no longer viable. >>>>> >>>>> Since there is no fixed mapping between the queues and Ethernet ports, >>>>> and since a single card can be represented as two ports in DPDK, >>>>> there is no way of telling which (if any) physical ports should be >>>>> associated with individual ports in DPDK. >>>>> >>>>> This is also described in documentation in more detail. >>>>> >>>>> Signed-off-by: Matej Vido >>>>> Signed-off-by: Jan Remes >>>>> --- >>>>>    config/common_base                                 |   5 - >>>>>    .../nics/img/szedata2_nfb200g_architecture.svg     | 171 >>>>> +++++++++++ >>>> Hi Matej, >>>> >>>> This patch fails to apply [1], can you please confirm you can apply it? >>>> >>>> [1] >>>> $ git apply --check >>>> dpdk-dev-1-3-net-szedata2-do-not-affect-Ethernet-interfaces.patch >>>> error: corrupt patch at line 270 >>> Hi Ferruh, >>> >>> I've got same error on patch downloaded from patchwork. It seems that >>> the difference between the downloaded patch and the patch generated from >>> git is that the long lines in svg file are split into multiple lines in >>> the patch downloaded from patchwork. I suppose this could be the >>> problem. Any idea how to send a patch containing svg file correctly? >> cc'ed Ogawa-san for support, >> >> I remember he fixed similar issue in the past for spp, but I don't >> remember how? > Anyways I've hopefully fixed this by redrawing the image to avoid those > long lines. I'm sending v2. > > Thanks, > Matej Hi Matej, Ferruh, I also encountered the same problem for 998 chars limitation of SMTP. I fixed it by replacing objects with simpler ones. You can check this error by using '--validate' option of git send-email. Thanks, Yasufumi >> >>> Thanks, >>> Matej >>> > > > -- Yasufumi Ogawa NTT Network Service Systems Labs