From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65102A04A5; Wed, 17 Jun 2020 21:48:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B98C31252; Wed, 17 Jun 2020 21:48:13 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 95FC11023 for ; Wed, 17 Jun 2020 21:48:11 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 04FD65C0154; Wed, 17 Jun 2020 15:48:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Wed, 17 Jun 2020 15:48:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= Lm+9dFfLlz4a/DTza5+/swsNISAB0RMSkOtIuyRmqdE=; b=i7QqyQCqEPWfuYcX 6kG7DXOjdQq3KNo1PWzlGDRfF8T0PTdtTJYR7JlR5aopQtIsrgsYK8eZU9349rDZ owazLehAr5v5zbq7f8kKW+tTQDlWjHR+1oLaZCDT4UvlnNWsN9z5G5IQYkd6rtJi kZuF3KwyDIuhNZkr5SufLqRI3IulQ3bdEU/zcLIPURx3j15fMtDJ9Hd3L05i1LT2 s//ez/7i5Kt+IuTrGp2Uc7vIUClwAB0c5cnlYNSeXkDllu7q8oz1QCoSF6/qjYn6 Qr17rLsc+dcvWnYO4OpKU+Kpn80Ki+C9P8s+ys0M02+DlR0cKQ/0QhOPVmD7Olhk R5MTiA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=Lm+9dFfLlz4a/DTza5+/swsNISAB0RMSkOtIuyRmq dE=; b=DrbvuzAg9OTM3XHJvYDqa3PbRt8xn83MUd3pwcbFKfUahoS7x+Z7rH/eT pNIkMibdIjji5EdKoOAjOq04Io/byf70o/9rsPRFzk+C+D4tCmVs9itmdMMErgL7 ZIjytikpWQgNn8RH0iYxZHyFeGUY8XKb5Fgry1Mbwu8PUldFjCkK+40oczLMJBJN Z2+4Z5DAkNr67LcDPXXOscHLfwZWT2uCKJnsHu7mkYKt4LVOkGGnZdIi3Y3gX3RP HmT9aqYxItHtckJ2IgKh68Ti2ofAmH9yBMi/mnEbhflyloOIP5ZgdpPKeftNIJkj KwxuIUJ02R3U0PeXDFhPfWeXg3wWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejvddgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 132093060FE7; Wed, 17 Jun 2020 15:48:08 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar , Ferruh Yigit Cc: Wenzhuo Lu , Beilei Xing , Bernard Iremonger , John McNamara , Marko Kovacevic , dev@dpdk.org, nd@arm.com Date: Wed, 17 Jun 2020 21:48:07 +0200 Message-ID: <2923078.vE1UA2jcWa@thomas> In-Reply-To: <6bee6e1d-547d-9c34-1e4d-f821cfd8f843@intel.com> References: <20200508223829.3228-3-dharmik.thakkar@arm.com> <20200520032023.2649-2-dharmik.thakkar@arm.com> <6bee6e1d-547d-9c34-1e4d-f821cfd8f843@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 2/2] doc: include config options in testpmd user guide X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 17/06/2020 20:21, Ferruh Yigit: > On 5/20/2020 4:20 AM, Dharmik Thakkar wrote: > > Update testpmd documentation to include RECORD configuration options, > > CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES and > > CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS. > > > > Signed-off-by: Dharmik Thakkar > > Reviewed-by: Honnappa Nagarahalli > > Reviewed-by: Phil Yang > > --- > > v3: > > - Replace config/common_base with build/.config (Thomas) > > > > v2: > > - Remove extra '#'. > > --- > > doc/guides/testpmd_app_ug/build_app.rst | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/doc/guides/testpmd_app_ug/build_app.rst b/doc/guides/testpmd_app_ug/build_app.rst > > index d1ca9f3d19a9..8c9aaa83187f 100644 > > --- a/doc/guides/testpmd_app_ug/build_app.rst > > +++ b/doc/guides/testpmd_app_ug/build_app.rst > > @@ -21,6 +21,18 @@ The basic compilation steps are: > > > > export RTE_TARGET=x86_64-native-linux-gcc > > > > +#. If required, enable configuration options. For example: > > + > > + .. code-block:: console > > + > > + cd to the top-level DPDK directory > > + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES\)=n,\1=y,' build/.config > > + sed -i 's,\(CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS\)=n,\1=y,' build/.config > > + > > + Enabling CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES enables measurement of CPU cycles. > > + > > + Enabling CONFIG_RTE_TEST_PMD_RECORD_BURST_STATS enables display of RX and TX bursts. > > + > > #. Build the application: > > > > .. code-block:: console > > > > Hi Dharmik, > > This patch waiting to address the Thomas comment on document how to enable those > config options in meson. @Thomas, can you please correct if I got it wrong? If the doc is only about make, it will be removed in 2 months. So yes, I think it doesn't make sense to be merged as is.