From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7D92A0521; Tue, 3 Nov 2020 15:44:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1252CCB9E; Tue, 3 Nov 2020 15:44:20 +0100 (CET) Received: from wout1-smtp.messagingengine.com (wout1-smtp.messagingengine.com [64.147.123.24]) by dpdk.org (Postfix) with ESMTP id 4C075CB96 for ; Tue, 3 Nov 2020 15:44:18 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id F01E1CC5; Tue, 3 Nov 2020 09:44:15 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Tue, 03 Nov 2020 09:44:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= 1XxFnVy06irnSSE0ZBSlM4mSJa98HIC9iBGdpRCb2W8=; b=pKoVxiqeWEHwV7ob npSgo/58fvEXvjEI9T41dnr8g9jcQDCleudfVZv0OXANyH3TApC5LRadRIiA6X89 b/3xwEBFxwVQC9x2zxvvDcgUY34SsIdPxjR1h1AEYJC7C+iVGMkMpf8KK6HXlLdp md0vjVeQexoHFJL/mYwNW0y6cwoPlMTH6mvQxRSW12SIvBU6QraEV47iEGPlyANl SdMd793uIfXIz2wEeQVHHR35TfGkn8aBDaHwGa+Rf6ygcOnArOU7EMxhLFswVoBd yMUJjfznAwhHvw1MDENETp4U5Ng9SeVmHk+2bY5n5Ebz5Bg1lIj17IWEY5cURe32 6iUzvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=1XxFnVy06irnSSE0ZBSlM4mSJa98HIC9iBGdpRCb2 W8=; b=KeESTQQqjixhj/eOMJ2Ubu3Ztyr3mV6GdRW03zQ6ZjlnnZycM1i1NAh3V 1zHh1kAAe4KSI72wOhYkD9ICmtDOj1fvJE8CxiT3xHsVGcyanqnk/4gQFFcgcDku YFBQP5QpuT3jB8YCwZW6KvGK6jSJfqnXTTLnWo6jdkMmeLR1XzIbgia/iP/kTtLF a3S8uKgtn0NagMCutPpolDy5Qwns9aYVKA/oBLF+lezKXoy3142t0+avzlVKZsMc QHT56sI16Vw+1F876YQNQuXtEHIG3QOB0pELUIJJOqTkNPvAP8EzPs+7eReGZu8g WD80Od8rqO2EXpHKxqWWi4T2KlpJw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedruddtfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1A1733280065; Tue, 3 Nov 2020 09:44:14 -0500 (EST) From: Thomas Monjalon To: david.marchand@redhat.com, andrew.rybchenko@oktetlabs.ru, Olivier Matz Cc: dev@dpdk.org, ferruh.yigit@intel.com, bruce.richardson@intel.com, jerinj@marvell.com, viacheslavo@nvidia.com Date: Tue, 03 Nov 2020 15:44:13 +0100 Message-ID: <2923565.yYrEMq4hht@thomas> In-Reply-To: <20201103141756.GF1898@platinum> References: <20201029092751.3837177-1-thomas@monjalon.net> <20201103140931.488700-1-thomas@monjalon.net> <20201103141756.GF1898@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v5 00/16] remove mbuf timestamp X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/11/2020 15:17, Olivier Matz: > On Tue, Nov 03, 2020 at 03:09:15PM +0100, Thomas Monjalon wrote: > > The mbuf field timestamp was announced to be removed for three reasons: > > - a dynamic field already exist, used for Tx only > > - this field always used 8 bytes even if unneeded > > - this field is in the first half (cacheline) of mbuf > > > > After this series, the dynamic field timestamp is used for both Rx and Tx > > with separate dynamic flags to distinguish when the value is meaningful > > without resetting the field during forwarding. > > > > As a consequence, 8 bytes can be re-allocated to dynamic fields > > in the first half of mbuf structure. > > It is still open to change more the mbuf layout. > > > > This mbuf layout change is important to allow adding more features > > (consuming more dynamic fields) during the next year, > > and can allow performance improvements with new usages in the first half. [...] > > 39 files changed, 440 insertions(+), 180 deletions(-) > > For the series: > Acked-by: Olivier Matz Applied, thanks for the help Olivier, David and Andrew. Next step: decide whether we keep "free space" in the first half for dynamic fields or move another field from the second half.