From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f174.google.com (mail-wr0-f174.google.com [209.85.128.174]) by dpdk.org (Postfix) with ESMTP id 721815583 for ; Thu, 16 Feb 2017 11:53:16 +0100 (CET) Received: by mail-wr0-f174.google.com with SMTP id i10so8901298wrb.0 for ; Thu, 16 Feb 2017 02:53:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=ETJmO83HTTYnx190iCgfHO8N0FAbJ59gyuiwhNsnWGw=; b=IkQXN3+EP6bwkLDJsL+/YbMrCHtxxLSPH1Nz+sofVgck/Gpq0utuS+VHqwdZIrfNeH GQSfQqDkP7ezK2ooVYzdCO6WtU2AaKjmLfymildRH0T2M/3RQJSwNfwKsluX+BfCzqhJ 8o11hWKsUPjd1t1s8oxiwz2zoC8TAwvn1mSVURTQnMk3DmiWL6vEeKC1NUm1TFBOsHkA zIz0+Yhdzd/NV9ATUXA5IMgNfunBZbKH/9HGMAvFiZ1lAEc2H+8+Vye9xyubnHoJmt9+ tQN6U1iJHVCCFODRaluRfkJAFPUMFnzMMI+klzbw1J2sE2t+CfeXucEhVqede8H7KsK2 gQ+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ETJmO83HTTYnx190iCgfHO8N0FAbJ59gyuiwhNsnWGw=; b=d5H0ysm7b2ml7DXe1T2id6mC4PMVIypGGNnZhDa5or+l3bpDFYVPEhSIDcybKhnYlM qvhmtqqaq+dE7vj3DmtV5mJl6EpeL6QmCWmc6l4L59RvMU0ZE8lXJ+4cDG3ncfTgtAkT dzugXBfrGpTUCT2kCZNEOiboVX1x43S6eLxowTLTULFK4M7VSrJHEdUoSYGd6/RXfypH oy0kGhQFNZKfoEdtQV6Nji/LQIaox+MQ0rE/S7WT42o93kSvQ5Ez3oY3WaKIWuambchZ kruUMSHKBjirncb6YnK73u5OYkk0umo+fHIy1KDNc7CPlnXvZOBA/gW7KNuJkg9WaNuc tUBw== X-Gm-Message-State: AMke39kLXgXRgTF4AokI/dP8a2uFl+L7lcIBe3Uv57+U5ofBsotIxx9933wTbCnEzXb3eyl9 X-Received: by 10.223.160.206 with SMTP id n14mr1657276wrn.31.1487242396251; Thu, 16 Feb 2017 02:53:16 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u47sm8518704wrb.15.2017.02.16.02.53.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Feb 2017 02:53:15 -0800 (PST) From: Thomas Monjalon To: Remy Horton Cc: dev@dpdk.org Date: Thu, 16 Feb 2017 11:53:14 +0100 Message-ID: <2924793.QDCoddA1K3@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1486118019-2280-1-git-send-email-remy.horton@intel.com> References: <1486118019-2280-1-git-send-email-remy.horton@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v10 0/7] Expanded statistics reporting X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Feb 2017 10:53:16 -0000 2017-02-03 10:33, Remy Horton: > This patchset extends statistics reporting to include peak and > average data-rate metrics. It comes in two parts: a statistics > reporting library, and a bitrate calculation library that uses > it. This structure is intended to seperate statistic reporting > from ethdev and allow more flexible metric registration. Note that this series integrates a third part for latency metric. > v10 changes: > * Rebased > * Relocated some config-related directives. > * Removed incorrect capitalisations in API docs. > * Formatting & detail corrections in release notes. > * Moved around struct member descriptions. > * Rewritten rte_metrics.h file description. > * Rewritten description of RTE_METRICS_GLOBAL. > * Used 'producers' and 'consumers' as terms. > * Removed markup (bold text) in Doxygen tags. > * Added programming guide section. Thanks for adding the prog guide section. It helps. I think there are three remaining questions: - When the metrics computation are done? (in which thread?) - May the few lines of computation code be done differently when tightly integrated in an application logic? - Could it be hosted in a separate repository on dpdk.org?