* [dpdk-dev] [PATCH] app/testpmd: fix redundant time update
@ 2016-07-15 9:19 Reshma Pattan
2016-07-15 9:58 ` De Lara Guarch, Pablo
0 siblings, 1 reply; 3+ messages in thread
From: Reshma Pattan @ 2016-07-15 9:19 UTC (permalink / raw)
To: dev; +Cc: Reshma Pattan
Inside flush_fwd_rx_queues removed redundant prev_tsc update with cur_tsc,
as prev_tsc value is always updated with rte_rdtsc() in for loop.
Coverity issue: 127797
Fixes: f487715f36f5 ("app/testpmd: add timeout in Rx queue flushing")
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
app/test-pmd/testpmd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index b7f28e9..1428974 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -907,7 +907,6 @@ flush_fwd_rx_queues(void)
timer_tsc += diff_tsc;
} while ((nb_rx > 0) &&
(timer_tsc < timer_period));
- prev_tsc = cur_tsc;
timer_tsc = 0;
}
}
--
2.5.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix redundant time update
2016-07-15 9:19 [dpdk-dev] [PATCH] app/testpmd: fix redundant time update Reshma Pattan
@ 2016-07-15 9:58 ` De Lara Guarch, Pablo
2016-07-15 21:41 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: De Lara Guarch, Pablo @ 2016-07-15 9:58 UTC (permalink / raw)
To: Pattan, Reshma, dev; +Cc: Pattan, Reshma
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Reshma Pattan
> Sent: Friday, July 15, 2016 10:19 AM
> To: dev@dpdk.org
> Cc: Pattan, Reshma
> Subject: [dpdk-dev] [PATCH] app/testpmd: fix redundant time update
>
> Inside flush_fwd_rx_queues removed redundant prev_tsc update with
> cur_tsc,
> as prev_tsc value is always updated with rte_rdtsc() in for loop.
>
> Coverity issue: 127797
>
> Fixes: f487715f36f5 ("app/testpmd: add timeout in Rx queue flushing")
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] app/testpmd: fix redundant time update
2016-07-15 9:58 ` De Lara Guarch, Pablo
@ 2016-07-15 21:41 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2016-07-15 21:41 UTC (permalink / raw)
To: Pattan, Reshma; +Cc: dev, De Lara Guarch, Pablo
> > Inside flush_fwd_rx_queues removed redundant prev_tsc update with
> > cur_tsc,
> > as prev_tsc value is always updated with rte_rdtsc() in for loop.
> >
> > Coverity issue: 127797
> >
> > Fixes: f487715f36f5 ("app/testpmd: add timeout in Rx queue flushing")
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-15 21:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-07-15 9:19 [dpdk-dev] [PATCH] app/testpmd: fix redundant time update Reshma Pattan
2016-07-15 9:58 ` De Lara Guarch, Pablo
2016-07-15 21:41 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).