From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <maxime.coquelin@redhat.com>
Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73])
 by dpdk.org (Postfix) with ESMTP id 4E1871B492
 for <dev@dpdk.org>; Thu, 28 Jun 2018 17:08:36 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com
 [10.11.54.6])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 636374076063;
 Thu, 28 Jun 2018 15:08:35 +0000 (UTC)
Received: from [10.36.112.57] (ovpn-112-57.ams2.redhat.com [10.36.112.57])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 808462142F20;
 Thu, 28 Jun 2018 15:08:34 +0000 (UTC)
To: Marvin Liu <yong.liu@intel.com>, tiwei.bie@intel.com
Cc: zhihong.wang@intel.com, dev@dpdk.org
References: <20180628215235.106069-1-yong.liu@intel.com>
 <20180628215235.106069-8-yong.liu@intel.com>
From: Maxime Coquelin <maxime.coquelin@redhat.com>
Message-ID: <293017f8-75d6-7c3a-9b27-47f823c3b8ba@redhat.com>
Date: Thu, 28 Jun 2018 17:08:31 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180628215235.106069-8-yong.liu@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.11.55.7]); Thu, 28 Jun 2018 15:08:35 +0000 (UTC)
X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]);
 Thu, 28 Jun 2018 15:08:35 +0000 (UTC) for IP:'10.11.54.6'
 DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com'
 HELO:'smtp.corp.redhat.com' FROM:'maxime.coquelin@redhat.com' RCPT:''
Subject: Re: [dpdk-dev] [PATCH v3 07/11] net/virtio: support in-order Rx and
	Tx
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2018 15:08:36 -0000



On 06/28/2018 11:52 PM, Marvin Liu wrote:
> IN_ORDER Rx function depends on merge-able feature. Descriptors
> allocation and free will be done in bulk.
> 
> Virtio dequeue logic:
>      dequeue_burst_rx(burst mbufs)
>      for (each mbuf b) {
>              if (b need merge) {
>                      merge remained mbufs
>                      add merged mbuf to return mbufs list
>              } else {
>                      add mbuf to return mbufs list
>              }
>      }
>      if (last mbuf c need merge) {
>              dequeue_burst_rx(required mbufs)
>              merge last mbuf c
>      }
>      refill_avail_ring_bulk()
>      update_avail_ring()
>      return mbufs list
> 
> IN_ORDER Tx function can support offloading features. Packets which
> matched "can_push" option will be handled by simple xmit function. Those
> packets can't match "can_push" will be handled by original xmit function
> with in-order flag.
> 
> Virtio enqueue logic:
>      xmit_cleanup(used descs)
>      for (each xmit mbuf b) {
>              if (b can inorder xmit) {
>                      add mbuf b to inorder burst list
>                      continue
>              } else {
>                      xmit inorder burst list
>                      xmit mbuf b by original function
>              }
>      }
>      if (inorder burst list not empty) {
>              xmit inorder burst list
>      }
>      update_avail_ring()
> 
> Signed-off-by: Marvin Liu <yong.liu@intel.com>
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime