From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A16E7A0487 for <public@inbox.dpdk.org>; Mon, 1 Jul 2019 16:37:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 672CD1B9CE; Mon, 1 Jul 2019 16:37:45 +0200 (CEST) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) by dpdk.org (Postfix) with ESMTP id 051641B9CC for <dev@dpdk.org>; Mon, 1 Jul 2019 16:37:44 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id A4A4048C; Mon, 1 Jul 2019 10:37:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Mon, 01 Jul 2019 10:37:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=bAxZ5rGdWmb6nugDOHKx6ptexSkQoSVBPE1wjiqssL0=; b=N6fDtVlBlp4n SFF/VGjqVZC6iK11hClGdjiDlMml+rHstue0lP1/Pt3Gc3ugK9riHtmXliFruG2S muoxUGS9zGA7OuVCmMwjfrrKohheLc0OFyXLZg7j5SuIbe6zl3aaQNHJSGeCeqDN yxy70TnILHXN10fEWoyDWvk60wqHFpM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=bAxZ5rGdWmb6nugDOHKx6ptexSkQoSVBPE1wjiqss L0=; b=QA+SGme6eh2jdqVq8BoAvnICVo7JfFYF4gAFsfQaMs9B3eqal0XhJ6EuH Bu6nKGS32+Q2fRIoXFNykQ5TSuaX4a5Ihq18fKbJNBbCqbawiQZwmPNNJqS6xEPq leTPMOzArONpciSYi94zVsboTt+2RxhV7iI5s7vGSv7Mn+w7sgkTWDVnFd+0glM+ cMVa9hFNAGN+IE2bCnQro3epsFskqQ9RPnp6Tgt7qGscgHG/YUnFk9njm+ydi1n4 t8ePk+494/ktRKFECb6e1HLyBYoRozGzt3JK2wtOIdDUIWnrM2V2WjC1qjJnT1h/ y9qvyUYV8txKPFPb9mCg1o4cvanww== X-ME-Sender: <xms:tRoaXX4Rvs8rS4_UM4MdzxqhleDygnBYW6OGJTLwG2mFdlK4ePeUZw> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrvdeigdejlecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: <xmx:tRoaXXywnwl07vHO6N1_WQBMtfJcEbROdWwt3djvpJPOiEQvRimjsA> <xmx:tRoaXWRNDC8ydJnFmv8775QyHk8D8wWTTwl0ysPghMKse1cjeRlRVw> <xmx:tRoaXWXZ3pNbzxYsNmOxBVbBoQFZ4xoFu_0NsQdpBa6bgVmxwp33wg> <xmx:thoaXY4BDGe8AeuzTwURT_0ctJznX3xySV6pFIRy2fGfdMO9p61P5A> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 51F9338008E; Mon, 1 Jul 2019 10:37:40 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Ivan Malov <ivan.malov@oktetlabs.ru> Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com> Date: Mon, 01 Jul 2019 16:37:38 +0200 Message-ID: <2937548.CbNlbEgAvt@xps> In-Reply-To: <20190701131044.ifakclavrrs6an3s@platinum> References: <20190412150542.12026-1-ivan.malov@oktetlabs.ru> <20190627210618.22205-1-ivan.malov@oktetlabs.ru> <20190701131044.ifakclavrrs6an3s@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mbuf: outer offsets are undefined for non-tunnel packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> 01/07/2019 15:10, Olivier Matz: > On Fri, Jun 28, 2019 at 12:06:18AM +0300, Ivan Malov wrote: > > The default policy for offload-specific fields is that > > they are undefined unless the corresponding offloads are > > requested in mbuf ol_flags. This is also the case for outer > > L2 and L3 length fields which must not be assumed to contain > > zeros for non-tunnel packets. The patch clarifies this behaviour > > in the comments and also adds appropriate checks to the PMDs which > > do not check any tunnel-related offloads before using the said fields. > > > > Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru> > > Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com> > > Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com> > > Acked-by: Olivier Matz <olivier.matz@6wind.com> Applied, thanks