From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E14BFA04BB; Wed, 2 Sep 2020 15:57:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4414E137D; Wed, 2 Sep 2020 15:57:35 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 112E3DE0 for ; Wed, 2 Sep 2020 15:57:33 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id z1so5356655wrt.3 for ; Wed, 02 Sep 2020 06:57:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ippSQXa4d2tje/xhq394a8FUpHSXdRL9UzE0XS5XLDI=; b=I3a5FTvQeZjz7fGtDn1Q/N1UjBc8juqCimazVrMVE/PsxtpJTz2p+j5WBqCpIBzEST jsF/eT6unZvsTZwwKlKbYc0XYFrmGikW7W/p65HEp/H8Trjg3Aoj5rR5kuP/sXIcs1Nw N2H1SigIPe2noBsizc0QS3MZw2OG+luQUeHHyl0IxxgYoxNEZbq+E1yfnruup2220vHP NPBcT0l25TuQ0UwOTcUvEGcESvykRyXsqS9Kn01dCOY05cynunLWgboeiiaJTx394Anb x8yjhho1K8suG2mz9QO83Xy27Y/D+u/0aWGImiMgtJHsyl2OdkyOlO7+UAEsD9hQWKEr 6eJQ== X-Gm-Message-State: AOAM5313h3tBGp5rx+JC+MK858OMz9b1VouaExwIAJzR+YKC5/swxLor GBQhhIS8ZHxbKm5O+sPPUQQ= X-Google-Smtp-Source: ABdhPJz1ertrolsbFrQip2AjeZwRkrEXCPBNE1nY1g/fkddUJuhDBj2V+cETkVc0LdG1YJ69bLk8Cw== X-Received: by 2002:a5d:6291:: with SMTP id k17mr7268332wru.130.1599055053629; Wed, 02 Sep 2020 06:57:33 -0700 (PDT) Received: from localhost (82-132-217-215.dab.02.net. [82.132.217.215]) by smtp.gmail.com with ESMTPSA id a74sm6927018wme.11.2020.09.02.06.57.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2020 06:57:32 -0700 (PDT) Message-ID: <293bebf2ff9970e38ad3e4aba5c90056b3a995d4.camel@debian.org> From: Luca Boccassi To: Christian Ehrhardt , dev , Bruce Richardson , Thomas Monjalon Date: Wed, 02 Sep 2020 14:57:31 +0100 In-Reply-To: <20200902123903.803110-1-christian.ehrhardt@canonical.com> References: <20200902123903.803110-1-christian.ehrhardt@canonical.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] avoid libfdt checks adding full paths to pkg-config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-09-02 at 14:39 +0200, Christian Ehrhardt wrote: > The checks for libfdt try dependency() first which would only work if > a pkg-config would be present but libfdt has none. > Then it probes for the lib path itself via cc.find_library. >=20 > But later it adds the result of either probe to ext_deps which ends up > in build and also the resulting pkg-config to contain toolchain versioned > paths in Libs.private like: > /usr/lib/gcc/x86_64-linux-gnu/9/../../../x86_64-linux-gnu/libfdt.so > which obviously breaks on toolchain updates. >=20 > In general libs used multiple times - ipn3ke + ifpga in this case - are > checked centrally in config/meson.build so move it there and fix the > adding of dependencies to not use the full file path. >=20 > The result is libfdt in pkg-config now showing up as: > Libs.private: -pthread -lm -ldl -lnuma -lfdt -lpcap >=20 > Signed-off-by: Christian Ehrhardt > Reviewed-by: Luca Boccassi > Reviewed-by: Bruce Richardson > --- > config/meson.build | 9 +++++++++ > drivers/net/ipn3ke/meson.build | 6 +----- > drivers/raw/ifpga/meson.build | 7 +------ > 3 files changed, 11 insertions(+), 11 deletions(-) Given this is low-risk and it fixes a build failure that is happening right now in Debian/Ubuntu, I'll pick it up for 19.11.4 straight away. --=20 Kind regards, Luca Boccassi