From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 5BB6C108F for ; Tue, 17 Jan 2017 21:14:14 +0100 (CET) Received: by mail-wm0-f44.google.com with SMTP id c206so241142023wme.0 for ; Tue, 17 Jan 2017 12:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=El7QGFkuHh2BtRftrh90TBYD7XnDgldhWtcf1JVcNFw=; b=ZtvQ9erx9LnGBEGvpOclIrYI8L5K67B1JLM6klaOjlj5NbX9NfVaw+vVN9O2LETm0o HHFIQEjzxQLAUGibRNVgFfqJZMsLBtRt/fH43swt2ZdcnR4DeLf/F2xGTZzZ6yR/qZay d1ebKbzVTcUC1auZNuDEl6uQRRA0Ss1RDMmSIEkM+Udmsw8YQPU0pWucDkNQM2v0xObr j8iuIGOzhwzWquDFCDJdaayLi3pamrVuxc3Wl2WAHaMtLiS3uR1Z9iX2RHLBn8vM2RGY bkrDcCkdKTFCJkJXCkGr8nLFhEET6ToiiYwGDXkpzzPfqg9qjrEucmn4wN8kSPIGm9pi wgSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=El7QGFkuHh2BtRftrh90TBYD7XnDgldhWtcf1JVcNFw=; b=EpjAW6fuE6kHGJXYt1hg5ClDpZZewluUW8KEmqnnkOe9KjCeyG4hQIyOn40Z+ZoY/W A9DhOca9xOX8XlyDJuz+yQOEsZlBeYSsXrLB96UQvVurVQC/QHqteK7i/X8k324vax2m lIxx7w7YCzwOWe8oyEUPufXvBpnGZYXXJsflGZsFatO8uAoXHcAi3447cnxo+jUokRtQ owZdLOIVDtGBQYD9WtCrm9QwUixIwR+QELj+utkdXrD7fesIx5/L2irj+jaTpKJLjr47 nq5Tph0lwer9PTdxM/sUNAVYVhOQ97CmPoGB6ii0bbYtvCDIFTFO0l8BktBADnYUUhyv nLyg== X-Gm-Message-State: AIkVDXLJd1L6JlmYYNvsj0DLYhf+J/LVMWar+xTSUC2Pii+nm9183VHYB3GkSkc3h3EAkROu X-Received: by 10.28.1.213 with SMTP id 204mr16636838wmb.70.1484684054037; Tue, 17 Jan 2017 12:14:14 -0800 (PST) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id g75sm24299568wme.5.2017.01.17.12.14.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 12:14:13 -0800 (PST) From: Thomas Monjalon To: "Yang, Zhiyong" Cc: "Richardson, Bruce" , "Ananyev, Konstantin" , yuanhan.liu@linux.intel.com, "De Lara Guarch, Pablo" , dev@dpdk.org Date: Tue, 17 Jan 2017 21:14:12 +0100 Message-ID: <2941830.sLC5GUQ46q@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1480926387-63838-2-git-send-email-zhiyong.yang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/4] eal/common: introduce rte_memset and related test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Jan 2017 20:14:14 -0000 2017-01-17 06:24, Yang, Zhiyong: > Hi, Thomas: > Does this patchset have chance to be applied for 1702 release? It could be part of 17.02 but there are some issues: The x86 part did not receive any ack from x86 maintainers. checkpatch reports some warnings, especially about counting elements of an array. Please use RTE_DIM. The file in generic/ is for doxygen only. Please check how it is done for other files. The description is "Functions for vectorised implementation of memset()." Does it mean memset from glibc does not use vector instructions? The functional autotest is not integrated in the basic test suite. I wish this kind of review would be done by someone else. As it has not a big performance impact, this series could wait the next release. By the way, have you tried to work on glibc, as I had suggested?