Re: [dpdk-dev] [PATCH v3] app/testpmd: add cmdline option to set Rx mq mode

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 5/7/2020 11:23 AM, Iremonger, Bernard wrote:
> 
> Hi Xiaoyu,
> 
>> -----Original Message-----
>> From: Xiaoyu Min <jackmin@mellanox.com>
>> Sent: Thursday, May 7, 2020 1:52 AM
>> To: Yigit, Ferruh <ferruh.yigit@intel.com>; Lu, Wenzhuo
>> <wenzhuo.lu@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Iremonger,
>> Bernard <bernard.iremonger@intel.com>; Mcnamara, John
>> <john.mcnamara@intel.com>; Kovacevic, Marko
>> <marko.kovacevic@intel.com>
>> Cc: dev@dpdk.org
>> Subject: [PATCH v3] app/testpmd: add cmdline option to set Rx mq mode
>>
>> One new cmdline option `--rx-mq-mode` is added in order to have the
>> possibility to check whether PMD handle the mq mode correctly or not.
>>
>> The reason is some NICs need to do different settings based on different RX
>> mq mode, i.e RSS or not.
>>
>> With this support in testpmd, the above scenario can be tested easily.
>>
>> Signed-off-by: Xiaoyu Min <jackmin@mellanox.com>

<...>

>> @@ -1363,6 +1366,18 @@ launch_args_parse(int argc, char** argv)
>>  }
>>  if (!strcmp(lgopts[opt_idx].name, "no-iova-contig"))
>>  mempool_flags =
>> MEMPOOL_F_NO_IOVA_CONTIG;
>> +
>> +if (!strcmp(lgopts[opt_idx].name, "rx-mq-mode")) {
>> +char *end = NULL;
>> +n = strtoul(optarg, &end, 16);
>> +if (n >= 0 && n <=
>> ETH_MQ_RX_VMDQ_DCB_RSS)
>> +rx_mq_mode = (enum
>> rte_eth_rx_mq_mode)n;
>> +else
>> +rte_exit(EXIT_FAILURE,
>> + "rx-mq-mode must be >= 0
>> and "
>> + " <= %d\n",
>> +
> 
> Better not to split error string over two lines (passes checkpatch for me)
> 

+1, will fix while merging.