From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f175.google.com (mail-wr0-f175.google.com [209.85.128.175]) by dpdk.org (Postfix) with ESMTP id 74307326C for ; Tue, 4 Apr 2017 17:03:53 +0200 (CEST) Received: by mail-wr0-f175.google.com with SMTP id w11so215578322wrc.3 for ; Tue, 04 Apr 2017 08:03:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=avuA3FEfFYP8n4AdVLNvjNqZjBimzlVsWhWaSAVMX7E=; b=Pt4Io40/6ThXfryRZDi9MEdD/Doe9Blh9PNzMQTue/DfqeOIaTEepYuEbUpek2loIi zC5vn9/eFoXMh+c0p+aFcRCGGJ1Rs2RLQ3oG+yHGfaubgWRt3yfatqhtB+uV6/O34MNt yD7xNsr4K3NwKwUMnH7ew8cU+jkk4mJ7uW1t9uUHFPjsjHJNqvwuctzoK0FbtzbSXIOc nzfjVJuZgDuM1VxCYZIq250D3DIDgWVJzga6fyKYtJp7onW+/m7+J7J50tI2b7dzbE9O O8ZV502uxsjqrjB27VKQAftbVMYBcNI18RfhIsgqNW5lI+aauCvNcKsOVaeYaOojDQGP 0AQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=avuA3FEfFYP8n4AdVLNvjNqZjBimzlVsWhWaSAVMX7E=; b=O52AP/1uxbOaiT+PZqB5T+/XltSgTu3AD6tPj0ihwWZ+75XrRJN+ZaN1spYuerrLH0 1m6KpdUT/X/xXF/2txHbp8AvmdAeupP8+iugN/U8Xl7LrSHj+s0EfwgXVtqwVd2XgsTW V9xA4hRB4gbJIJi3+xW18B5m+m3XbAiDNaIwtuCVywhMPMDbq5T2G9qcsvetLrm1Y9MK IlBBoa2I/8YBEFIxdpIObJPkrsURQhGEwr7dPt2bksQKyxu3U4X7aWnjGnba3PCtXZ1s nM/OHA3JObrH34cMQjOCF6E87LwyFbC36yi+U4yYe7aZFgERbnFpNKEDNjoGr3rWSbyU BocA== X-Gm-Message-State: AFeK/H1P2yprK5imGf9RGIIHXwmzxilqti+Vsj1Cru77EPJ6v90BxOGWz3wwqzL5Lro7O3E9 X-Received: by 10.223.134.74 with SMTP id 10mr10741098wrw.200.1491318233050; Tue, 04 Apr 2017 08:03:53 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id t85sm18747123wmt.23.2017.04.04.08.03.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 08:03:52 -0700 (PDT) From: Thomas Monjalon To: Jacek Piasecki , Michal Jastrzebski Cc: dev@dpdk.org, harry.van.haaren@intel.com, Kuba Kozak , Tomasz Kulasek Date: Tue, 04 Apr 2017 17:03:51 +0200 Message-ID: <2943087.L4hhIMZ3WY@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1491221393-10305-2-git-send-email-jacekx.piasecki@intel.com> References: <1490910640-244285-2-git-send-email-michalx.k.jastrzebski@intel.com> <1491221393-10305-1-git-send-email-jacekx.piasecki@intel.com> <1491221393-10305-2-git-send-email-jacekx.piasecki@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] add new xstats API retrieving by id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 15:03:53 -0000 2017-04-03 14:09, Jacek Piasecki: > From: Michal Jastrzebski >=20 > Extended xstats API in ethdev library to allow grouping of stats > logically so they can be retrieved per logical grouping =E2=80=93 man= aged > by the application. > Changed existing functions rte_eth_xstats_get_names and > rte_eth_xstats_get to use a new list of arguments: array of ids > and array of values. ABI versioning mechanism was used to > support backward compatibility. > Introduced two new functions rte_eth_xstats_get_all and > rte_eth_xstats_get_names_all which keeps functionality of the > previous ones (respectively rte_eth_xstats_get and > rte_eth_xstats_get_names) but use new API inside. Sorry, I still do not understand why we should complicate the API. What is not possible with the existing API? The v1 was submitted in the last days of the proposal deadline, v2 in the last minutes of integration deadline, and v3 is submitted after the deadline. Given it is late and it is still difficult to understand the benefit, I think it won't make the release 17.05.