From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id E451D6936 for ; Mon, 3 Oct 2016 15:36:09 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id p138so151956477wmb.1 for ; Mon, 03 Oct 2016 06:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y4qybjYKKijE59csFYQ2iwqGvO+0U8kbHH/YYBpVrfU=; b=ndOLLtaGClJuV8itDGjGjrb+kwPzjU6lk996M6eVX61UgRSGpqtMmV5O63xtwm3TXJ 1XC3wHpBx2Nz8K12uns0JU1P+MZey8vjkyYx22/+oNwwDGdC1315y/WhjWHdjN9p5YJ0 HO0da/x3wEV8MWySJGK1v21azXZtWK6oWX6CrSrZzXrPg+aKYDDTNx35fJ64BlJck31B 90QzK/AyeaK7rlLmSH1r7Vj1uXRXmCjxYl4YkoOLnGbhx3Zw5lvJC6DoXKG7XGwISlco qvrKIs6tsA6ywQgHXZte3Ts0QM+9g6fm1BUwOCdOPASFh0IcRuj+MGkFeqVTsbSkKUs1 jOzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Y4qybjYKKijE59csFYQ2iwqGvO+0U8kbHH/YYBpVrfU=; b=fA0w3iP8N6Twg2WBA4plsNX1uSysiDTfRqQt2Ju5CaZ+G52ZX8PkRCzYOIwI0o/SNj 1EV7ikOrY9PxXr/xEnhEUKsfybaAsxquJhMYAwuYzN+Z4pU2QcTSXED+3ZoR+SZhVSa6 8FmJBoGPhdp7hefKPvVcoGwqrIddTOkWGc6HNYXRfXgFNV3ZIzfotYmmMUVcv+n6+0+x tNIi0BYMeoTlCBrcSTMqGd7CtBE7LFBPap/0Ayufx8EjWhkU2b2VJpQ5wzsZfYDU3gCR oBvUP2RNl4y/guYy1y7iBukeqelLl1R+YSMgGsZ5mjoY3RzRHqBlZkvZfowo4+s/epBp CajA== X-Gm-Message-State: AA6/9RkDCUqhYnghmzbCVIUbGXdUpkLl4wWZ/k+jAdGvMkxv1XvswzhDbGTUdgC420ZxSlyQ X-Received: by 10.28.29.84 with SMTP id d81mr3527421wmd.75.1475501769229; Mon, 03 Oct 2016 06:36:09 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id gg10sm34476965wjd.4.2016.10.03.06.36.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Oct 2016 06:36:08 -0700 (PDT) From: Thomas Monjalon To: Shreyansh Jain Cc: David Marchand , dev@dpdk.org, Jan Viktorin Date: Mon, 03 Oct 2016 15:36:07 +0200 Message-ID: <295101088.MT2WGLcZeq@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <4e8b181f-8d46-f4b4-3821-a19f5c622ec1@nxp.com> References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> <4e8b181f-8d46-f4b4-3821-a19f5c622ec1@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v1 0/4] Generalize PCI specific EAL function/structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Oct 2016 13:36:10 -0000 2016-10-03 11:07, Shreyansh Jain: > Hi David, > > On Friday 30 September 2016 09:01 PM, David Marchand wrote: > > On Tue, Sep 27, 2016 at 4:12 PM, Shreyansh Jain wrote: > >> (I rebased these over HEAD 7b3c4f3) > >> > >> These patches were initially part of Jan's original series on SoC > >> Framework ([1],[2]). An update to that series, without these patches, > >> was posted here [3]. > >> > >> Main motivation for these is aim of introducing a non-PCI centric > >> subsystem in EAL. As of now the first usecase is SoC, but not limited to > >> it. > >> > >> 4 patches in this series are independent of each other, as well as SoC > >> framework. All these focus on generalizing some structure or functions > >> present with the PCI specific code to EAL Common area (or splitting a > >> function to be more userful). > > > > Those patches move linux specifics (binding pci devices using sysfs) > > to common infrastucture. > > We have no proper hotplug support on bsd, but if we had some common > > code we should at least try to make the apis generic. > > > > I am not sure if I understood your point well. Just to confirm - you are > stating that the movement done in the patches might not suit BSD. > Probably you are talking about (Patch 3/4 and 4/4). > Is my understanding correct? > > So, movement to just Linux area is not enough? > I am not well versed with BSD way of doing something similar so if > someone can point it out, I can integrate that. (I will investigate it > at my end as well). > > This patchset makes the PCI->EAL movement *only* for Linux for sysfs > bind/unbind. (I should add this to cover letter, at the least). The concern is about function declarations in lib/librte_eal/common/eal_private.h We cannot be sure it can be applicable to something else than Linux. As it is implemented in Linux only, it should not be in a common header.