From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id CA3731C252;
Mon, 14 May 2018 04:00:58 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 5F47325C27;
Sun, 13 May 2018 22:00:58 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Sun, 13 May 2018 22:00:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=mzl6pfkHlLk3IMXVJFvrncEvoU
VKWhDxAkdS+lATf9Q=; b=PcPQJCMfiSgKYBHqNZ7mKwKVgOfrAV24J8jdmCRHUf
8rFVJd/MF3CIAnhlRp++4PRfYHCKhXxFdmgHIfLdDt4OlRZzUNlEjdbvLKu6e7WT
g1gsXzqIAOo9uaDulpktQeUun9ZfYSBrTipXoJZhYwg81I3fNwRlH1QiU4e0ySI2
U=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=mzl6pf
kHlLk3IMXVJFvrncEvoUVKWhDxAkdS+lATf9Q=; b=JlgIbJ7RQjgf/9JgyxJjVF
Qr2AglMD2kYqHihqNPYmaQzO6JcJlL6vPG4e2+FJN++mm9jFNWvsQ1TeLcAuMnBu
sTHI/PT3ibGwSmsPvAjHRB/4loUIh8urCvw+ECI+zZ4zeE9bQtpkRXQW4ECPgj5S
lXwcxDF5kKTHZkNXcfli8IsPJZCFFDGK2nOE3Bg29PhaRuNmaf2VDPFrL6yWEMfT
LNsi3giAzajQrgAbgH5Qu73/P9n9+omh7M/Ya4AwOBK6fzAqV0BkfeZE2QsLT5tm
tRSHiAGKih4Zdpe0zzmXXXmdp15Rwow5PI9ma4Nt2bMNd2YhvpDvYVyt2fkzLzZg
==
X-ME-Sender: <xms:2u34WiL-FmGdox-9Ip6lAIXRHdMeeNpGs_1sZawqFSm-C65FvOY1Aw>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 67758E4412;
Sun, 13 May 2018 22:00:57 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: stable@dpdk.org, "Iremonger, Bernard" <bernard.iremonger@intel.com>, "Lu,
Wenzhuo" <wenzhuo.lu@intel.com>, "Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>
Date: Mon, 14 May 2018 04:00:56 +0200
Message-ID: <2951805.7A76KTY0QU@xps>
In-Reply-To: <8CEF83825BEC744B83065625E567D7C24E0CA4F4@IRSMSX108.ger.corp.intel.com>
References: <1522235873-22042-1-git-send-email-matan@mellanox.com>
<2044227.RGsR745gvM@xps>
<8CEF83825BEC744B83065625E567D7C24E0CA4F4@IRSMSX108.ger.corp.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] app/testpmd: fix slave
port detection
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 14 May 2018 02:00:59 -0000
> > > Testpmd allows to create and control bonding devices by run time
> > > command lines using the bonding PMD API.
> > >
> > > Some bonding device slaves operations(close, stop, etc) should not be
> > > used by the application and must be managed by the bonding PMD.
> > >
> > > Thus, Testpmd manages slave flags to prevent the special operations
> > > calls and when a slave is added to bonding device by a run time
> > > command line, the flag is set.
> > >
> > > There is one more way to define the slaves for a bonding device using
> > > EAL command line and Testpmd doesn't set the slave flag in this case
> > > what causes to the special operations to be called by Testpmd.
> > >
> > > Add one more check to detect bonding slave device.
> > >
> > > Fixes: 41b05095c4d1 ("app/testpmd: fix bonding start")
> > > Fixes: 0e545d3047fe ("app/testpmd: check stopping port is not in
> > > bonding")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Matan Azrad <matan@mellanox.com>
>
> Acked-by: Bernard Iremonger <Bernard.iremonger@intel.com>
Applied, thanks