From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>,
Honnappa.Nagarahalli@arm.com, Steve Capper <steve.capper@arm.com>
Cc: stable@dpdk.org, dev@dpdk.org, nd@arm.com, david.marchand@redhat.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/3] test/rcu: fix the compiling error for armv8.2
Date: Wed, 20 Nov 2019 23:18:51 +0100 [thread overview]
Message-ID: <2954535.brShQIuEvG@xps> (raw)
In-Reply-To: <1573450911-24317-2-git-send-email-gavin.hu@arm.com>
11/11/2019 06:41, Gavin Hu:
> With "-march=armv8.2-a" specified, a compiling error generated:
> app/test/test_rcu_qsbr.c:234:10: error: comparison of integer
> expressions of different signedness: ‘unsigned int’ and ‘int’
> [-Werror=sign-compare]
>
> Fixes: b87089b0bb19 ("test/rcu: add API and functional tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Steve Capper <steve.capper@arm.com>
> ---
> --- a/app/test/test_rcu_qsbr.c
> +++ b/app/test/test_rcu_qsbr.c
> /* Skip one update */
> - if (i == (RTE_MAX_LCORE - 10))
> + if (i == (unsigned int)(RTE_MAX_LCORE - 10))
For N1 SDP, RTE_MAX_LCORE = 4.
So this test weird.
Why not using rand() to find a number between 0 and max ?
You are hiding a real failure with a forced type casting.
Please reviewers, explain why you think it is the right thing to do?
next prev parent reply other threads:[~2019-11-20 22:18 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 23:32 [dpdk-dev] [PATCH 1/2] " Gavin Hu
2019-07-31 23:32 ` [dpdk-dev] [PATCH 2/2] config: add N1SDP configuration Gavin Hu
2019-07-31 23:48 ` [dpdk-dev] [PATCH v2 0/3] add arm neoverse N1 SDP configuration Gavin Hu
2019-07-31 23:48 ` [dpdk-dev] [PATCH v2 1/3] test/rcu: fix the compiling error for armv8.2 Gavin Hu
2019-07-31 23:48 ` [dpdk-dev] [PATCH v2 2/3] config: add arm neoverse N1 SDP configuration Gavin Hu
2019-10-17 22:18 ` Ola Liljedahl
2019-10-18 5:12 ` Honnappa Nagarahalli
2019-10-18 7:23 ` Jerin Jacob
2019-10-22 21:07 ` Honnappa Nagarahalli
2019-10-23 5:03 ` Jerin Jacob
2019-10-27 21:22 ` Thomas Monjalon
2019-10-28 3:24 ` Honnappa Nagarahalli
2019-10-28 8:36 ` Thomas Monjalon
2019-10-29 5:47 ` Honnappa Nagarahalli
2019-11-11 5:06 ` Gavin Hu (Arm Technology China)
2019-07-31 23:48 ` [dpdk-dev] [PATCH v2 3/3] config: add cortex-a76 configuration Gavin Hu
2019-11-11 5:41 ` [dpdk-dev] [PATCH v3 0/3] add arm N1SDP and A76 configurations Gavin Hu
2019-11-20 22:41 ` Thomas Monjalon
2019-11-11 5:41 ` [dpdk-dev] [PATCH v3 1/3] test/rcu: fix the compiling error for armv8.2 Gavin Hu
2019-11-20 22:18 ` Thomas Monjalon [this message]
2019-11-21 11:23 ` [dpdk-dev] [dpdk-stable] " Gavin Hu (Arm Technology China)
2019-11-25 3:36 ` [dpdk-dev] [PATCH v4] test/rcu: fix build for small number of cores Gavin Hu
2019-11-25 22:40 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-11-11 5:41 ` [dpdk-dev] [PATCH v3 2/3] config: add arm neoverse N1 SDP configuration Gavin Hu
2019-11-12 4:23 ` Jerin Jacob
2019-11-14 7:55 ` Gavin Hu (Arm Technology China)
2019-11-14 8:17 ` Jerin Jacob
2019-11-11 5:41 ` [dpdk-dev] [PATCH v3 3/3] config: add cortex-a76 configuration Gavin Hu
2019-11-12 4:24 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2954535.brShQIuEvG@xps \
--to=thomas@monjalon.net \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=gavin.hu@arm.com \
--cc=nd@arm.com \
--cc=stable@dpdk.org \
--cc=steve.capper@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).