From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 49A21A00C2; Wed, 2 Nov 2022 14:17:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33B3940223; Wed, 2 Nov 2022 14:17:09 +0100 (CET) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id B3C7240041 for ; Wed, 2 Nov 2022 14:17:07 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 64A515C0099; Wed, 2 Nov 2022 09:17:07 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 02 Nov 2022 09:17:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm3; t=1667395027; x= 1667481427; bh=P2iXgzjKsYszokRcivB/HZNRDmJ80uWt0jEVOMZeKQo=; b=X vvJ0mJ+VxLP6gR40soTKkaziyljy78jRHGlTCpsdIlIH2ZCJmtZ5xCb+UfQn9Y+B M5ogoTDfZdRO+Pec5pYzaey3NpZa/pDl3d1MCjGOCI1JngxvEXrV6kg1TRrLFawe 9CCtDTXoXOr43ELqIBnadiwDjHAZDN6s+FAD8m1LQDnPM3YXMvRqQOi4VJhVal5E 26jozJ7Y4e7lt2fam9KiNR3CCJmeWTxmKKqNJ3qtuIA6kRhpG2DvhgVKgayNskuU RkTnpS5WVanEXCiWqI/w4c63OMXsoS/XwSkLXoBMmFM3w/X+Y0lpjOuv8xNkWX+Q cfsxOGltYzcKe0UqaDk4Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1667395027; x= 1667481427; bh=P2iXgzjKsYszokRcivB/HZNRDmJ80uWt0jEVOMZeKQo=; b=J OCVbkeVQf01j0hJMTrad/ibzalmqBk996zDuwYjzRzbRoYCZCBo9vd2SZLyvKj0w KdLLeMrq9HRMHbKdq0iuMX7gBMf2qL2ygmITPypiQ8hBxihW43SkpzS9519IY12O YF380uQz6kTgI4ERfC21XeHJZpTsjyFuuC9pFaLYYlDEBtwcW/B+jf/TBh4wRFEb cGSNWkRaK4Gj5oLKP/ATC5j4eZyl/DOg414AA/NUUHKPUrTAF3v7pGHkd+6d9iiA 0GpazxhI21jZ3PGEHXTXOOIQfV5Fufo+XkJTBw72wEROwSO7YhKmXN416wYTs8jz GuYJwTQQSKsuglFKzRV2Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrudejgdeglecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnheptdejieeifeehtdffgfdvleetueeffeehueejgfeuteeftddtieek gfekudehtdfgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 2 Nov 2022 09:17:05 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, valex@nvidia.com, ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru, rasland@nvidia.com, david.marchand@redhat.com, Matan Azrad , Fan Zhang , Ashish Gupta , Viacheslav Ovsiienko , Ori Kam Subject: Re: [PATCH v2 1/2] common/mlx5: fix build disabling Date: Wed, 02 Nov 2022 14:17:04 +0100 Message-ID: <2957797.WAvfycf1tz@thomas> In-Reply-To: References: <11826899.zAa99ISigo@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 02/11/2022 14:14, Bruce Richardson: > On Wed, Nov 02, 2022 at 01:29:49PM +0100, Thomas Monjalon wrote: > > 02/11/2022 13:10, Bruce Richardson: > > > On Sun, Oct 30, 2022 at 09:27:21AM +0100, Thomas Monjalon wrote: > > > > +if not ('mlx5' in common_drivers) > > > > > > While this is fine as-is, I think the more usual way for checking the > > > presence of a component in DPDK is to check dpdk_conf. In this case the > > > check would be "if not dpdk_conf.has('RTE_COMMON_MLX5')". You may want to > > > consider using that for consistency. > > > > Yes, I've forgotten this: > > > > lib_name = '_'.join(['rte', class, name]) > > dpdk_conf.set(lib_name.to_upper(), 1) > > > > Then what is the usage of this? > > > > set_variable(class + '_drivers', enabled_drivers) > > > That is used for the summary printout at the end, so we can list the > drivers enabled. > > The approach using the common_drivers works fine for this patch, so let's > keep it, since it's merged. I was just pointing out the other approach for > consistency sake. I can send a patch for consistency.