From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 3DFE32B8E for ; Fri, 22 Jul 2016 18:22:05 +0200 (CEST) Received: by mail-wm0-f51.google.com with SMTP id f65so63445315wmi.0 for ; Fri, 22 Jul 2016 09:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=Xl4ggPlBcqjSK9bTgCMGTwM3O9YLfkFSC3J7Sjwmjvc=; b=lPE/KOX9aWck4c5s0L9U90HNsTe4NGhFajxdtR+ugARWPgLBQYx2vXdIwKiO/YmBDq 3VGiiKafjh9KcveQmqjhisDAOiUA1Ex4LTPrj0+f/hE+Vl8bFWuu+gdTYJv/WX9kcgJh jbAeOlQ2pDJssBKRfH/pUgGmPlrnCkj/OGUdpKwUTlG3KRdnUZsVdGykDkPu4OsOcwGC bOJpWX2lTt313nwr3yUtxW8yZiSz6k319uYE/YqiftJd1cMCkTX8V5IQa+JgBvP/9x+M gtV/nU/bb3M0VSpC2QNs6Y8ePAsi9O2Q3FBkdAI7NH6sA1T2FKWUtvKl6uQuNNvqu4+2 2iRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=Xl4ggPlBcqjSK9bTgCMGTwM3O9YLfkFSC3J7Sjwmjvc=; b=LNcT89+Sx2UWzuMsElg0T4iQbA42TsRe8bqz7M1OBcYdpyfZtqglzX/glUj4nmMcFR J8hhy1zL0nTc0r8qaVFgrfFf9Vgim2IwpCV1QOm7JbR0tHCRvnT0fJ6bAcxB6sblYd30 Wac01od8IYJPUOlbFJsnC3CylIh0h9O7LBHyLFPhybl92yLv/DY8pVGJbdOqo9U3r1hY sGRrVGo3oqOmLSfzbzJZkio3W6fLcuaelgFimvobsKXymEW075KNuJ3LnGraHtdaG6EQ H7oW6PpHEioXWzIWXZtHwwubGilwV/bXvzAZrN9YIh9Mf3/uu9FJZgVEf98nEu4qIanL APOQ== X-Gm-Message-State: AEkoousxgTTTw/4EyMed9VSoIfnSSOjXUtnEa4/I7qtpi2mZ0S6/AUc2/efFiyx7VHws1bqc X-Received: by 10.194.77.174 with SMTP id t14mr1860836wjw.146.1469204525060; Fri, 22 Jul 2016 09:22:05 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a2sm1642345wjg.46.2016.07.22.09.22.04 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jul 2016 09:22:04 -0700 (PDT) From: Thomas Monjalon To: Michal Jastrzebski Cc: Sergio Gonzalez Monroy , bruce.richardson@intel.com, dev@dpdk.org, michalx.kobylinski@intel.com, david.marchand@6wind.com Date: Fri, 22 Jul 2016 18:22:03 +0200 Message-ID: <2958319.nnKoaMGsx5@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <95d86f88-9898-b630-0c3b-e0c8a72fdc69@intel.com> References: <1469024689-1076-1-git-send-email-michalx.k.jastrzebski@intel.com> <2746518.l5JpmnHLoW@xps13> <95d86f88-9898-b630-0c3b-e0c8a72fdc69@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] eal: fix check number of bytes from read function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Jul 2016 16:22:05 -0000 2016-07-22 17:02, Sergio Gonzalez Monroy: > On 22/07/2016 16:24, Thomas Monjalon wrote: > > 2016-07-22 16:33, Michal Jastrzebski: > >> v2: > >> -moved close(fd) just after read. > >> -when read() from fd we expect 8 bytes, so PFN_MASK_SIZE macro > >> was introduced instead sizeof(uint64_t). > >> -removed errno print when read returns less than 8 bytes > > Looks better. [...] > > Better title to explain the issue: > > mem: fix check of physical address retrieval [...] > >> + retval = read(fd, &page, sizeof(uint64_t)); > > We could use PFN_MASK_SIZE here [...] > > useless whitespace [...] > > If you and Sergio agree, I can make the minor changes before applying. > > Go for it! Applied with above changes, thanks