From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 07C4E23C; Fri, 20 Jul 2018 11:27:47 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6701621B01; Fri, 20 Jul 2018 05:27:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 20 Jul 2018 05:27:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=EK4yLjYaErvEKBY4OK5FUclPBt 6S5qXn8TNp+Ekriiw=; b=kq+rOISeZgnKyo0A2eMS++jQDZzy5BBjOHrrH4WBmE EyRe+Nd4DDTekaLkZkQt4HxqXo/DyHU2Jj7jHPAk1AftuHjBeilo4S4BAVgBncdt Rm/tx/j8qbGGT8l7yB+aiHxmga1Qwv5iNjrUBDXmxpxsjV4VmiJWHWHcnRZHKUPP E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=EK4yLj YaErvEKBY4OK5FUclPBt6S5qXn8TNp+Ekriiw=; b=YOa4YNH3Af/d3s/OW+0hor Bw9643gL/g27g0SwoZUwHA8qDkw95+nq/VmJBeZy0EZvty4BmquFL2AfJD8xER4S HlSLKgM8u3SLVYdLTod3aKTL9GuSO1e2DNw8dLOk7yrm17lxOqyiA2eEj4xb+lwF BjKZCzR4dzxmQ1uKYw47XTxS/EIMhLj3jWyvc/QhSDVScjZpgf+EcxqtzOkhHdUq 4OIik2UEwHzqE+8BdFhSgZlKsvfU2Cm+7Ub6psdHJs3gEPHRHEW2atlIVtG9C0IC N/qzg888Cwfh/M2t8+oFOCpLWod0d+ke/i9wz4NH09ex+QK/qISTtiJ598k37wUw == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (unknown [207.232.18.42]) by mail.messagingengine.com (Postfix) with ESMTPA id 563F71026A; Fri, 20 Jul 2018 05:27:45 -0400 (EDT) From: Thomas Monjalon To: Anatoly Burakov Cc: dev@dpdk.org, Andrew Rybchenko , stephen@networkplumber.org, stable@dpdk.org Date: Fri, 20 Jul 2018 11:27:43 +0200 Message-ID: <2958510.WtYFjzW1qE@xps> In-Reply-To: References: <038143a314345e9c5bf76b1287497a5c4c9f63ed.1531992860.git.anatoly.burakov@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] malloc: don't skip pad on free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jul 2018 09:27:48 -0000 19/07/2018 18:37, Andrew Rybchenko: > On 19.07.2018 12:42, Anatoly Burakov wrote: > > Previously, we were skipping erasing pad because we were > > expecting it to be freed when we were merging adjacent > > segments. However, if there were no adjacent segments to > > merge, we would've skipped erasing the pad, leaving non-zero > > memory in our free space. > > > > Fix this by including pad in the erasing unconditionally. > > > > Fixes: e43a9f52b7ff ("malloc: fix pad erasing") > > Cc: stable@dpdk.org > > > > Reported-by: Andrew Rybchenko > > > > Signed-off-by: Anatoly Burakov > > Many thanks, the patch fixes the problem I've observed. > > Tested-by: Andrew Rybchenko Applied, thanks