From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9348EA0352; Tue, 8 Feb 2022 18:42:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8088641141; Tue, 8 Feb 2022 18:42:05 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 9EAE64111B for ; Tue, 8 Feb 2022 18:42:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644342123; x=1675878123; h=message-id:date:to:references:from:subject:in-reply-to: content-transfer-encoding:mime-version; bh=/FwGDqMA0oxk6eFjZ7AexOkYuVXAV9vq/8WaY7FN144=; b=g4fPlibGS5vLBjj6v5vj2vleBus8HzSqad0GhuqnAFKA4F0i79sb7Jx1 0dL6Yo3TJ0BYKLTRZtMO3SliXoMKt123Em/TSSxRTzzFPDs1YhTs333EA SRJUVsdsUrrpbz/v6WNHuATjV0FEcPyxlCyPPJ67ShScqOnjAVVItxE3b o4z4rVtLHG9tXuKjC78pTmDAzwP8UtDcmPJPyp+vwdnMo92X2Wq6cdnwu SxNymUWeKC5wOkkBvRcOs1QeNjPXuDuEn2nQjzWrGA/SUNF40g3hu/YY7 btc4cVEHXfP343NbX7fw1R/t7F8zZJiMsKROH13eIwkMIhQ6VTIqcphKW w==; X-IronPort-AV: E=McAfee;i="6200,9189,10252"; a="247840566" X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="247840566" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2022 09:42:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,353,1635231600"; d="scan'208";a="621980591" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by FMSMGA003.fm.intel.com with ESMTP; 08 Feb 2022 09:42:02 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 8 Feb 2022 09:42:02 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 8 Feb 2022 09:42:02 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 8 Feb 2022 09:42:01 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IIJmDaNJ+CYXI3LtKgABtBY0ozslxlObF8WZqKcm8PMvNzarMae6YD2Y1jEySdONr2Dygji3tEAiEccGu3B5n5juO7dIgI+ig95IelSCjgvmCnU8vir3Z0IszmHphRCRs3nEmtNORrRkaJjcmTneAKPlJoN4SMkBn2vBQzkxiPPy8PUkUMAP6XpYU1llYdFbCkr4XXmVA2sdy1X8F+jAGOE6qOBjlLYusPf5TfmNwdDAFt2C4UIIDvj4OUsb/Mvr/R4sCCW7umJ/ZfXK11u8u8TVq/Cvt+2adaMgZ1Q0DyzsBWinv9OFreUW4Xu5iDU8rRoR2e146+sHo/uBHFjjsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RZfaGSiawxz8EXQOF0QAZN35uwU4Te9pnP7E/o86bsc=; b=BRToovpZwwm1z44dz0t6+MKwIeuwneffgPZJFNrW4/p0EP47wiL7stG2WlO0X0yB/0FdolyHg3NXz6VgjHwT4vKvBrDGa6ljsjvJxtN3ePtuQAz9lgjA1Uj4aqrWJJoaVr0HU+ca3Q/p5tL5PsQL4PSQfJmgzmn/8Mn9hPSdJsPqOim+izf9LA8JVngWWoa85jKVr7CtVUfZtZlh/EPwVwi1ocG6yHeUwavqSBRAENLzAXMDMT35NGlJJmpJV2avuVNj9TsFSchz8iKNSXFFZLwMZS4qfY3yNwp+2fQDMnc+ZCbzlSLe3xJwjCNQtJ+USgEissw0zjumaMpO/JR5bw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by DM6PR11MB2956.namprd11.prod.outlook.com (2603:10b6:5:64::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4951.18; Tue, 8 Feb 2022 17:42:00 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4951.019; Tue, 8 Feb 2022 17:41:59 +0000 Message-ID: <2959b4b4-98be-9b20-4674-8a045b443be1@intel.com> Date: Tue, 8 Feb 2022 17:41:54 +0000 Content-Language: en-US To: Jiawen Wu , References: <20220208101129.69173-1-jiawenwu@trustnetic.com> <20220208101129.69173-8-jiawenwu@trustnetic.com> From: Ferruh Yigit Subject: Re: [PATCH 7/9] net: add LED OEM support for wangxun devices X-User: ferruhy In-Reply-To: <20220208101129.69173-8-jiawenwu@trustnetic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P265CA0447.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::27) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1f2e11ed-72f2-4669-5518-08d9eb2a4efd X-MS-TrafficTypeDiagnostic: DM6PR11MB2956:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:3968; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pgbv7dqx5ZqNiB/Mfs81cawzMswp0fxnJpTYLCYC40uGZXn7OlGqtJHC/WGIT280ZU02uXmaW/6uEqe2QsFXqyHffA4C4xQPfOMopWowthIIyceyxVTD8iD03RZvWzf/ctzpcJuFiE9sDUAi4Vr7P1qOMN4MCktuD+x7bEs/JF7BIF2ao+93pp3dBdZF8OsyjD7HUcDyiiBINKvmGxlkxYMv4f4l3s42nGGSCaaidkq4LcT+G4wBZlWL6Yw3+/o+rcbKCkyvtjFJJGSl+XEQm1j8sp2zcPAMyHW7RIZ4LqLx3dpbS3mt/NWB3joim3aGE8fEsy8EQtm2CSuBqrUOfezgFW/vqzRxN1CUHI3aoSzvXsQI3EZEQXk3+pAIVOFIATAGfpyH8MsUHJ8wQHYdiSCiRTj9F2bEzQATNIqxS6b/vjvlovswjdWBdAoHbh4BcYxyp3qhSrmOxH8pcdJdRezs8L2WjLeb/5c1RfuEYmM2HA5l8rGO2zmoYwwcx3K4QflXMRyEagK3qwA5coos8jEMXjd1zufveQ2s0zMWasI4JqPiaxVIFU1Mcc4O5Ak6JoGzVxNIwR36OkZCULh4kOeYqbr8CgDqE0I4FFj945HP6AzILwc//IXWlfHZx+y3Dp8xC5b2/e9eMd8p7NIe0l8hvWLO4Bt+tmW0RCS3wpHUtmqf3+6nvoU1Wro9Hz+uzD/29mlFvaXErRtxXgXVWg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6666004)(6512007)(26005)(66556008)(6506007)(66946007)(66476007)(8936002)(2616005)(36756003)(31686004)(44832011)(38100700002)(82960400001)(4744005)(316002)(86362001)(31696002)(508600001)(8676002)(55236004)(6486002)(5660300002)(53546011)(186003)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlNWajNibVBjM2VYU3pqWGo4L21hQlNsQVppcUFoL1lVNmZ4MFF5Ukd2TDJy?= =?utf-8?B?YXBVeFFuU1QzZkxrbjZMUXR4aU1xSUVvRHNRdnluK3FjZ2N3MlZrd1JiMVRz?= =?utf-8?B?TlkxQUFQODdmWG5LK2NzaWd0MCtUcWxkaXVyczM3WHV1ckQ2SzF3S3ZtdzF4?= =?utf-8?B?c2RGcEw3eUtxUUtCWU5yTUEzV2tHa3B2Nm1leUdUYW9YdkpQbFF2eEtVMlNK?= =?utf-8?B?ZjZUcWJ1UG41TVB0c1ZkekFOMVBSNDZ4VmRiOFF2Z3duK01LYmh1aGloMVA2?= =?utf-8?B?Nmd6cWpOdU1pZEczS1NuczA2T1BoVTB1dVZMd3V1TTVaN3dvTUozaFo1UHho?= =?utf-8?B?QmEzc0xQVVAxWVNBYVAzcGFEdk03QUFQWlp4NzV1Y0RqY3pNOHFnSmJqVjNn?= =?utf-8?B?cW1nQUlZbysyVmRhUGlVbmtMaTBBU21kVnc2dndmUzRIa1pLbTR5QStjR3Zz?= =?utf-8?B?cXJ5TTBna0NwSHhNUDI4Y0ozOTNsWDFPbFgxZ0FVWTJkalBIVUh6NDgrUHNz?= =?utf-8?B?MWpOSWJaenljRU5uL0o2M2VEKzBHQXFhTmpTdG91N1F6WmpYaFFxVTJWQlNX?= =?utf-8?B?Uk82RGNYVlRDYnBTbll0ZERuRUMyMFdEUHNja0s0Y255ZjdxT1RaRzdScm1Q?= =?utf-8?B?LzBRSmZyNm1EUzkxUlUyOEZxQTZ0OHd1VU1zdkJ4UXg0ZVQ5bmxLUlk4VlZ0?= =?utf-8?B?OCtQd25pWWRkcWVPTjJxT3gzNjdscWFIYUxpWG9lTXBpcDQxWmxjMnJkSlJr?= =?utf-8?B?SmhvRVdGalQ2R2Z6NTRSVUlLeVdpRmlqUm5LcENoR2ZTNHBhMzF4YnFCdWl2?= =?utf-8?B?RjN3R202aHRLN08vWnhzTGdMVEFZazJtc0ZsNXQwYVZZM3NXcTdMUUViZ0tD?= =?utf-8?B?cE52WUhuVXdpYkxabFdSMldsbWhodTF0bjczRjAxWUNndVhZVEo3aXY0Wnlh?= =?utf-8?B?RXUrNFYvTmNZRWNMRFNiRzlKYVlPSzJkZWFaZDdFT0tOdjloMlFsMi9RZzEz?= =?utf-8?B?WklUYUdPY29sVGZabDFZSlZuRDFPVVFadTdCVGprMmZCR05adTV1SFFlUlli?= =?utf-8?B?S0dWVWxyc0FWTkRWK3pLb05yaTh2dTIyZDB1Z0tCNEFJL0dxMnozVjhsNXFE?= =?utf-8?B?NFZURzFrNG5RSFpTUVFzRk5VL2Z4OTJGeEJjWUMwdmM4czRDUkR2L2hMRTds?= =?utf-8?B?ZFFRRHBDVkFwaXJ6Um4zOTliUTk0VFRldnZ5K2dXZ203TFdselE4SkJjTkkr?= =?utf-8?B?QlRUKysxa3MwN1VvNW9vK2pmZmxoM25GVjdUd3BjdUNJTXdLZEtTLzl3ME1L?= =?utf-8?B?NEFsWlhkL3BvcUIyYnYwdTQ4bWZpQ01WVXhXUFNQSm5aNkZUQUpSRktRYmN5?= =?utf-8?B?WUEza1d4UmRZVStwNy9uZlN1OWVPVEMxdGJOaTMycElQdFdOOWc1RVh4Tit3?= =?utf-8?B?YlFONVYzWVB6aFdsa1JrQjB3UUpWcGhLRUFSY20rTEk0bHQ0YStEejJIYmJ4?= =?utf-8?B?MW10MFNsU1JsNE1mWFdHTWFFbWxNejRCbWFZUlpPS3VBSGZVSkJ0ZGxZYXM5?= =?utf-8?B?WmpXQjBObzhDZ3VPY2pTenBZWE9WNnhhMDRRWXRDVFp5Q29CODNHSDdQb0do?= =?utf-8?B?VlFmbUNQdWFwd25YempsbEJ0Ym8vQWl3amJvOWU4MkwwVVFPRU1CbXhwakVq?= =?utf-8?B?N09vSFZLZjNnRWFOKzhlSSs3SFdqMkFNSTRVcFZCckhjN3BDeWJlUUNWb3ln?= =?utf-8?B?TzlBa1J1Z2RSY05OSmozR0FXWFhvaXVLUlRmZGFtUXZnck55ODVRbVJZbGxM?= =?utf-8?B?ZW5UM2IvU2t5YTZ0MjdCdGpvbWJubXlpaGdpTmtHbE9YQlk2NWQ0RFdNMFQv?= =?utf-8?B?TTFFUkVRM3ZGdmYrcW5SWGtCb0Q4aEF1cXZQUWJDUUtPamswZURCMUo1MElX?= =?utf-8?B?R0VPcXhzdmR0bHUzamJXbGdJUGRGK0VTeVJHSHMvQnV1dHZ3dHpiSXNaSkdM?= =?utf-8?B?eEd4UVFwRW5aWGd4Y3ZHVDlrV3FPWWkwbFoxZWtFYkJmMDZUZWpqV0NoazBa?= =?utf-8?B?dUpsQXIxUlIvQ1NPdFEzTlQ3Sit5UVduRS9Zejd2QWgzNTh5elBUaktZUll2?= =?utf-8?B?K0VrOEV6ZW5ES2o1YTU3L20xelZERXl3SkVkZnlhTStmM1BvMkU2bTZGK3c4?= =?utf-8?Q?uhPkUHBW9KmOzXK9rmiwoic=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1f2e11ed-72f2-4669-5518-08d9eb2a4efd X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2022 17:41:59.8670 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9arrGj/MNRdWzDM6AdttAIkeuDeAx8Mb76W1DPInY92ldG/v+jsT2Ep2heeakP0giBHdiCDxC37p5BRk6GWT4A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2956 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/8/2022 10:11 AM, Jiawen Wu wrote: > Support custom LED OEM for ngbe and txgbe driver. > Can you please split patch for ngbe and txgbe? Btw, both drivers seems hav LED support (at least '.dev_led_on', '.dev_led_off' dev ops implemented), can you please add some details in the commit log what exactly added in this patch? Also 'doc/guides/nics/features/txgbe.ini' seems missing the 'LED' feature although dev_ops implemented, can you fix that too. > Signed-off-by: Jiawen Wu <...>