From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
[66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6AB954F94;
Sat, 27 Oct 2018 16:17:07 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id E7F3221B74;
Sat, 27 Oct 2018 10:17:06 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Sat, 27 Oct 2018 10:17:06 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=swQW6tQEIBkqYkRJu1mmEH1e4WmRh1GWKTrn4ToZYlw=; b=MUiF6kLbISu/
gUXGl7oN+JkJ5gngLT6x8GQSiM4N4DOufcWz5qCzFQKUFuSUOapaqghNtEYDmE9e
3stdjP40yJqZnGHqcrqkyuL1n74Wej02VZDduy7i+ZsLYx8B0h2HADhUQ8aF3X3+
bnIZDHtVxSf9Joh3g+tUWnKYf3Yxi0c=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm1; bh=swQW6tQEIBkqYkRJu1mmEH1e4WmRh1GWKTrn4ToZY
lw=; b=akeH5yzEMV0U9TkzV1h5AhzKeS2fr4vIkzqwMAcO+Bv9IPoYzgcVSlwKM
uSFYK5JufH99Xhxd+NeYsJzG+YOw7Ky2PZXZ0Qpl6F15qxrGsKcQ4IdK7Q9CCqwp
gKqp77j9zsK7SD+kyhQXRHWkMVjl5fc47gern3Ng4VnH1jSbQ2gkCfz4TaGAxAjT
1uFhaZWPrqKNjXCe7X48AjC6xxjSHsy237DSU68UKsNAdKq0mg56Gw0LtHUBNuiD
SyE3nCCsLDJZwwSygpXl5ivPhd0v4wAgJp08AnVAsE42BEBmJG54ttLHoByDSRov
4tY+hxHisTalDuwp9Z+2ZcyvzEg2A==
X-ME-Sender: <xms:YnPUW0y6FTeHPAnWetqpYR-YhZj6JbLzWu_7pItCUwFmeQGWyisbqA>
X-ME-Proxy: <xmx:YnPUW02lyAvYPaKsJk50ykFklq93LiD7JDgfAh-MECXqTUw28_U1Og>
<xmx:YnPUW5LvOsQLOh41Fdp4v_ErTrXqf6Kf2JmESZpA-aDNWu9AQHRpGw>
<xmx:YnPUW8yIx2plK-962YCBrYfmA25BgPff9t0Y0jGsSskI1KVMJj_-Zw>
<xmx:YnPUW_WBVU5pq6fPLnO9Ia2AE9mx3AtNkVT0gMrG3qQ4S4rsCZJpjQ>
<xmx:YnPUW0gxkwTYwuqGsB4r8O9CSpzd0-cAdiUlaG01MikmHnf2vBSaKw>
<xmx:YnPUW8YLAgvhQQ9_hYdO97dAf8eqfKiz3rcY3xd97HadmwbntxmPAg>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id 027EE102E0;
Sat, 27 Oct 2018 10:17:04 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>
Cc: stable@dpdk.org, dev@dpdk.org, Honnappa.Nagarahalli@arm.com,
steve.capper@arm.com, Ola.Liljedahl@arm.com, jerin.jacob@caviumnetworks.com,
nd@arm.com, bruce.richardson@intel.com, Justin He <justin.he@arm.com>,
konstantin.ananyev@intel.com
Date: Sat, 27 Oct 2018 16:17:11 +0200
Message-ID: <2962323.rCLS5WeyKC@xps>
In-Reply-To: <1537172244-64874-1-git-send-email-gavin.hu@arm.com>
References: <20180807031943.5331-1-gavin.hu@arm.com>
<1537172244-64874-1-git-send-email-gavin.hu@arm.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3 1/3] ring: read tail using
atomic load
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Oct 2018 14:17:07 -0000
17/09/2018 10:17, Gavin Hu:
> In update_tail, read ht->tail using __atomic_load.Although the
> compiler currently seems to be doing the right thing even without
> _atomic_load, we don't want to give the compiler freedom to optimise
> what should be an atomic load, it should not be arbitarily moved
> around.
>
> Fixes: 39368ebfc6 ("ring: introduce C11 memory model barrier option")
> Cc: stable@dpdk.org
>
> Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Reviewed-by: Steve Capper <steve.capper@arm.com>
> Reviewed-by: Ola Liljedahl <Ola.Liljedahl@arm.com>
It seems there is no consensus on this series?