Re: [dpdk-dev] [PATCH v7 01/13] eal: add option register infrastructure

[Thomas Monjalon <thomas@monjalon.net>]

24/10/2018 16:01, Gaëtan Rivet:
> Hi Kevin,
> 
> On Wed, Oct 24, 2018 at 02:27:13PM +0100, Kevin Laatz wrote:
> > This commit adds infrastructure to EAL that allows an application to
> > register it's init function with EAL. This allows libraries to be
> > initialized at the end of EAL init.
> > 
> > This infrastructure allows libraries that depend on EAL to be initialized
> > as part of EAL init, removing circular dependency issues.
> > 
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> 
> I think this is good enough,
> 
> Acked-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Yes it looks good enough.
And it compiles fine in my test.

> The only remaining issue is rte_option_init().
> Sorry I missed your previous message and did not respond in time, I
> would have opted for leaving a return value to at least be able to stop
> the init on error. It is possible to force the callback type to return
> an error value along with a string / hint describing the error. It
> should not be hard to add it later, so not blocking IMO.

I think you need to set this API as experimental.