DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Gavin Hu <gavin.hu@arm.com>
Cc: dev@dpdk.org, Olivier Matz <olivier.matz@6wind.com>,
	nd@arm.com, jerinj@marvell.com, hemant.agrawal@nxp.com,
	nipun.gupta@nxp.com, Honnappa.Nagarahalli@arm.com,
	i.maximets@samsung.com, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use
Date: Thu, 04 Jul 2019 16:42:29 +0200	[thread overview]
Message-ID: <2965897.HCpMyYeHc3@xps> (raw)
In-Reply-To: <20190329141755.ziopuvhepdi372aa@platinum>

29/03/2019 15:17, Olivier Matz:
> Hi,
> 
> On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote:
> > Currently, the flush is done by dequeuing the ring in a while loop. It is
> > much simpler to flush the queue by resetting the head and tail indices.
> > 
> > Fixes: af75078fece3 ("first public release")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > ---
> > --- a/lib/librte_ring/rte_ring_version.map
> > +++ b/lib/librte_ring/rte_ring_version.map
> > @@ -17,3 +17,10 @@ DPDK_2.2 {
> >  	rte_ring_free;
> >  
> >  } DPDK_2.0;
> > +
> > +EXPERIMENTAL {
> > +    global:
> > +
> > +	rte_ring_reset;
> > +
> > +};
> 
> To me, a static inline function does not need to be added in
> rte_ring_version.map (or is it due to a check script checking the
> __rte_experimental tag ?). I found at least one commit where it
> is not the case:
> c277b34c1b3b ("mbuf: add function returning buffer address")
> 
> There are 2 options:
> 1- remove the rte_ring_version.map part of the patch.
> 2- change the static inline function into a standard function.
> 
> I would prefer 2-, because it allows to keep an api/abi compat
> layer in the future.

There are no news about this patch.
I classify it as changes requested.




  parent reply	other threads:[~2019-07-04 14:42 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12  6:24 [dpdk-dev] [PATCH v1 0/2] add rte_ring_reset and use it to flush a ring Gavin Hu
2018-12-12  6:24 ` [dpdk-dev] [PATCH v1 1/2] ring: add rte_ring_reset api to flush the ring Gavin Hu
2018-12-12  6:24 ` [dpdk-dev] [PATCH v1 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2018-12-12  6:47 ` [dpdk-dev] [PATCH v2 0/2] add rte ring reset api and use it to flush a ring by hash Gavin Hu
2018-12-12  6:47   ` [dpdk-dev] [PATCH v2 1/2] ring: add reset api to flush the ring when not in use Gavin Hu
2018-12-12  6:47   ` [dpdk-dev] [PATCH v2 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2018-12-12 10:15     ` Bruce Richardson
2018-12-12 19:28     ` Mattias Rönnblom
2019-03-15  3:31 ` [dpdk-dev] [PATCH v7 0/2] new ring reset api and use it by hash Gavin Hu
2019-03-15  3:31   ` Gavin Hu
2019-03-15  3:31 ` [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-03-15  3:31   ` Gavin Hu
2019-03-29 14:17   ` Olivier Matz
2019-03-29 14:17     ` Olivier Matz
2019-07-04 14:42     ` Thomas Monjalon [this message]
2019-07-12  9:32       ` Gavin Hu (Arm Technology China)
2019-07-12  9:53         ` Olivier Matz
2019-07-12 11:06           ` Gavin Hu (Arm Technology China)
2019-07-12 11:48             ` Olivier Matz
2019-07-12 15:07               ` Gavin Hu (Arm Technology China)
2019-07-12 15:40                 ` Honnappa Nagarahalli
2019-07-12 16:01                   ` Gavin Hu (Arm Technology China)
2019-07-16  8:47   ` Olivier Matz
2019-07-16  9:00     ` Olivier Matz
2019-03-15  3:31 ` [dpdk-dev] [PATCH v7 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-03-15  3:31   ` Gavin Hu
2019-07-12  9:26 ` [dpdk-dev] [PATCH v8 0/2] new ring reset api and use it by hash Gavin Hu
2019-07-12  9:26 ` [dpdk-dev] [PATCH v8 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-12  9:26 ` [dpdk-dev] [PATCH v8 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-12 15:54 ` [dpdk-dev] [PATCH v9 0/2] new ring reset api and use it by hash Gavin Hu
2019-07-12 15:54 ` [dpdk-dev] [PATCH v9 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-16  9:01   ` Olivier Matz
2019-07-16 11:31     ` Olivier Matz
2019-07-16 14:03       ` Gavin Hu (Arm Technology China)
2019-07-16 15:06         ` Thomas Monjalon
2019-07-16 19:25           ` Gavin Hu (Arm Technology China)
2019-07-12 15:54 ` [dpdk-dev] [PATCH v9 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu
2019-07-16 19:23 ` [dpdk-dev] [PATCH v10 0/2] new ring reset api and use it by hash Gavin Hu
2019-07-17 17:53   ` Thomas Monjalon
2019-07-16 19:23 ` [dpdk-dev] [PATCH v10 1/2] ring: add reset API to flush the ring when not in use Gavin Hu
2019-07-16 19:23 ` [dpdk-dev] [PATCH v10 2/2] hash: flush the rings instead of dequeuing one by one Gavin Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2965897.HCpMyYeHc3@xps \
    --to=thomas@monjalon.net \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=dev@dpdk.org \
    --cc=gavin.hu@arm.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=i.maximets@samsung.com \
    --cc=jerinj@marvell.com \
    --cc=nd@arm.com \
    --cc=nipun.gupta@nxp.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).