From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DC8AA0487 for ; Thu, 4 Jul 2019 16:42:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 536A71BE4E; Thu, 4 Jul 2019 16:42:34 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 879231F28; Thu, 4 Jul 2019 16:42:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id E016221ADD; Thu, 4 Jul 2019 10:42:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 04 Jul 2019 10:42:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=PudJGcNDBD0Bif6gEJultfBUbIakKUsBxehs4WOGlJE=; b=Dx2vn5OP/0sW RsFfby4oU6GDVjuhsPXH328IwZWCzN0FWjN3rKPJzLM35Pc2kOwpHv/TB7B2FLL4 GC6biJpPDkgTBK7UA7Q9tJUnOu1g5Cu65+8krB39FevPV5ck8j+s6UkpkIAVGoxR h/+5gqKKG1VyFWXyqU6BabsHmjV3NwQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=PudJGcNDBD0Bif6gEJultfBUbIakKUsBxehs4WOGl JE=; b=Kjgg1tgrotHbXgmIWfCajUz32Gze/MdqjEYzYcHhPu5k8cBP0qvxY7rmL xfzGFV1rU8ScisxGDCzOySjkmqz+DKmPgRVnKsYsKVYhb52mPgMmnYi0d0gxCLri xuj3W6nm6VMbiJrVmBDeXIjvBvfGf1sB7Py3vBsvB+lsKCTXYWhzvVCz1sb25J84 HBhnRapMKKOzy8IeVN7ZKbcATOffV/y1m0f5IQPFiOhkP57j9XmHREvDvnWXYqSr 1J+oUNDtl35P6SZ1NlAZ1GQYhJNPuA1ifhJ/ESc8bVhOBzoEA82ZVcQIVPttVfL0 McIlhFFRWyVZetOriIwgMmwGWM9tQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrfedvgdekvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhephhhurghrmhdrtghomhenucfkphepjeejrddufeegrddvtdefrddukeegnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtne cuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6977E80059; Thu, 4 Jul 2019 10:42:30 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: dev@dpdk.org, Olivier Matz , nd@arm.com, jerinj@marvell.com, hemant.agrawal@nxp.com, nipun.gupta@nxp.com, Honnappa.Nagarahalli@arm.com, i.maximets@samsung.com, stable@dpdk.org Date: Thu, 04 Jul 2019 16:42:29 +0200 Message-ID: <2965897.HCpMyYeHc3@xps> In-Reply-To: <20190329141755.ziopuvhepdi372aa@platinum> References: <20181212062404.30243-1-gavin.hu@arm.com> <1552620686-10347-2-git-send-email-gavin.hu@arm.com> <20190329141755.ziopuvhepdi372aa@platinum> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v7 1/2] ring: add reset API to flush the ring when not in use X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/03/2019 15:17, Olivier Matz: > Hi, > > On Fri, Mar 15, 2019 at 11:31:25AM +0800, Gavin Hu wrote: > > Currently, the flush is done by dequeuing the ring in a while loop. It is > > much simpler to flush the queue by resetting the head and tail indices. > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gavin Hu > > Reviewed-by: Ruifeng Wang > > Reviewed-by: Honnappa Nagarahalli > > --- > > --- a/lib/librte_ring/rte_ring_version.map > > +++ b/lib/librte_ring/rte_ring_version.map > > @@ -17,3 +17,10 @@ DPDK_2.2 { > > rte_ring_free; > > > > } DPDK_2.0; > > + > > +EXPERIMENTAL { > > + global: > > + > > + rte_ring_reset; > > + > > +}; > > To me, a static inline function does not need to be added in > rte_ring_version.map (or is it due to a check script checking the > __rte_experimental tag ?). I found at least one commit where it > is not the case: > c277b34c1b3b ("mbuf: add function returning buffer address") > > There are 2 options: > 1- remove the rte_ring_version.map part of the patch. > 2- change the static inline function into a standard function. > > I would prefer 2-, because it allows to keep an api/abi compat > layer in the future. There are no news about this patch. I classify it as changes requested.