From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 651EB1B389 for ; Mon, 5 Feb 2018 15:20:40 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Feb 2018 06:20:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,464,1511856000"; d="scan'208";a="24951936" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by FMSMGA003.fm.intel.com with ESMTP; 05 Feb 2018 06:20:38 -0800 To: Maxime Coquelin , Stefan Hajnoczi , dev@dpdk.org Cc: Yuanhan Liu References: <20180131174651.6386-1-stefanha@redhat.com> <3e3e216c-36b1-e001-9adc-8c189a4a1886@redhat.com> From: Ferruh Yigit Message-ID: <2966bb22-1996-0bc4-f913-fda1e3acc8bd@intel.com> Date: Mon, 5 Feb 2018 14:20:37 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <3e3e216c-36b1-e001-9adc-8c189a4a1886@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 0/2] vhost: fix VIRTIO_NET_F_MQ vhost_scsi breakage X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Feb 2018 14:20:40 -0000 On 2/1/2018 12:58 PM, Maxime Coquelin wrote: > > > On 01/31/2018 06:46 PM, Stefan Hajnoczi wrote: >> These patches fix a recent regression in librte_vhost that breaks the >> vhost_scsi example application. vhost_user.c assumes all devices are vhost net >> backends when handling the VIRTIO_NET_F_MQ feature bit. The code is triggered >> by vhost scsi devices and causes virtqueues to be removed. See Patch 2 for >> details. >> >> Patch 1 puts the infrastructure in place to distinguish between the built-in >> virtio_net.c driver and generic vhost device backend usage. >> >> Patch 2 fixes the regression by handling VIRTIO_NET_F_MQ only when the built-in >> virtio_net.c driver is in use. >> >> Stefan Hajnoczi (2): >> vhost: add flag for built-in virtio_net.c driver >> vhost: only drop vqs with built-in virtio_net.c driver >> >> lib/librte_vhost/vhost.h | 3 +++ >> lib/librte_vhost/socket.c | 15 +++++++++++++++ >> lib/librte_vhost/vhost.c | 17 ++++++++++++++++- >> lib/librte_vhost/vhost_user.c | 3 ++- >> lib/librte_vhost/virtio_net.c | 14 ++++++++++++++ >> 5 files changed, 50 insertions(+), 2 deletions(-) >> > > For the series: > Reviewed-by: Maxime Coquelin Series Acked-by: Yuanhan Liu Series applied to dpdk-next-net/master, thanks.