* [dpdk-dev] [PATCH] lib: restore developer mode checks
@ 2021-05-05 14:21 David Marchand
2021-05-05 15:34 ` Bruce Richardson
0 siblings, 1 reply; 3+ messages in thread
From: David Marchand @ 2021-05-05 14:21 UTC (permalink / raw)
To: dev; +Cc: thomas, Bruce Richardson
Most of the checks on developer_mode have been accidentally dropped.
Restore them.
Fixes: 7d611e35b077 ("lib: simplify main build file")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/meson.build b/lib/meson.build
index 64a59abab6..77f363a516 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -170,7 +170,7 @@ foreach l:libraries
libname = 'rte_' + name
includes += include_directories(l)
- if is_windows and use_function_versioning
+ if developer_mode and is_windows and use_function_versioning
message('@0@: Function versioning is not supported by Windows.'.format(name))
endif
@@ -227,7 +227,7 @@ foreach l:libraries
endif
lk_deps = [version_map, def_file, mingw_map]
- if not is_windows
+ if developer_mode and not is_windows
# on unix systems check the output of the
# check-symbols.sh script, using it as a
# dependency of the .so build
--
2.23.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: restore developer mode checks
2021-05-05 14:21 [dpdk-dev] [PATCH] lib: restore developer mode checks David Marchand
@ 2021-05-05 15:34 ` Bruce Richardson
2021-05-05 20:07 ` Thomas Monjalon
0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2021-05-05 15:34 UTC (permalink / raw)
To: David Marchand; +Cc: dev, thomas
On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> Most of the checks on developer_mode have been accidentally dropped.
> Restore them.
>
> Fixes: 7d611e35b077 ("lib: simplify main build file")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Thanks.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] lib: restore developer mode checks
2021-05-05 15:34 ` Bruce Richardson
@ 2021-05-05 20:07 ` Thomas Monjalon
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-05-05 20:07 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Bruce Richardson
05/05/2021 17:34, Bruce Richardson:
> On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> > Most of the checks on developer_mode have been accidentally dropped.
> > Restore them.
> >
> > Fixes: 7d611e35b077 ("lib: simplify main build file")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> Thanks.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-05 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-05 14:21 [dpdk-dev] [PATCH] lib: restore developer mode checks David Marchand
2021-05-05 15:34 ` Bruce Richardson
2021-05-05 20:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).