From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47])
 by dpdk.org (Postfix) with ESMTP id 65ED829CD
 for <dev@dpdk.org>; Fri, 30 Sep 2016 11:33:18 +0200 (CEST)
Received: by mail-wm0-f47.google.com with SMTP id b80so32400901wme.0
 for <dev@dpdk.org>; Fri, 30 Sep 2016 02:33:18 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=6wind-com.20150623.gappssmtp.com; s=20150623;
 h=from:to:cc:subject:date:message-id:user-agent:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=hcaEYk/W9k+Y40TdjAiH21duLXkQL4RJZbdB+Xmmep4=;
 b=tebWqmUMz9uu+E//pf5a3pYetxUeYFXTUqM4zJYt7C7p9iLE8CFfyO2XeDipGivvpr
 vzUXR0Z8qNgiW1mx35bsT8jtJ7Mz6DFT9zao4MXgb7AqzC6OVWBag67lHHfSVxP9ZK4q
 TKqtvvgyK9yhB/f+Ds9A5J/UHNRkZ3SlLBk6qCRvMFHGbQvp4Z9cH3gmP3mtUerEYjQX
 3okfg/4alJJtwobLmcxB+Clo4yXgjg5DqMYoYA884/o96/D/UDpBNi9XTCYLhxWwCxEy
 /jWOjVeyqK4rTRnVzb5ue+M+xuNOhMehRuZxcwIFi4f6juJyYztY2OazyfHYtaI01Mno
 tESQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent
 :in-reply-to:references:mime-version:content-transfer-encoding;
 bh=hcaEYk/W9k+Y40TdjAiH21duLXkQL4RJZbdB+Xmmep4=;
 b=ipInqbOmE7NG+m5gcc0EWvunKezqnVQ5XhIKHkLbphGzv7bHmM0wYcQhuRumdgnpT7
 rpkRv1zcPF2mXN5cbzse6/izWqaA23pZzuspqGyMk8g+BYQUQDBuceO8OMn21UVT7h/Z
 EfC0EKKJjadLqtflE6a3Bgep2T8bZfcADRYp81SaUlnfr6hNa2UENnJyPkNjvieGRtI1
 gn+E1V5Ve3x1bLPiSg7VuQlAYuRs7eZ+xoSqovxnqzJOjJIQv5ey5xb4MySmTPao2/Sv
 VecGeIo5Qgv4R97kE0uIXYAhHS2/5pPO/y0ICTpCW20MWdiV0MlMl2DFsRAdfhXUcXv3
 QyeA==
X-Gm-Message-State: AA6/9Rm0FDAd7s8DA84Ua9XL/1SlDn1YRmlOsDk/xo6RHt4QUnlLukouuLTN2ljQ0oJ8mV1N
X-Received: by 10.28.13.66 with SMTP id 63mr2658863wmn.113.1475227997933;
 Fri, 30 Sep 2016 02:33:17 -0700 (PDT)
Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184])
 by smtp.gmail.com with ESMTPSA id 74sm3175679wmi.7.2016.09.30.02.33.16
 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Fri, 30 Sep 2016 02:33:17 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Cc: Olivier Matz <olivier.matz@6wind.com>, david.marchand@6wind.com
Date: Fri, 30 Sep 2016 11:33:16 +0200
Message-ID: <2969629.OOuc7vtRSA@xps13>
User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; )
In-Reply-To: <1474011832-29987-1-git-send-email-olivier.matz@6wind.com>
References: <1474011832-29987-1-git-send-email-olivier.matz@6wind.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] log: do not drop debug logs at compile time
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 30 Sep 2016 09:33:18 -0000

2016-09-16 09:43, Olivier Matz:
> Today, all logs whose level is lower than INFO are dropped at
> compile-time. This prevents from enabling debug logs at runtime using
> --log-level=8.
> 
> The rationale was to remove debug logs from the data path at
> compile-time, avoiding a test at run-time.
> 
> This patch changes the behavior of RTE_LOG() to avoid the compile-time
> optimization, and introduces the RTE_LOG_DP() macro that has the same
> behavior than the previous RTE_LOG(), for the rare cases where debug
> logs are in the data path.
> 
> So it is now possible to enable debug logs at run-time by just
> specifying --log-level=8. Some drivers still have special compile-time
> options to enable more debug log. Maintainers may consider to
> remove/reduce them.
> 
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

I think it is a good change.
However I'm not sure we should take it for 16.11 as it was sent late and
there is no review comment.
It is neither really a fix nor really a feature.
If there are some +1, and no opinions against, it will go in 16.11.
Note that some drivers would need some changes to fully benefit of
debug logs enabled at run-time.