From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-we0-f171.google.com (mail-we0-f171.google.com [74.125.82.171]) by dpdk.org (Postfix) with ESMTP id 4BD8736D for ; Mon, 30 Jun 2014 11:12:51 +0200 (CEST) Received: by mail-we0-f171.google.com with SMTP id q58so7857098wes.2 for ; Mon, 30 Jun 2014 02:13:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=AdAZAEtoLERe9ruCUrqkvrt7+2RGT6Uw+N2Uf6w7+n8=; b=Sg8jXB4/uVVY2UO2Du0uRvXRuovH3xe9uJhxbX57dmbTc2g7Wt1QcQuTmxc7gWCO3U oWAVsLcynZioYN/wE/JQlzQZpQub6y88epz8VJxDD9bnFAZ5plaPlTbmcO+JHSGI5Tv0 qSIUygtLSmfU84wYyfm2SHdPlEVT1k6KsfYDqNznSj2Wp68JMgc1Fbdcz5gWpld+u+6D 39Q1y1FTpxRqgR1pHFyWNr2ntOQVKbDaRyGM5LAJqJIZPje+Nsgkcmfp1GZUwdjC3AbW ERaEx1qF3oYXCML/azEsMBhaStuB7AgwWgcVeP+taTc3qwd3YTn8tXMeEzDStwJPP0+K ISrQ== X-Gm-Message-State: ALoCoQkUZ/QbpoRZm1/mRXG9InZwGKDg58/l3SlkdeVlRuW9y58Vtwq3UfccKFFFCwlHo1WCZkLd X-Received: by 10.180.9.71 with SMTP id x7mr27473306wia.61.1404119591196; Mon, 30 Jun 2014 02:13:11 -0700 (PDT) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id ey16sm29172998wid.14.2014.06.30.02.13.09 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 30 Jun 2014 02:13:10 -0700 (PDT) From: Thomas Monjalon To: Declan Doherty Date: Mon, 30 Jun 2014 11:13:04 +0200 Message-ID: <2971304.tQNlT9WS2j@xps13> Organization: 6WIND User-Agent: KMail/4.13.1 (Linux/3.14.6-1-ARCH; KDE/4.13.1; x86_64; ; ) In-Reply-To: <1404064161-26370-2-git-send-email-declan.doherty@intel.com> References: <1403864324-12022-1-git-send-email-declan.doherty@intel.com> <1404064161-26370-2-git-send-email-declan.doherty@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v11 1/5] bond: new link bonding library X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jun 2014 09:12:51 -0000 Hi Declan, 2014-06-29 18:49, Declan Doherty: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -205,6 +205,10 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) > LDLIBS += -lrte_pmd_pcap -lpcap > endif > > +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y) > +LDLIBS += -lrte_pmd_bond > +endif > + > endif This part is linking bonding library only in case of static libraries. But this library has a specific API. So it cannot be a plugin and must always be linked. That's why I suggested to split the library. Instead, I suggest to always link with bonding library. See my proposal below: --- a/mk/rte.app.mk +++ b/mk/rte.app.mk @@ -175,7 +175,12 @@ LDLIBS += -lrte_pmd_xenvirt LDLIBS += -lxenstore endif +ifeq ($(CONFIG_RTE_LIBRTE_PMD_BOND),y) +LDLIBS += -lrte_pmd_bond +endif + ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n) +# plugins (link only if static libraries) ifeq ($(CONFIG_RTE_LIBRTE_VMXNET3_PMD),y) LDLIBS += -lrte_pmd_vmxnet3_uio @@ -205,7 +210,7 @@ ifeq ($(CONFIG_RTE_LIBRTE_PMD_PCAP),y) LDLIBS += -lrte_pmd_pcap -lpcap endif -endif +endif # plugins (link only if static libraries) Adding comments to explain plugin section will be clearer. -- Thomas