* [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
@ 2015-11-13 2:50 Cunming Liang
2015-11-13 2:50 ` [dpdk-dev] [PATCH 2/2] igb: " Cunming Liang
2015-11-13 6:08 ` [dpdk-dev] [PATCH 1/2] ixgbe: " Liu, Yong
0 siblings, 2 replies; 6+ messages in thread
From: Cunming Liang @ 2015-11-13 2:50 UTC (permalink / raw)
To: dev
The vector number may change during 'dev_start'. Before enabling a new vector mapping,
it's necessary to disable/unmap the previous setting.
Fixes: 7ab8500037f6 ("ixgbe: fix VF start with PF stopped")
Reported-by: Yong Liu <yong.liu@intel.com>
Signed-off-by: Cunming Liang <cunming.liang@intel.com>
---
drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
index 19ddb52..c2be264 100644
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -1976,6 +1976,9 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
return -EINVAL;
}
+ /* disable uio/vfio intr/eventfd mapping */
+ rte_intr_disable(intr_handle);
+
/* stop adapter */
hw->adapter_stopped = 0;
ixgbe_stop_adapter(hw);
--
2.4.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error
2015-11-13 2:50 [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error Cunming Liang
@ 2015-11-13 2:50 ` Cunming Liang
2015-11-17 2:31 ` Lu, Wenzhuo
2015-11-13 6:08 ` [dpdk-dev] [PATCH 1/2] ixgbe: " Liu, Yong
1 sibling, 1 reply; 6+ messages in thread
From: Cunming Liang @ 2015-11-13 2:50 UTC (permalink / raw)
To: dev
The vector number may change during 'dev_start'. Before enabling a new vector mapping,
it's necessary to disable/unmap the previous setting.
Fixes: fe685de2b1b6 ("igb: fix VF start with PF stopped")
Reported-by: Yong Liu <yong.liu@intel.com>
Signed-off-by: Cunming Liang <cunming.liang@intel.com>
---
drivers/net/e1000/igb_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c
index 4bf4e52..c61ceab 100644
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -1092,6 +1092,9 @@ eth_igb_start(struct rte_eth_dev *dev)
PMD_INIT_FUNC_TRACE();
+ /* disable uio/vfio intr/eventfd mapping */
+ rte_intr_disable(intr_handle);
+
/* Power up the phy. Needed to make the link go Up */
e1000_power_up_phy(hw);
--
2.4.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error
2015-11-13 2:50 ` [dpdk-dev] [PATCH 2/2] igb: " Cunming Liang
@ 2015-11-17 2:31 ` Lu, Wenzhuo
2015-11-24 13:39 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Lu, Wenzhuo @ 2015-11-17 2:31 UTC (permalink / raw)
To: Liang, Cunming, dev
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Cunming Liang
> Sent: Friday, November 13, 2015 10:50 AM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error
>
> The vector number may change during 'dev_start'. Before enabling a new
> vector mapping, it's necessary to disable/unmap the previous setting.
>
> Fixes: fe685de2b1b6 ("igb: fix VF start with PF stopped")
>
> Reported-by: Yong Liu <yong.liu@intel.com>
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] igb: fix vfio ioctl SET_IRQS error
2015-11-17 2:31 ` Lu, Wenzhuo
@ 2015-11-24 13:39 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2015-11-24 13:39 UTC (permalink / raw)
To: Liang, Cunming; +Cc: dev
> > The vector number may change during 'dev_start'. Before enabling a new
> > vector mapping, it's necessary to disable/unmap the previous setting.
> >
> > Fixes: fe685de2b1b6 ("igb: fix VF start with PF stopped")
> >
> > Reported-by: Yong Liu <yong.liu@intel.com>
> > Signed-off-by: Cunming Liang <cunming.liang@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Series applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
2015-11-13 2:50 [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error Cunming Liang
2015-11-13 2:50 ` [dpdk-dev] [PATCH 2/2] igb: " Cunming Liang
@ 2015-11-13 6:08 ` Liu, Yong
2015-11-17 2:32 ` Lu, Wenzhuo
1 sibling, 1 reply; 6+ messages in thread
From: Liu, Yong @ 2015-11-13 6:08 UTC (permalink / raw)
To: Liang, Cunming, dev
Tested-by: Yong Liu <yong.liu@intel.com>
> -----Original Message-----
> From: Liang, Cunming
> Sent: Friday, November 13, 2015 10:50 AM
> To: dev@dpdk.org
> Cc: Liu, Yong; Liang, Cunming
> Subject: [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
>
> The vector number may change during 'dev_start'. Before enabling a new
> vector mapping,
> it's necessary to disable/unmap the previous setting.
>
> Fixes: 7ab8500037f6 ("ixgbe: fix VF start with PF stopped")
>
> Reported-by: Yong Liu <yong.liu@intel.com>
> Signed-off-by: Cunming Liang <cunming.liang@intel.com>
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index 19ddb52..c2be264 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -1976,6 +1976,9 @@ ixgbe_dev_start(struct rte_eth_dev *dev)
> return -EINVAL;
> }
>
> + /* disable uio/vfio intr/eventfd mapping */
> + rte_intr_disable(intr_handle);
> +
> /* stop adapter */
> hw->adapter_stopped = 0;
> ixgbe_stop_adapter(hw);
> --
> 2.4.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
2015-11-13 6:08 ` [dpdk-dev] [PATCH 1/2] ixgbe: " Liu, Yong
@ 2015-11-17 2:32 ` Lu, Wenzhuo
0 siblings, 0 replies; 6+ messages in thread
From: Lu, Wenzhuo @ 2015-11-17 2:32 UTC (permalink / raw)
To: Liu, Yong, Liang, Cunming, dev
Hi,
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Liu, Yong
> Sent: Friday, November 13, 2015 2:08 PM
> To: Liang, Cunming <cunming.liang@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
>
> Tested-by: Yong Liu <yong.liu@intel.com>
>
> > -----Original Message-----
> > From: Liang, Cunming
> > Sent: Friday, November 13, 2015 10:50 AM
> > To: dev@dpdk.org
> > Cc: Liu, Yong; Liang, Cunming
> > Subject: [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error
> >
> > The vector number may change during 'dev_start'. Before enabling a new
> > vector mapping, it's necessary to disable/unmap the previous setting.
> >
> > Fixes: 7ab8500037f6 ("ixgbe: fix VF start with PF stopped")
> >
> > Reported-by: Yong Liu <yong.liu@intel.com>
> > Signed-off-by: Cunming Liang <cunming.liang@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-11-24 13:40 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-11-13 2:50 [dpdk-dev] [PATCH 1/2] ixgbe: fix vfio ioctl SET_IRQS error Cunming Liang
2015-11-13 2:50 ` [dpdk-dev] [PATCH 2/2] igb: " Cunming Liang
2015-11-17 2:31 ` Lu, Wenzhuo
2015-11-24 13:39 ` Thomas Monjalon
2015-11-13 6:08 ` [dpdk-dev] [PATCH 1/2] ixgbe: " Liu, Yong
2015-11-17 2:32 ` Lu, Wenzhuo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).