From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1E5731B864 for ; Fri, 19 Apr 2019 11:08:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66CF921ED6; Fri, 19 Apr 2019 05:07:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 05:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=awgwd0n0PTa8QnBsxeKlhrTNPjmlh3tlRQTE2AOwEeM=; b=OdgdQhgtvI/R MsYky3oA5T8q7TdGMX217EbFUebMCdrMuDd53+2BYNJRsN4xEEJQfHdHnhOsIqQ/ Zf08xl8EKTuHOkZQxq7IvBOTUjD91hT1xIPWan9O+zFag6XnHOYJfflckRAYdNj3 dBDzBn2AzlXz0EM1XsyDXxtx06/TkwM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=awgwd0n0PTa8QnBsxeKlhrTNPjmlh3tlRQTE2AOwE eM=; b=fwlosV3AUNvPP5cLGa9MwuIhJjxDbKF9863+kUqi83eJbFgPozE54y/WD NW/AeRzeJtFPFIGejX/h1BiT65mWXfgGS4XR/7ptbPEl7dTTkgJc/8W7nGYoct0C ujq+Mmg0AqnLC38/N8kg5kWCkrY/UWzDzD+XaINwSe5QLDFbKeG/cwfbsgdcDbnW mGCSis2N+ju2N2Cvs1deGDKzyLlJUKCczcP0c8efLVHfpVWR2/qaXzb7yZ9+bgSw b8bIOQ+8HV8QVb3Fhlf8u+eGocmLU44+4gt+C7dNlvn6z3o7wOSlibZmwjNiT5P0 ctO0d4sPANla8olo4nQPgGKaVRYzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B2EF4103CE; Fri, 19 Apr 2019 05:07:56 -0400 (EDT) From: Thomas Monjalon To: "Cel, TomaszX" , "Jozwiak, TomaszX" Cc: Yongseok Koh , "dev@dpdk.org" , "Trahe, Fiona" , ferruh.yigit@intel.com Date: Fri, 19 Apr 2019 11:07:55 +0200 Message-ID: <2973149.5co8HxeFWj@xps> In-Reply-To: <825F643C-86B8-4A5D-934A-E074DE1458C1@mellanox.com> References: <1550223873-17119-3-git-send-email-tomaszx.jozwiak@intel.com> <825F643C-86B8-4A5D-934A-E074DE1458C1@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Apr 2019 09:08:00 -0000 There are some variables declared in the middle of the function, and one (i) is declared twice with two different types. Tomasz and Tomasz, are you working on it urgently please? 19/04/2019 00:42, Yongseok Koh: > Hi, >=20 > I'm seeing compile error. > Isn't it due to this patch? >=20 > $ gcc --version > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) >=20 >=20 > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o [...] > ../app/test/test_compressdev.c: In function =E2=80=98test_compressdev_def= late_stateless_dynamic_big=E2=80=99: > ../app/test/test_compressdev.c:1992:16: error: conflicting types for =E2= =80=98i=E2=80=99 > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > ^ > ../app/test/test_compressdev.c:1949:11: note: previous definition of =E2= =80=98i=E2=80=99 was here > uint16_t i =3D 0; > ^ > ../app/test/test_compressdev.c:1992:2: error: =E2=80=98for=E2=80=99 loop = initial declarations are only allowed in C99 mode > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > ^ > ../app/test/test_compressdev.c:1992:2: note: use option -std=3Dc99 or -st= d=3Dgnu99 to compile your code > ../app/test/test_compressdev.c:1996:19: warning: assignment from incompat= ible pointer type [enabled by default] > int_data.buf_idx =3D &i; > ^ > [1501/1523] Generating igb_uio with a custom command. > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > CC [M] /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/lin= ux/igb_uio/igb_uio.o > Building modules, stage 2. > MODPOST 1 modules > make[1]: Warning: File `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/bu= ild/kernel/linux/igb_uio/igb_uio.mod.c' has modification time 0.0096 s in t= he future > CC /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/lin= ux/igb_uio/igb_uio.mod.o > LD [M] /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/lin= ux/igb_uio/igb_uio.ko > make[1]: warning: Clock skew detected. Your build may be incomplete. > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64' >=20 >=20 > Thanks, > Yongseok [...] > >> +static int > >> +test_compressdev_deflate_stateless_dynamic_big(void) > >> +{ > >> + struct comp_testsuite_params *ts_params =3D &testsuite_params; > >> + uint16_t i =3D 0; > >> + int ret =3D TEST_SUCCESS; > >> + const struct rte_compressdev_capabilities *capab; > >> + char *test_buffer =3D NULL; > >> + > >> + capab =3D rte_compressdev_capability_get(0, > >> RTE_COMP_ALGO_DEFLATE); > >> + TEST_ASSERT(capab !=3D NULL, "Failed to retrieve device capabilities= "); > >> + > >> + if ((capab->comp_feature_flags & > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) =3D=3D 0) > >> + return -ENOTSUP; > >> + > >> + if ((capab->comp_feature_flags & > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) =3D=3D 0) > >> + return -ENOTSUP; > >> + > >> + test_buffer =3D rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0); > >> + if (test_buffer =3D=3D NULL) { > >> + RTE_LOG(ERR, USER1, > >> + "Can't allocate buffer for big-data\n"); > >> + return TEST_FAILED; > >> + } > >> + > >> + struct interim_data_params int_data =3D { > >> + (const char * const *)&test_buffer, > >> + 1, > >> + NULL, > >> + &ts_params->def_comp_xform, > >> + &ts_params->def_decomp_xform, > >> + 1 > >> + }; > >> + > >> + struct test_data_params test_data =3D { > >> + RTE_COMP_OP_STATELESS, > >> + SGL_BOTH, > >> + ZLIB_DECOMPRESS, > >> + 0, > >> + 1 > >> + }; > >> + > >> + ts_params->def_comp_xform->compress.deflate.huffman =3D > >> + > >> RTE_COMP_HUFFMAN_DYNAMIC; > >> + > >> + /* fill the buffer with data based on rand. data */ > >> + srand(BIG_DATA_TEST_SIZE); > >> + for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > >> + test_buffer[i] =3D (uint8_t)(rand() % ((uint8_t)-1)) | 1; > >> + > >> + test_buffer[BIG_DATA_TEST_SIZE-1] =3D 0; > >> + int_data.buf_idx =3D &i; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id CE77CA00E6 for ; Fri, 19 Apr 2019 11:08:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A13A01BA90; Fri, 19 Apr 2019 11:08:01 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 1E5731B864 for ; Fri, 19 Apr 2019 11:08:00 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 66CF921ED6; Fri, 19 Apr 2019 05:07:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 19 Apr 2019 05:07:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=awgwd0n0PTa8QnBsxeKlhrTNPjmlh3tlRQTE2AOwEeM=; b=OdgdQhgtvI/R MsYky3oA5T8q7TdGMX217EbFUebMCdrMuDd53+2BYNJRsN4xEEJQfHdHnhOsIqQ/ Zf08xl8EKTuHOkZQxq7IvBOTUjD91hT1xIPWan9O+zFag6XnHOYJfflckRAYdNj3 dBDzBn2AzlXz0EM1XsyDXxtx06/TkwM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=awgwd0n0PTa8QnBsxeKlhrTNPjmlh3tlRQTE2AOwE eM=; b=fwlosV3AUNvPP5cLGa9MwuIhJjxDbKF9863+kUqi83eJbFgPozE54y/WD NW/AeRzeJtFPFIGejX/h1BiT65mWXfgGS4XR/7ptbPEl7dTTkgJc/8W7nGYoct0C ujq+Mmg0AqnLC38/N8kg5kWCkrY/UWzDzD+XaINwSe5QLDFbKeG/cwfbsgdcDbnW mGCSis2N+ju2N2Cvs1deGDKzyLlJUKCczcP0c8efLVHfpVWR2/qaXzb7yZ9+bgSw b8bIOQ+8HV8QVb3Fhlf8u+eGocmLU44+4gt+C7dNlvn6z3o7wOSlibZmwjNiT5P0 ctO0d4sPANla8olo4nQPgGKaVRYzg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrfeejgddutdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthhqredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B2EF4103CE; Fri, 19 Apr 2019 05:07:56 -0400 (EDT) From: Thomas Monjalon To: "Cel, TomaszX" , "Jozwiak, TomaszX" Cc: Yongseok Koh , "dev@dpdk.org" , "Trahe, Fiona" , ferruh.yigit@intel.com Date: Fri, 19 Apr 2019 11:07:55 +0200 Message-ID: <2973149.5co8HxeFWj@xps> In-Reply-To: <825F643C-86B8-4A5D-934A-E074DE1458C1@mellanox.com> References: <1550223873-17119-3-git-send-email-tomaszx.jozwiak@intel.com> <825F643C-86B8-4A5D-934A-E074DE1458C1@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/1] test/compress: add max mbuf size test case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190419090755.k_bXpiMnHG6_n_IKEaBjMc2v-J1QRtE8rOLpf8Z0BHc@z> There are some variables declared in the middle of the function, and one (i) is declared twice with two different types. Tomasz and Tomasz, are you working on it urgently please? 19/04/2019 00:42, Yongseok Koh: > Hi, >=20 > I'm seeing compile error. > Isn't it due to this patch? >=20 > $ gcc --version > gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-28) >=20 >=20 > FAILED: app/test/app@test@@dpdk-test@exe/test_compressdev.c.o [...] > ../app/test/test_compressdev.c: In function =E2=80=98test_compressdev_def= late_stateless_dynamic_big=E2=80=99: > ../app/test/test_compressdev.c:1992:16: error: conflicting types for =E2= =80=98i=E2=80=99 > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > ^ > ../app/test/test_compressdev.c:1949:11: note: previous definition of =E2= =80=98i=E2=80=99 was here > uint16_t i =3D 0; > ^ > ../app/test/test_compressdev.c:1992:2: error: =E2=80=98for=E2=80=99 loop = initial declarations are only allowed in C99 mode > for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > ^ > ../app/test/test_compressdev.c:1992:2: note: use option -std=3Dc99 or -st= d=3Dgnu99 to compile your code > ../app/test/test_compressdev.c:1996:19: warning: assignment from incompat= ible pointer type [enabled by default] > int_data.buf_idx =3D &i; > ^ > [1501/1523] Generating igb_uio with a custom command. > make: Entering directory `/usr/src/kernels/3.10.0-862.el7.x86_64' > CC [M] /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/lin= ux/igb_uio/igb_uio.o > Building modules, stage 2. > MODPOST 1 modules > make[1]: Warning: File `/auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/bu= ild/kernel/linux/igb_uio/igb_uio.mod.c' has modification time 0.0096 s in t= he future > CC /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/lin= ux/igb_uio/igb_uio.mod.o > LD [M] /auto/mtiswgwork/yskoh/git/mellanox/dpdk.org-2/build/kernel/lin= ux/igb_uio/igb_uio.ko > make[1]: warning: Clock skew detected. Your build may be incomplete. > make: Leaving directory `/usr/src/kernels/3.10.0-862.el7.x86_64' >=20 >=20 > Thanks, > Yongseok [...] > >> +static int > >> +test_compressdev_deflate_stateless_dynamic_big(void) > >> +{ > >> + struct comp_testsuite_params *ts_params =3D &testsuite_params; > >> + uint16_t i =3D 0; > >> + int ret =3D TEST_SUCCESS; > >> + const struct rte_compressdev_capabilities *capab; > >> + char *test_buffer =3D NULL; > >> + > >> + capab =3D rte_compressdev_capability_get(0, > >> RTE_COMP_ALGO_DEFLATE); > >> + TEST_ASSERT(capab !=3D NULL, "Failed to retrieve device capabilities= "); > >> + > >> + if ((capab->comp_feature_flags & > >> RTE_COMP_FF_HUFFMAN_DYNAMIC) =3D=3D 0) > >> + return -ENOTSUP; > >> + > >> + if ((capab->comp_feature_flags & > >> RTE_COMP_FF_OOP_SGL_IN_SGL_OUT) =3D=3D 0) > >> + return -ENOTSUP; > >> + > >> + test_buffer =3D rte_malloc(NULL, BIG_DATA_TEST_SIZE, 0); > >> + if (test_buffer =3D=3D NULL) { > >> + RTE_LOG(ERR, USER1, > >> + "Can't allocate buffer for big-data\n"); > >> + return TEST_FAILED; > >> + } > >> + > >> + struct interim_data_params int_data =3D { > >> + (const char * const *)&test_buffer, > >> + 1, > >> + NULL, > >> + &ts_params->def_comp_xform, > >> + &ts_params->def_decomp_xform, > >> + 1 > >> + }; > >> + > >> + struct test_data_params test_data =3D { > >> + RTE_COMP_OP_STATELESS, > >> + SGL_BOTH, > >> + ZLIB_DECOMPRESS, > >> + 0, > >> + 1 > >> + }; > >> + > >> + ts_params->def_comp_xform->compress.deflate.huffman =3D > >> + > >> RTE_COMP_HUFFMAN_DYNAMIC; > >> + > >> + /* fill the buffer with data based on rand. data */ > >> + srand(BIG_DATA_TEST_SIZE); > >> + for (uint32_t i =3D 0; i < BIG_DATA_TEST_SIZE - 1; ++i) > >> + test_buffer[i] =3D (uint8_t)(rand() % ((uint8_t)-1)) | 1; > >> + > >> + test_buffer[BIG_DATA_TEST_SIZE-1] =3D 0; > >> + int_data.buf_idx =3D &i;