From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5842BA0559; Tue, 17 Mar 2020 10:24:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7A6F1C069; Tue, 17 Mar 2020 10:24:19 +0100 (CET) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BBCE51C025; Tue, 17 Mar 2020 10:24:18 +0100 (CET) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 23D6E5C01B9; Tue, 17 Mar 2020 05:24:18 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Tue, 17 Mar 2020 05:24:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=beFRNoStwdW7GqRVsBtwy1VgPSY8tDdO4hxa8NvKYCI=; b=pezwgM/CL7F4 vBodAdMZum6klzBs2JkZJ2sAb8LQ8zyFVZbtLND0U6gTfYiA589P9en0RDImDuJi MXVJm72wlvx0Q5E29CaEhVapi4E5iwVU6gO30Fy5QrgJ5uGs9ZABnW1lEdbP5uiJ WAsAnqAxOwWy6EwmqApiMXF31it9mXU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=beFRNoStwdW7GqRVsBtwy1VgPSY8tDdO4hxa8NvKY CI=; b=bTnqsR828ItR2Mi4+3aSp4CcpR8nOtTcJ5WqlXgPmTOpXOTdtE/vUo4OQ NieI8M3ASLgVgdKwkmWhr1KsJF02P/nkbfP8+hYdPyeuXqQv1I1F22RKzZvNrJzr 4rCyujl/GokRIgvdEm30CYuqKtwLk8FQ5U0dV8PluTBZh4FuqrZW76rtaRsUGO3s SYfF76DSXp2Y1/pAdNANMsWobr3CTfYKw9wDyTntzDi725KT1/BqQUc/jOQTde2Q JRd9hQ0BmBryMsIK/YwmZ1MtRRyCxHmqR0QQZC9gPpFdB9OdDupixXt9dGNlUX/U AgR0Dey3+0qisUOSL5+WHk+Dl71QA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudefhecutefuodetggdotefrodftvfcurf hrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecuuegr ihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjug hrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfo ohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffohhmrg hinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhu shhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmh honhhjrghlohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 67F523280063; Tue, 17 Mar 2020 05:24:17 -0400 (EDT) From: Thomas Monjalon To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, david.marchand@redhat.com Date: Tue, 17 Mar 2020 10:24:15 +0100 Message-ID: <2973777.NnENhoQgcM@xps> In-Reply-To: <20200316163705.5675-1-bruce.richardson@intel.com> References: <20200316163705.5675-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] pci: fix missing off_t define on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/03/2020 17:37, Bruce Richardson: > When removing the extra headers from rte_pci.h stdlib should have been > removed instead of stdio, since off_t is missing for BSD builds when just > including stdlib.h > > Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file") > Cc: stable@dpdk.org > > Signed-off-by: Bruce Richardson Sorry, I missed the failure seen in the community lab: http://mails.dpdk.org/archives/test-report/2020-March/120862.html Note: we should always wait for tests to be run. Thank you for the quick fix. Applied, thanks