From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f178.google.com (mail-wr0-f178.google.com [209.85.128.178]) by dpdk.org (Postfix) with ESMTP id 1B5A1CFD6 for ; Thu, 6 Apr 2017 09:11:24 +0200 (CEST) Received: by mail-wr0-f178.google.com with SMTP id w11so44136382wrc.3 for ; Thu, 06 Apr 2017 00:11:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=GS85o0Fp9Jw0sC4dPVmPscuhvgg4rFbjHIabocnauts=; b=bwtjmM82p7ngCV0NSDOeMbd1CdTJPHk1B4Z2CY/f1VmJUm+pT4fkE7XWRPDXGQLIEq vLoiPLI68Hs+IUwmTFiXhpiedPwZ03nmvNZ65WhM6Qo/ycOIvdfgYHAyV401ymjx66l7 ivyxDmE6t7QlumHP2CbctPAGDfRXPCDE+ZnRzNB8hbrGtK3mWtKwCqofjcEOkIl3oGuh 41rn986dbRkNuhVxs+N5QZsJrRRj+Y9GIscV0NNNCn1Vsrx95zBYqc/sT9OZXP9HjZvs Mww1aK+c46jX4GwNQvA/gkAjKemQqJCABTxTaU76c28dK55Hcf9YlthS6BoKECRdGNSx 3iUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=GS85o0Fp9Jw0sC4dPVmPscuhvgg4rFbjHIabocnauts=; b=Tacas8OceUfL6gmUBPzcIHo0itugXUtmJQsg+ZCcNCdoCHnDO5uHpb6jjgldhhYrSn 0fFU+Hluynf3nz4+p3EAF0CtOOtTLKqvXm7U6rQHNJXhOjK+GlbYLL+hvvSdCQNaeL2/ 4aHZKI9/I3apDR7CjISZ8EyEQC3Yu07jSjIx3/AXT7j6IPyD8TOr7fkoc0DD9eROZTcT kxCfeePM4vRKGFqZHwAD3ijp1YVaQQOPN8FZoya7sW1N2Xi9nOhE1FqVaL9Pe3N/zXgw cd39PA3m6Z0V5JiEcbmDKOHi/K+U2UeMXJvk5neqEKVqz0kv1Xeu2EnzndQQNAIF8+pd pwTw== X-Gm-Message-State: AFeK/H0z4AZjSn3fNx9LGU3h2NntD6A1lYukE6rRttR9T0S6I7fr7AUF3u5tMHL9wGHqhLW6 X-Received: by 10.28.24.79 with SMTP id 76mr22644837wmy.111.1491462684560; Thu, 06 Apr 2017 00:11:24 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id a66sm921774wrc.58.2017.04.06.00.11.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 06 Apr 2017 00:11:23 -0700 (PDT) From: Thomas Monjalon To: "Zhao1, Wei" Cc: "Mcnamara, John" , dev@dpdk.org, "Lu, Wenzhuo" Date: Thu, 06 Apr 2017 09:11:22 +0200 Message-ID: <2978037.PdPlo8nOdn@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1490866456-52241-1-git-send-email-wei.zhao1@intel.com> <2969664.trJitADFWx@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 1/3] lib/librte_ether: add support for port reset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 07:11:25 -0000 2017-04-06 02:57, Zhao1, Wei: > > /** > > > + * Reset an ethernet device when it's not working. One scenario is, > > > + after PF > > > + * port is down and up, the related VF port should be reset. > > > + * The API will stop the port, clear the rx/tx queues, re-setup the > > > + rx/tx > > > + * queues, restart the port. > > > > s/The API/This function/ > > > > Please explain exactly the responsibility of this function, and how it is > > different from calling stop/configure/start. > > In this reset feature, reset function can do the calling stop/configure/start process, but also > It can also do some restore work for the port, for example, it can restore the added parameters > of vlan, mac_addrs, promisc_unicast_enabled falg and promisc_multicast_enabled flag. > Maybe , I should add this explanation in the patch comments or function comments? Yes it must be explain in the doxygen part of the function.