From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D93AA0C43; Tue, 16 Nov 2021 11:25:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4DEA1411CE; Tue, 16 Nov 2021 11:25:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 1660841190 for ; Tue, 16 Nov 2021 11:25:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637058319; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RdSzZnm0tXpxRQGrsZi+8wNb7Tq7biTrrZOx13LOSXU=; b=FrIh21Hn8daxh0DIP+tHhLdRO94b2zqhAVdQLeSSJXRpcTEGWPBRLiLmp94oZpNGIaZtIf Ym7lwcNuKZ6hHmIaII3qhxcJZSDT0iPLwkaKwyvF70NBK80dGUaFTnSIo3BP0GsE+NwSGB KfzpF6F5JCI72qiW6dH3jBWkuyueT3M= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-48-xClU8wz9OLemojyXyhc7Hg-1; Tue, 16 Nov 2021 05:25:16 -0500 X-MC-Unique: xClU8wz9OLemojyXyhc7Hg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 235B01006AA4; Tue, 16 Nov 2021 10:25:15 +0000 (UTC) Received: from [10.39.208.9] (unknown [10.39.208.9]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 86AE11017CE4; Tue, 16 Nov 2021 10:25:14 +0000 (UTC) Message-ID: <29790f97-0ab5-44fb-9972-4b3d921d086b@redhat.com> Date: Tue, 16 Nov 2021 11:25:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH] examples/vhost: fix port init failure in mergeable mode To: Chenbo Xia , dev@dpdk.org References: <20211104051102.7155-1-chenbo.xia@intel.com> From: Maxime Coquelin In-Reply-To: <20211104051102.7155-1-chenbo.xia@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/4/21 06:11, Chenbo Xia wrote: > When the example starts in mergeable mode with an i40e port, > it fails to launch because the examples use default mtu MAX_MTU > to configure ethdev. The root cause is some devices have Ethernet > frame overhead and then MAX_MTU will be larger than device's max > mtu, so the ethdev configure will fail. > > This patch checks the device's max mtu before setting the ethdev > configuration. If the device has a max mtu, use that value to > configure. > > Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") > > Signed-off-by: Chenbo Xia > Reported-by: Xingguang He > --- > examples/vhost/main.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime