From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BA7DA0553; Sun, 26 Jun 2022 12:16:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAE5641144; Sun, 26 Jun 2022 12:16:30 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by mails.dpdk.org (Postfix) with ESMTP id 0802041141; Sun, 26 Jun 2022 12:16:29 +0200 (CEST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 3B3DB3200645; Sun, 26 Jun 2022 06:16:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Sun, 26 Jun 2022 06:16:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1656238585; x= 1656324985; bh=dnjiJ3bGblKrbGOP7UDDDYag2XjdwHM2ZQKqtnE6rgo=; b=i vHN+RWX+DxgSw4cPek5MOdxxtocJKRJFfyLmu9Nbm5X9GhfeoM6tFBBkOjn2y+TS MFnVIqwA5Kuc29lE7CJhmMpbaY2+QG/HUeFb/lWsKWzWJdcHT82MKdxXPlStZSfh W653UvszGnsIq8LLnhWM9lmPOvuV/1hkGiCYy4t6pD+ZaYAzvhjAzpJ5Win/MSBZ G1ojZN0+minp9bFKbYS1EwP4KfGSrpOcpFADGh+nb5vFTSjALX/wLhxpfF8LiWGq qwWhGzz9LfjneGd1MOLyE9514EYipCBiCU0x/WSF0eKfPXhj9u9VNKQqfsSbX/d2 pDDBXVmiqlgSl3wXJOzgQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1656238585; x= 1656324985; bh=dnjiJ3bGblKrbGOP7UDDDYag2XjdwHM2ZQKqtnE6rgo=; b=p vmGU7l/QsTqGHsVKsz9XCQW9MVF6OA1kwwaBI8kELwKntAlQzluKmZynSMkYHUig aAoy6WTQZuSqtFFzrSuvNmsyYP1XeMPRZyOdeeZeee3xpPhLwC13/bnTkQmybY9C Zd5oY+Sw9ZyT7+iUXFq1osRN6401Ja5NbW9awdEI39iHeTwWhkEZ7TdLjdiXLFHr 5aaaKtujN87CBBaMvqYVr+WJdgeDvocAkM3l306ErpV4Cica1jx2bB9/olToe+er Z+rcxhnOcKLwdvtFOOK/7OEp4mAmBqefrI5thlrzGmCktfkvNo76wAgqN87xOnvq H2KUz01SDJcHf0X2SY9pA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrudegfedgvdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedtjeeiieefhedtfffgvdelteeufeefheeujefgueetfedttdei kefgkeduhedtgfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 26 Jun 2022 06:16:24 -0400 (EDT) From: Thomas Monjalon To: "Huang, Wei" Cc: "dev@dpdk.org" , "nipun.gupta@nxp.com" , "hemant.agrawal@nxp.com" , stable@dpdk.org, "stable@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" , "Zhang, Tianfei" Subject: Re: [PATCH] raw/ifpga: avoid potential integer overflow Date: Sun, 26 Jun 2022 12:16:22 +0200 Message-ID: <2981798.izSxrag8PF@thomas> In-Reply-To: References: <1655953900-26199-1-git-send-email-wei.huang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org > > Expression "tx_chunks * ctx->dma_buf_size" in dma_fpga_to_fpga() is evaluated > > using 32-bit arithmetic, which would overflow potentially. Change tx_chunks to > > type "uint64_t" to avoid such issue. > > > > Coverity issue: 379203 > > Fixes: 7d63899a5c19 ("raw/ifpga: add N3000 AFU driver") > > > > Signed-off-by: Wei Huang > > It looks good for me. > > Acked-by: Tianfei Zhang Applied, thanks.