From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id 480222B98 for ; Tue, 22 Mar 2016 17:16:38 +0100 (CET) Received: by mail-wm0-f45.google.com with SMTP id r129so100863186wmr.1 for ; Tue, 22 Mar 2016 09:16:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=ogUL8l2+viPfMWC025oMOHpHM8aSPwE1Iad5NGTOJys=; b=qRcSbDYF0XNN+AXh6FSwqFu9bvIRwBFnW7M1fiIAiGZH3izyWNK3s0gcnVCVoYGLpB L+UkrqHkoxvVTszv0yzkj48Npkx9je9aY8MoeabM2gw+F+xrvCFB1CnWia3VeNOHF5z1 jJ3ISnFoS7BNXRUTGXrrKCdrwVzHuo5Ma1Fu/QLZbEwolBXCjlnZpR5v8UpAZhICfQBF kG0M9Q4BPPXmQzHmthGaloIrmhpNIEUJOVVPpT3/OFUi60PNJ60oCFcWd0GC16lHdEXi jDtW4glv11DPbOv7fHAhk8thoUGd8df5USVsiK4aNTHcInVPBcFsy1yE5p0EYWl8/rZL w+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=ogUL8l2+viPfMWC025oMOHpHM8aSPwE1Iad5NGTOJys=; b=FhtUQmv1YtOxjpT+1MD6i1W9XeGT+kMwU8dqWUsvI+2oUqsBD/inLsjeHF+WT0atnS uPkJrEq30jjdurNZzyMHup4cWkThnVrK4xy6RfOqNlWp27FoEiu7Rn26SLZUcM3NzqlM G28kkf4QAE2ZaYabLoobVYJ18XLQkzlCh20Ok32Eml97DYfwmBPXls3HrGz5uvoSQCuU wt3Hc/39fYhVwFB06bY3MvgmoT1DOQ4yvMJ3Fxnc1jwl/TN1gzQD7QEuiVHLWmD0TyNW sJs2zG/ZhwD7WBg87LJVKRuK4YRPBVMoJ21RRT7msysmK1M4yho/9gQpGdx98/ay/7q5 Lp5A== X-Gm-Message-State: AD7BkJJMDCqLfd7XxJtWNV+/HA4bi2XHTGcibE+fs20nbKEYaHftXFQkAgPGl0AhtYsxBBap X-Received: by 10.28.234.201 with SMTP id g70mr20891974wmi.40.1458663398098; Tue, 22 Mar 2016 09:16:38 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id a1sm15342770wje.43.2016.03.22.09.16.37 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Mar 2016 09:16:37 -0700 (PDT) From: Thomas Monjalon To: Christian Ehrhardt Cc: dev@dpdk.org, bruce.richardson@intel.com, olivier.matz@6wind.com Date: Tue, 22 Mar 2016 17:14:58 +0100 Message-ID: <2983189.UJ094KPj7K@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1458569175-8742-1-git-send-email-christian.ehrhardt@canonical.com> References: <1458131629-21925-1-git-send-email-christian.ehrhardt@canonical.com> <1458569175-8742-1-git-send-email-christian.ehrhardt@canonical.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 0/5] lpm allocation fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 16:16:38 -0000 2016-03-21 15:06, Christian Ehrhardt: > Poking a bit on autotest revealed a few shortcomings in the lpm allocation path. > Thanks to the feedback to the first revision of the patches here v2. > Also Oliver Matz spotted similar issues and made me aware - thanks! > Integrating them revealed even more use after free / leak issues. > > *updates in v4* > - re-removing the { } on single line ifs accidentially droped in v3 > - adding the ack of Oliver Matz > > *updates in v3* > - lpm create/free path for v20 and v1604 got the same fixes that were > already identified for lpm6 before > > *updates in v2* > - lpm/lpm6 patches split > - following dpdk coding guidelines regarding single line if's > - adding singed-off and acked-bys gathered so far > - combine all three related patches in one series > > Christian Ehrhardt (5): > lpm6: fix use after free of lpm in rte_lpm6_create > lpm6: fix missing free of rules_tbl and lpm > lpm: fix missing free of lpm > lpm: fix use after free of lpm in rte_lpm_create* > lpm: fix missing free of rules_tbl and lpm in rte_lpm_free* Applied, thanks