From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
[66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 6A8073B5
for <dev@dpdk.org>; Mon, 1 May 2017 23:34:15 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id ECF1920972;
Mon, 1 May 2017 17:34:14 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
by compute1.internal (MEProxy); Mon, 01 May 2017 17:34:14 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=WlKlwp8DTQgGpZT
cUZZaJUcPkQfDKl66R8mI1B/u1JU=; b=JN6gTbg9ChrZ3dKt8HYA8Avkzvp0N/5
ZcokckKWpP1W4WyBIgwfXduzLRtRQ/QHu+EoQwTKdUaF5FXYmNbc1D8BcsBa7PeE
3KFc2Z0xLhvcJp9lSLn4L+Qpfcv29j8BdxsFppm4nEGnIlqf8AVjRYRLME0PU/US
eYSWZhZjBxfk=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
fm1; bh=WlKlwp8DTQgGpZTcUZZaJUcPkQfDKl66R8mI1B/u1JU=; b=lvzF1Q4Z
+A71mFFqMhnCsoLQriRS3I7rVE5bpXy70uhrhGEPBDLrZbQj51TxgZm1F3366kI4
Di8ANgcpDGOYPK0V/V4c58jtxZCIQnYK+bk6KMvyM0MPe/zgB0MtHPqOUgCpF0//
8qrQwKKkps85mIfyvRtyTSgnu0zJBT4YLMNO3oIog40V8PNJQF28Cn6QOB9xk/Hd
HnO7AyJA6LO4JgN4eO1MO+54OAPxNSsNdowpoVs+cMeY8n0GSn8wrICKBvXDqjV3
HEoWI9llRg80bdTiA/fxGuMfd1EwMgU+sGAX60TFgQI+4Zl7ZZ0vnqrUR7m1Gfpq
BfTxQHogDhCLGA==
X-ME-Sender: <xms:1qkHWYZ78IjtHGxjdOjarinuYOG5PZ-bbll6pqkXNBUTucmDsJd4Iw>
X-Sasl-enc: hx03kR1C0X2ltrg5ilcflQeGlVEeFB409+hdJ3rlMTT5 1493674454
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id A4D41248B2;
Mon, 1 May 2017 17:34:14 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Michal Jastrzebski <michalx.k.jastrzebski@intel.com>,
Kuba Kozak <kubax.kozak@intel.com>
Cc: dev@dpdk.org, harry.van.haaren@intel.com, deepak.k.jain@intel.com
Date: Mon, 01 May 2017 23:34:13 +0200
Message-ID: <29874180.MbnUNaIQCm@xps>
In-Reply-To: <20170427144240.10188-1-michalx.k.jastrzebski@intel.com>
References: <20170427144240.10188-1-michalx.k.jastrzebski@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v1 0/6] Extended xstats API in ethdev library
to allow grouping of stats
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 01 May 2017 21:34:15 -0000
27/04/2017 16:42, Michal Jastrzebski:
> From: Kuba Kozak <kubax.kozak@intel.com>
>
> This patchset fixes following patches:
>
> commit ea85e7d711b6 ("ethdev: retrieve xstats by ID")
> commit a954495245c4 ("ethdev: get xstats ID by name")
> commit 1223608adb9b ("app/proc-info: support xstats by ID")
> commit 25e38f09af9c ("net/e1000: support xstats by ID")
> commit 923419333f5a ("net/ixgbe: support xstats by ID")
>
> This patch addresses some API concerns with the xstat patchset
> applied in DPDK 17.05 RC2.
>
> For clarity the first patch reverts all changes from the above
> commits.
It looks crazy to restart the feature from scratch, not showing the fixes.
But after a quick look, there was so many lines and functions to fix
that it is maybe a good idea.
At least, the history will be clear.
[...]
> Kuba Kozak (6):
> ethdev: revert patches extending xstats API in ethdev
> ethdev: retrieve xstats by ID
> ethdev: get xstats ID by name
> app/proc-info: support xstats by ID and by name
> net/e1000: support xstats by ID
> net/ixgbe: support xstats by ID
I am doing these small changes in your patches:
--- a/drivers/net/e1000/igb_ethdev.c
+++ b/drivers/net/e1000/igb_ethdev.c
@@ -395,7 +395,7 @@ static const struct eth_dev_ops eth_igb_ops = {
.link_update = eth_igb_link_update,
.stats_get = eth_igb_stats_get,
.xstats_get = eth_igb_xstats_get,
- .xstats_get_by_id = eth_igb_xstats_get_by_id,
+ .xstats_get_by_id = eth_igb_xstats_get_by_id,
.xstats_get_names_by_id = eth_igb_xstats_get_names_by_id,
.xstats_get_names = eth_igb_xstats_get_names,
.stats_reset = eth_igb_stats_reset,
--- a/drivers/net/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
@@ -532,7 +532,7 @@ static const struct eth_dev_ops ixgbe_eth_dev_ops = {
.link_update = ixgbe_dev_link_update,
.stats_get = ixgbe_dev_stats_get,
.xstats_get = ixgbe_dev_xstats_get,
- .xstats_get_by_id = ixgbe_dev_xstats_get_by_id,
+ .xstats_get_by_id = ixgbe_dev_xstats_get_by_id,
.stats_reset = ixgbe_dev_stats_reset,
.xstats_reset = ixgbe_dev_xstats_reset,
.xstats_get_names = ixgbe_dev_xstats_get_names,
--- a/lib/librte_ether/rte_ethdev.c
+++ b/lib/librte_ether/rte_ethdev.c
@@ -188,7 +188,7 @@ rte_eth_dev_allocated(const char *name)
static uint8_t
rte_eth_dev_find_free_port(void)
{
- unsigned int i;
+ unsigned i;
for (i = 0; i < RTE_MAX_ETHPORTS; i++) {
if (rte_eth_devices[i].state == RTE_ETH_DEV_UNUSED)
--- a/lib/librte_ether/rte_ethdev.h
+++ b/lib/librte_ether/rte_ethdev.h
@@ -185,7 +185,6 @@ extern "C" {
#include "rte_ether.h"
#include "rte_eth_ctrl.h"
#include "rte_dev_info.h"
-#include "rte_compat.h"
struct rte_mbuf;