From: Thomas Monjalon <thomas@monjalon.net>
To: Dekel Peled <dekelp@mellanox.com>
Cc: matan@mellanox.com, viacheslavo@mellanox.com,
rasland@mellanox.com, stable@dpdk.org, dev@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/mlx5: fix number of retries for UAR allocation
Date: Wed, 05 Aug 2020 16:14:40 +0200 [thread overview]
Message-ID: <2991040.2UnnyQe84E@thomas> (raw)
In-Reply-To: <70ff61d3d8431aeb73ee5c5c23c87e525dc221ec.1596446316.git.dekelp@mellanox.com>
03/08/2020 11:18, Dekel Peled:
> Previous patch added definition of number of retries for UAR allocation.
> This value is adequate for x86 systems with 4K pages.
> On power9 system with 64K pages the required value is 32.
> This patch updates the defined value from 2 to 32.
What about bigger pages?
> Fixes: a0bfe9d56f74 ("net/mlx5: fix UAR memory mapping type")
> Cc: stable@dpdk.org
No need of stable@dpdk.org because it was introduced in this release.
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> ---
> drivers/net/mlx5/mlx5_defs.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h
> index e5f7acc..c26d5a2 100644
> --- a/drivers/net/mlx5/mlx5_defs.h
> +++ b/drivers/net/mlx5/mlx5_defs.h
> @@ -202,9 +202,7 @@
> * UAR base address if UAR was not the first object in the UAR page.
> * It caused the PMD failure and we should try to get another UAR
> * till we get the first one with non-NULL base address returned.
> - * Should follow the rdma_core internal (not exported) definition
> - * MLX5_NUM_NON_FP_BFREGS_PER_UAR.
> */
> -#define MLX5_ALLOC_UAR_RETRY 2
> +#define MLX5_ALLOC_UAR_RETRY 32
It is missing a comment to explain the calculation with 64K page.
next prev parent reply other threads:[~2020-08-05 14:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 9:18 [dpdk-dev] " Dekel Peled
2020-08-05 14:14 ` Thomas Monjalon [this message]
2020-08-05 14:27 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2991040.2UnnyQe84E@thomas \
--to=thomas@monjalon.net \
--cc=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).